Wednesday, October 2, 2024
2 changes · saas-17.2
Miscellaneous changes
In #167973 (merged in 17.0+), we enabled the audit trail by default when loading the German localization. TSB requested that we indicate this explicitly in the manifest. task-none Forward-Port-Of: odoo/odoo#182295
Original PR description
In #167973 (merged in 17.0+), we enabled the audit trail by default when loading the German localization. TSB requested that we indicate this explicitly in the manifest. task-none Forward-Port-Of: odoo/odoo#182295
This issue occurs only in frontend debug (which I initially missed but odony caught), the problem is that the `InputConfirmationDialog` used for the creation dialog has a required `onInput` callback in its props but none is provided by the "new api key" button case. Props are (I assume) only validated in debug mode, so that's the only situation in which the error appears... and blocks users. While `onInput` seems like a useful hooks for input validation and stuff, it doesn't seem necessary to
Original PR description
This issue occurs only in frontend debug (which I initially missed but odony caught), the problem is that the `InputConfirmationDialog` used for the creation dialog has a required `onInput` callback in its props but none is provided by the "new api key" button case. Props are (I assume) only validated in debug mode, so that's the only situation in which the error appears... and blocks users. While `onInput` seems like a useful hooks for input validation and stuff, it doesn't seem necessary to mandate it, and the code specifically checks if it's unchecked (and ignores it in that case). OPW-4194305 Forward-Port-Of: odoo/odoo#182285