Daily updates from Odoo
Friday, October 11, 2024
16 changes · saas-17.2
Resolved issues and error corrections
This fixes the timesheet sale order item selector on project tasks so it includes orders linked to a company and its child contacts. Users can now correctly choose the relevant sale order item when a task customer is changed between related contacts.
Original PR description
Steps: - Create a contact with two sub-contacts: Sub1 and Sub2. - Create a service product that generates a project upon order. - Create a quotation for Sub1 with the created product and confirm it. - Go to the created project and create a task. - Edit the task and change the customer to Sub2. - Add a line in timesheet tab - Click on the dropdown of the sale order item. Issue: - The sale order item does not appear in the dropdown list. Cause: - The domain on `sale_line` is incorrect in the timesheet tab in the project task. Solution: - Correct the domain to link project timesheets to any sale order related to the company or its children. task-4081462 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes how accounting taxes are calculated when one tax affects the base used by later taxes. Follow-up tax amounts and reporting tags are now only applied when the next tax is configured to be affected by the previous tax, helping prevent incorrect invoice tax totals and reports.
Original PR description
we have the same functionality before this commit https://github.com/odoo/odoo/commit/ab0bdf0192120671010634978f202da35ddfc79f --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Customers can now use recently viewed product carousels to return to a previous product variant correctly. This fixes a broken page update when shoppers changed variants and then selected another variant from the carousel, improving the browsing experience on online stores.
Original PR description
Versions -------- - saas-17.2+ Steps ----- 1. Go to eCommerce; 2. go to a product page with variants; 3. open editor; 4. drag & drop a "Products" block from Dynamic Content; 5. click on the newly…
Versions -------- - saas-17.2+ Steps ----- 1. Go to eCommerce; 2. go to a product page with variants; 3. open editor; 4. drag & drop a "Products" block from Dynamic Content; 5. click on the newly added block; 6. set filter to "Recently Viewed Products"; 7. save; 8. change an attribute of the current product; 9. use the added carousel to go back to the previous variant. Issue ----- Nothing happens. Cause ----- Commit 016a72bae9c3 changed the event listener on website_sale from `hashchange` to `popevent` with a check on the event's `state?.newURL` attribute. Issue is that this will always be `undefined`, as there's no logic in place to push or replace states[^1] when viewing products. Solution -------- Revert the change, and have the listener trigger on `hashchange` events[^2] again. > [!Note] > In the future we could consider moving away from using the URL hash property[^3] for storing product attribute ids to a more conventional practice, as was intended by the commit that made this change. opw-4150284 [^1]: https://developer.mozilla.org/en-US/docs/Web/API/PopStateEvent/state [^2]: https://developer.mozilla.org/en-US/docs/Web/API/Window/hashchange_event [^3]: https://developer.mozilla.org/en-US/docs/Web/API/URL/hash
Miscellaneous changes
Currently, a traceback occurs when the user creates a link tracker having no scheme in the URL. To reproduce this issue: 1) Install website_link, email marketing 2) Create a new link tracker with a target URL from email marketing/configuration 3) Now remove the `http://` from the target URL 4) Navigate to website/site/link tracker Error:- ``` AttributeError: 'str' object has no attribute 'to_url' ``` This is because when the target URL has no `http://` the URL scheme will be
Original PR description
Currently, a traceback occurs when the user creates a link tracker having no scheme in the URL. To reproduce this issue: 1) Install website_link, email marketing 2) Create a new link tracker with a target URL from email marketing/configuration 3) Now remove the `http://` from the target URL 4) Navigate to website/site/link tracker Error:- ``` AttributeError: 'str' object has no attribute 'to_url' ``` This is because when the target URL has no `http://` the URL scheme will be an empty string. So it executes the else block in the below line. https://github.com/odoo/odoo/blob/8a1e6bef82fdaa98c60ef1e3fa519a03206a6788/addons/link_tracker/models/link_tracker.py#L54-L58 Clearly in the else block the value of `tracker.get_base_url()` is the string, when joining the `url` and `tracker.get_base_url()` it becomes a string. which leads to a traceback when `to_url()` is accessed from the string. sentry-5925121505 Forward-Port-Of: odoo/odoo#182556
**Steps to reproduce:** - Install Accounting, POS and l10n_cl - Switch to a Chilean company (e.g. CL Company) - Create a branch company for it - Create a product with a tax from "ILA" group - Switch to the branch company - Open a POS session - Sell the created product - When processing payment, select a Chilean customer and the invoice option **Issue:** A traceback is raised while trying to fetch some tax groups: - self.env.ref(f'account.{cid}_tax_group_ila') - self.env.ref(f'accou
Original PR description
**Steps to reproduce:** - Install Accounting, POS and l10n_cl - Switch to a Chilean company (e.g. CL Company) - Create a branch company for it - Create a product with a tax from "ILA" group - Switch…
**Steps to reproduce:**
- Install Accounting, POS and l10n_cl
- Switch to a Chilean company (e.g. CL Company)
- Create a branch company for it
- Create a product with a tax from "ILA" group
- Switch to the branch company
- Open a POS session
- Sell the created product
- When processing payment, select a Chilean customer and the invoice option
**Issue:**
A traceback is raised while trying to fetch some tax groups:
- self.env.ref(f'account.{cid}_tax_group_ila')
- self.env.ref(f'account.{cid}_tax_group_retenciones') where {cid} is the id of the branch company.
**Cause:**
There is no tax group defined in the branch company. The taxes and the tax groups are defined in the parent company.
**Solution:**
Do not raise an error if the XMLID cannot be found and also check tax groups from parent companies as the taxes could come from them.
Use the "ref" method defined in "account.chart.template" model that is doing it.
opw-4227241
Related enterprise PR: https://github.com/odoo/enterprise/pull/71476
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#182798In the new IoT image we use Chromium instead of Firefox, however it comes bundled with some extensions, namely uBlock, which use up disk space in the background. This leads to the `/tmp` directory getting full, which causes various errors and instability. After this change, the `/tmp` directory only reaches around 50% capacity, even after many restarts and webpage visits. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/
Original PR description
In the new IoT image we use Chromium instead of Firefox, however it comes bundled with some extensions, namely uBlock, which use up disk space in the background. This leads to the `/tmp` directory getting full, which causes various errors and instability. After this change, the `/tmp` directory only reaches around 50% capacity, even after many restarts and webpage visits. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#182883
Issue 1: Previously, the chart was being overlapped by the navigation on smaller screen sizes. This commit fixes the issue by limiting the max-width for navigations and also hiding the button text for smaller screens. Issue 2: Previously, after a certain amount of data, the bar colors defaulted to black as the dataIndex exceeded the colors array. This commit fixes the issue by using the modulo operation on dataIndex with the colors array to repeat the colors, and also added additional color
Original PR description
Issue 1: Previously, the chart was being overlapped by the navigation on smaller screen sizes. This commit fixes the issue by limiting the max-width for navigations and also hiding the button text for smaller screens. Issue 2: Previously, after a certain amount of data, the bar colors defaulted to black as the dataIndex exceeded the colors array. This commit fixes the issue by using the modulo operation on dataIndex with the colors array to repeat the colors, and also added additional colors referenced from reporting. Task-4089537 Forward-Port-Of: odoo/odoo#175704
Steps to reproduce: 1. Create a live session for a 'Quiz about your company' survey 2. Add images to your answers 2. Complete it with one user 3. Review your answer in the last 4. The images are getting overlap Technical Reason: on the user-side results page, images that were not properly handled were displayed at their default size. After this commit: it should be perfectly aligned. Task-4208130 Forward-Port-Of: odoo/odoo#181386
Original PR description
Steps to reproduce: 1. Create a live session for a 'Quiz about your company' survey 2. Add images to your answers 2. Complete it with one user 3. Review your answer in the last 4. The images are getting overlap Technical Reason: on the user-side results page, images that were not properly handled were displayed at their default size. After this commit: it should be perfectly aligned. Task-4208130 Forward-Port-Of: odoo/odoo#181386
Steps to reproduce: - Install serbian (latin) language - Add a keyword in serbian via SEO optimize menu - Traceback occurs This fix ensures that language variants, such as "sr@latin", are properly handled when making requests to the Google Autocomplete API for SEO suggestions. A test has been added. task-4210707 Forward-Port-Of: odoo/odoo#181400
Original PR description
Steps to reproduce: - Install serbian (latin) language - Add a keyword in serbian via SEO optimize menu - Traceback occurs This fix ensures that language variants, such as "sr@latin", are properly handled when making requests to the Google Autocomplete API for SEO suggestions. A test has been added. task-4210707 Forward-Port-Of: odoo/odoo#181400
Steps to reproduce the bug: - In Website edit mode. - click on the navbar. - For the "Format" option of the navbar, open the color picker. - Select any colors of the theme colors or any grayscale color. - Bug: the color is not applied to the navbar links. The bug has existed since commit [1], which added the feature to set a custom text color for the header. Two problems were there from the start: - First, the variable wasn't saved inside quotes like it should have been. - Seco
Original PR description
Steps to reproduce the bug: - In Website edit mode. - click on the navbar. - For the "Format" option of the navbar, open the color picker. - Select any colors of the theme colors or any grayscale…
Steps to reproduce the bug: - In Website edit mode. - click on the navbar. - For the "Format" option of the navbar, open the color picker. - Select any colors of the theme colors or any grayscale color. - Bug: the color is not applied to the navbar links. The bug has existed since commit [1], which added the feature to set a custom text color for the header. Two problems were there from the start: - First, the variable wasn't saved inside quotes like it should have been. - Second, there was no function to convert theme colors (e.g., "o-color-1") into hexadecimal values when generating the CSS. Because of this, only non-theme colors worked with this option. This commit fixes the issue but ensures that it doesn't change anything for users who already applied a color that didn’t work before. This way, their navbar text color won't suddenly change after the fix without them understanding why. [1]: https://github.com/odoo/odoo/commit/d54028e5ed33a0258d3f2aeeaea338ac04f8d402 opw-4065019 Forward-Port-Of: odoo/odoo#182570
When you made a downpayment on an order that contained product with fixed amount taxes, the tax would be paid multiple times. Steps to reproduce: ------------------- * Create a tax T1 with a fixed amount of 10€ * Create a product P1 using the tax T1 * Make a sale order and add the product P1 to it * Open PoS and make a downpayment for the sale order (e.g 50%) * You will already pay the 10€ of tax * Now if you make a second downpayment (e.g. 10%) > Observation: You still have the 10€ t
Original PR description
When you made a downpayment on an order that contained product with fixed amount taxes, the tax would be paid multiple times. Steps to reproduce: ------------------- * Create a tax T1 with a fixed amount of 10€ * Create a product P1 using the tax T1 * Make a sale order and add the product P1 to it * Open PoS and make a downpayment for the sale order (e.g 50%) * You will already pay the 10€ of tax * Now if you make a second downpayment (e.g. 10%) > Observation: You still have the 10€ tax to pay Why the fix: ------------ We match the behavior of sales app, and ignore the fixed price taxes when creating the downpayment lines. opw-4163579 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#182380
To avoid confusion, the field previously labeled as 'Purchase Order' has been renamed to 'Purchase Order Warning'. This clarifies that the field relates to triggering purchase warnings, not managing purchase orders themselves. This change only affects the field label, ensuring consistency in user expectations without altering the filter content or behavior. OPW-4141054 Forward-Port-Of: odoo/odoo#180176
Original PR description
To avoid confusion, the field previously labeled as 'Purchase Order' has been renamed to 'Purchase Order Warning'. This clarifies that the field relates to triggering purchase warnings, not managing purchase orders themselves. This change only affects the field label, ensuring consistency in user expectations without altering the filter content or behavior. OPW-4141054 Forward-Port-Of: odoo/odoo#180176
With this commit, the test test_ui is imported and runs smoothly. task-4143417 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#182832 Forward-Port-Of: odoo/odoo#181761
Original PR description
With this commit, the test test_ui is imported and runs smoothly. task-4143417 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#182832 Forward-Port-Of: odoo/odoo#181761
Fix the code at [1], Where the system tries to update the payment method, Modify the code to handle this issue where the network value might not exist. This can be done by providing a default value for ```payment_method_type``` if the network value is not present. Link [1]: https://github.com/odoo/odoo/blob/d30f41a49f614456c71a0a6974325030f552a0db/addons/payment_razorpay/models/payment_transaction.py#L391-L392 Sentry-5950544641 --- I confirm I have signed the CLA and read the PR guidel
Original PR description
Fix the code at [1], Where the system tries to update the payment method, Modify the code to handle this issue where the network value might not exist. This can be done by providing a default value for ```payment_method_type``` if the network value is not present. Link [1]: https://github.com/odoo/odoo/blob/d30f41a49f614456c71a0a6974325030f552a0db/addons/payment_razorpay/models/payment_transaction.py#L391-L392 Sentry-5950544641 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#182617
Before this commit, when users added a description to a pickup shipping method, the algorithm to prevent the payment button from being enabled when no pickup location was selected failed. Now, the payment button will be disabled when no pickup is selected even if the shipping method has a description. opw-4040317 Forward-Port-Of: odoo/odoo#183222
Original PR description
Before this commit, when users added a description to a pickup shipping method, the algorithm to prevent the payment button from being enabled when no pickup location was selected failed. Now, the payment button will be disabled when no pickup is selected even if the shipping method has a description. opw-4040317 Forward-Port-Of: odoo/odoo#183222
Before this commit, when some extension in chrome threw an unhandledrejection event, Chrome apparently redacts it. The error popped into Odoo as very generic one. The error Dialog was spawned, intempestively. After this commit, we use a heuristic to block that kind of errors: Apparently, the error event is a CustomEvent, with no `reason`. opw-4246402 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I
Original PR description
Before this commit, when some extension in chrome threw an unhandledrejection event, Chrome apparently redacts it. The error popped into Odoo as very generic one. The error Dialog was spawned, intempestively. After this commit, we use a heuristic to block that kind of errors: Apparently, the error event is a CustomEvent, with no `reason`. opw-4246402 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#183327