Odoo Changelog — 2024-10-11

Friday, October 11, 2024

3 changes · saas-17.2

Bug Fixes(3)

Resolved issues and error corrections

[FIX] sale_timesheet: correct the domain of task's sale order item

Coresaas-17.2sale_timesheet

This fixes the timesheet sale order item selector on project tasks so it includes orders linked to a company and its child contacts. Users can now correctly choose the relevant sale order item when a task customer is changed between related contacts.

Original PR description

Steps:
- Create a contact with two sub-contacts: Sub1 and Sub2.
- Create a service product that generates a project upon order.
- Create a quotation for Sub1 with the created product and confirm it.
- Go to the created project and create a task.
- Edit the task and change the customer to Sub2.
- Add a line in timesheet tab
- Click on the dropdown of the sale order item.

Issue:
- The sale order item does not appear in the dropdown list.

Cause:
- The domain on `sale_line` is incorrect in the timesheet tab in the project task.

Solution:
- Correct the domain to link project timesheets to any sale order related to the company or its children.

task-4081462

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#timesheets#project tasks#sale orders#customer contacts

[FIX] account: consider subsequent tax and tags only when next tax is_base_affected is True

PR #180312

Coresaas-17.2accountMEDIUM

This fixes how accounting taxes are calculated when one tax affects the base used by later taxes. Follow-up tax amounts and reporting tags are now only applied when the next tax is configured to be affected by the previous tax, helping prevent incorrect invoice tax totals and reports.

Original PR description

we have the same functionality before this commit https://github.com/odoo/odoo/commit/ab0bdf0192120671010634978f202da35ddfc79f


---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#taxes#invoicing#accounting

[FIX] website_sale: update window after selecting variant in carousel

PR #183210

Coresaas-17.2website_saleMEDIUM

Customers can now use recently viewed product carousels to return to a previous product variant correctly. This fixes a broken page update when shoppers changed variants and then selected another variant from the carousel, improving the browsing experience on online stores.

Original PR description

Versions -------- - saas-17.2+ Steps ----- 1. Go to eCommerce; 2. go to a product page with variants; 3. open editor; 4. drag & drop a "Products" block from Dynamic Content; 5. click on the newly…

Versions
--------
- saas-17.2+

Steps
-----
1. Go to eCommerce;
2. go to a product page with variants;
3. open editor;
4. drag & drop a "Products" block from Dynamic Content;
5. click on the newly added block;
6. set filter to "Recently Viewed Products";
7. save;
8. change an attribute of the current product;
9. use the added carousel to go back to the previous variant.

Issue
-----
Nothing happens.

Cause
-----
Commit 016a72bae9c3 changed the event listener on website_sale from `hashchange` to `popevent` with a check on the event's `state?.newURL` attribute. Issue is that this will always be `undefined`, as there's no logic in place to push or replace states[^1] when viewing products.

Solution
--------
Revert the change, and have the listener trigger on `hashchange` events[^2] again.

> [!Note]
> In the future we could consider moving away from using the URL hash property[^3] for storing product attribute ids to a more conventional practice, as was intended by the commit that made this change.

opw-4150284

[^1]: https://developer.mozilla.org/en-US/docs/Web/API/PopStateEvent/state
[^2]: https://developer.mozilla.org/en-US/docs/Web/API/Window/hashchange_event
[^3]: https://developer.mozilla.org/en-US/docs/Web/API/URL/hash

#ecommerce#product variants#carousel

Steps: - Create a contact with two sub-contacts: Sub1 and Sub2. - Create a service product that generates a project upon order. - Create a quotation for Sub1 with the created product and confirm it. - Go to the created project and create a task. - Edit the task and change the customer to Sub2. - Add a line in timesheet tab - Click on the dropdown of the sale order item. Issue: - The sale order item does not appear in the dropdown list. Cause: - The domain on `sale_line` is incorrect in the timesheet tab in the project task. Solution: - Correct the domain to link project timesheets to any sale order related to the company or its children. task-4081462 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

we have the same functionality before this commit https://github.com/odoo/odoo/commit/ab0bdf0192120671010634978f202da35ddfc79f --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Versions -------- - saas-17.2+ Steps ----- 1. Go to eCommerce; 2. go to a product page with variants; 3. open editor; 4. drag & drop a "Products" block from Dynamic Content; 5. click on the newly added block; 6. set filter to "Recently Viewed Products"; 7. save; 8. change an attribute of the current product; 9. use the added carousel to go back to the previous variant. Issue ----- Nothing happens. Cause ----- Commit 016a72bae9c3 changed the event listener on website_sale from `hashchange` to `popevent` with a check on the event's `state?.newURL` attribute. Issue is that this will always be `undefined`, as there's no logic in place to push or replace states[^1] when viewing products. Solution -------- Revert the change, and have the listener trigger on `hashchange` events[^2] again. > [!Note] > In the future we could consider moving away from using the URL hash property[^3] for storing product attribute ids to a more conventional practice, as was intended by the commit that made this change. opw-4150284 [^1]: https://developer.mozilla.org/en-US/docs/Web/API/PopStateEvent/state [^2]: https://developer.mozilla.org/en-US/docs/Web/API/Window/hashchange_event [^3]: https://developer.mozilla.org/en-US/docs/Web/API/URL/hash