Search
Navigate
Branch
Sunday, October 13, 2024
17 changes
3 changes
Miscellaneous changes
Forward-Port-Of: odoo/odoo#183367
Original PR description
Forward-Port-Of: odoo/odoo#183367
Steps to reproduce: - Project > Pick any task > Debug Mode - Studio > View tab > Tick 'Show invisible elements' - Scroll to 'Sales Order' and click it - Untick 'Invisible' then tick and untick readonly - Close > you should have a Sales Order field on the task - Click to change it's value An error occurs because the 'commercial_partner_id' field was removed from task in 17.0 in dcbdb6e690f29bc5327d7067688c93071d9a6b2d. Because of this the domain which filters 'Sales Order' (which contain
Original PR description
Steps to reproduce: - Project > Pick any task > Debug Mode - Studio > View tab > Tick 'Show invisible elements' - Scroll to 'Sales Order' and click it - Untick 'Invisible' then tick and untick readonly - Close > you should have a Sales Order field on the task - Click to change it's value An error occurs because the 'commercial_partner_id' field was removed from task in 17.0 in dcbdb6e690f29bc5327d7067688c93071d9a6b2d. Because of this the domain which filters 'Sales Order' (which contains this field) cannot be evaluated. Since the field is still available on the sale_order model, we can simply invert the child_of relation: from sale_order.partner_id child_of task.commercial_partner_id to sale_order.commercial_partner_id parent_of task.partner_id Which should serve essentially the same purpose. opw-4199947 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#182945
Steps to reproduce: - use ODOO.BALANCE("1",,1) (make sure it returns some value) - switch to another company (company 1 should not be active) => the balance doesn't appear even though the company_id is provided and set to 1 Issue introduced with a707f8345cec8f40407 Task: 4223319 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.
Original PR description
Steps to reproduce:
- use ODOO.BALANCE("1",,1) (make sure it returns some value)
- switch to another company (company 1 should not be active) => the balance doesn't appear even though the company_id is provided
and set to 1
Issue introduced with a707f8345cec8f40407
Task: 4223319
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#1823442 changes
Miscellaneous changes
Steps to reproduce: - Install subscription and pos_sale_subscription - Create a sale order with a recurring product (a subscription) - Settle the sale order in the point of sale - The date of the next invoice is not updated To fix this issue, when the pos_order is paid, we will update the next invoice date of all sale orders in lines that are of type subscription. opw-4072950 Forward-Port-Of: odoo/enterprise#71722 Forward-Port-Of: odoo/enterprise#71204
Original PR description
Steps to reproduce: - Install subscription and pos_sale_subscription - Create a sale order with a recurring product (a subscription) - Settle the sale order in the point of sale - The date of the next invoice is not updated To fix this issue, when the pos_order is paid, we will update the next invoice date of all sale orders in lines that are of type subscription. opw-4072950 Forward-Port-Of: odoo/enterprise#71722 Forward-Port-Of: odoo/enterprise#71204
12 changes
Enhancements to existing features
Portal forms now check that a selected state or region belongs to the chosen country and require it when the country’s rules call for one. This helps prevent incorrect customer address details and gives users clearer guidance when completing forms.
Original PR description
Description of the issue/feature this PR addresses: Currently, there is no validation ensuring the selected state corresponds to the chosen country, nor checks that enforce a state selection when required by the country. Current behavior before PR: Users can select a state that doesn't belong to the selected country. No validation exists to require a state selection when the country mandates it. Desired behavior after PR is merged: The selected state will be validated to ensure it belongs to the selected country. A state will be mandatory when the country requires it, and appropriate error messages will be shown when these conditions are not met. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Steps: - Create a contact with two sub-contacts: Sub1 and Sub2. - Create a service product that generates a project upon order. - Create a quotation for Sub1 with the created product and confirm it. - Go to the created project and create a task. - Edit the task and change the customer to Sub2. - Add a line in the timesheet tab. - Click on the dropdown of the sale order item. Issue: - The sale order item does not appear in the dropdown list. Cause: - Incorrect domain on sale order
Original PR description
Steps: - Create a contact with two sub-contacts: Sub1 and Sub2. - Create a service product that generates a project upon order. - Create a quotation for Sub1 with the created product and confirm it. - Go to the created project and create a task. - Edit the task and change the customer to Sub2. - Add a line in the timesheet tab. - Click on the dropdown of the sale order item. Issue: - The sale order item does not appear in the dropdown list. Cause: - Incorrect domain on sale order items in timesheets in the project task. Solution: - Correct the domain to link project task timesheets to any sale order related to the company or its children. task-4081462 Forward-Port-Of: odoo/enterprise#71804 Forward-Port-Of: odoo/enterprise#71438
Portal forms now check that a selected state or province belongs to the chosen country and require it when the country’s rules demand it. This helps prevent incorrect or manipulated address data from entering the system, improving data quality and reducing downstream errors.
Original PR description
Description of the issue/feature this PR addresses: Currently, there is no validation ensuring the selected state corresponds to the chosen country, nor checks that enforce a state selection when required by the country. Current behavior before PR: Users can select a state that doesn't belong to the selected country. No validation exists to require a state selection when the country mandates it. Desired behavior after PR is merged: The selected state will be validated to ensure it belongs to the selected country. A state will be mandatory when the country requires it, and appropriate error messages will be shown when these conditions are not met. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Portal users will now be prompted to choose a valid state or region when the selected country requires it. This helps prevent incorrect address details by ensuring the state matches the chosen country before submission.
Original PR description
Description of the issue/feature this PR addresses: Currently, there is no validation ensuring the selected state corresponds to the chosen country, nor checks that enforce a state selection when required by the country. Current behavior before PR: Users can select a state that doesn't belong to the selected country. No validation exists to require a state selection when the country mandates it. Desired behavior after PR is merged: The selected state will be validated to ensure it belongs to the selected country. A state will be mandatory when the country requires it, and appropriate error messages will be shown when these conditions are not met. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
The update corrects how the activity and message panel is added to Kenyan OSCU customs import forms. This ensures users can see and use the form communication area as expected after recent platform syntax changes.
Original PR description
before this commit, the chatter is added with old syntax and it is no more bringing the proper syntax for the chatter after this commit, the new chatter tag is used to add the chatter for form
Miscellaneous changes
**Steps to reproduce:** - Install Accounting, POS and l10n_cl - Switch to a Chilean company (e.g. CL Company) - Create a branch company for it - Create a product with a tax from "ILA" group - Switch to the branch company - Open a POS session - Sell the created product - When processing payment, select a Chilean customer and the invoice option **Issue:** A traceback is raised while trying to fetch some tax groups: - self.env.ref(f'account.{cid}_tax_group_ila') - self.env.ref(f'accou
Original PR description
**Steps to reproduce:** - Install Accounting, POS and l10n_cl - Switch to a Chilean company (e.g. CL Company) - Create a branch company for it - Create a product with a tax from "ILA" group - Switch…
**Steps to reproduce:**
- Install Accounting, POS and l10n_cl
- Switch to a Chilean company (e.g. CL Company)
- Create a branch company for it
- Create a product with a tax from "ILA" group
- Switch to the branch company
- Open a POS session
- Sell the created product
- When processing payment, select a Chilean customer and the invoice option
**Issue:**
A traceback is raised while trying to fetch some tax groups:
- self.env.ref(f'account.{cid}_tax_group_ila')
- self.env.ref(f'account.{cid}_tax_group_retenciones') where {cid} is the id of the branch company.
**Cause:**
There is no tax group defined in the branch company. The taxes and the tax groups are defined in the parent company.
**Solution:**
Do not raise an error if the XMLID cannot be found and also check tax groups from parent companies as the taxes could come from them.
Use the "ref" method defined in "account.chart.template" model that is doing it.
opw-4227241
Related enterprise PR: https://github.com/odoo/enterprise/pull/71476
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#183256
Forward-Port-Of: odoo/odoo#182798The domain set on the list datasource did not exclude the draft and cancelled invoices as it was for the other datasources. task-3999225 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#182624
Original PR description
The domain set on the list datasource did not exclude the draft and cancelled invoices as it was for the other datasources. task-3999225 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#182624
Steps: - Create a contact with two sub-contacts: Sub1 and Sub2. - Create a service product that generates a project upon order. - Create a quotation for Sub1 with the created product and confirm it. - Go to the created project and create a task. - Edit the task and change the customer to Sub2. - Add a line in timesheet tab - Click on the dropdown of the sale order item. Issue: - The sale order item does not appear in the dropdown list. Cause: - The domain on `sale_line` is incorre
Original PR description
Steps: - Create a contact with two sub-contacts: Sub1 and Sub2. - Create a service product that generates a project upon order. - Create a quotation for Sub1 with the created product and confirm it. - Go to the created project and create a task. - Edit the task and change the customer to Sub2. - Add a line in timesheet tab - Click on the dropdown of the sale order item. Issue: - The sale order item does not appear in the dropdown list. Cause: - The domain on `sale_line` is incorrect in the timesheet tab in the project task. Solution: - Correct the domain to link project timesheets to any sale order related to the company or its children. task-4081462 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#175074
**Steps to reproduce:** - Install Accounting and l10n_cl_edi_boletas - Switch to a Chilean company (e.g. CL Company) - Create a branch company for it - Create a product with a tax from "ILA" group - Switch to the branch company - Create an invoice with the created product - Confirm it **Issue:** A traceback is raised while trying to fetch some tax groups: - self.env.ref(f'account.{cid}_tax_group_ila') - self.env.ref(f'account.{cid}_tax_group_retenciones') where {cid} is the id of th
Original PR description
**Steps to reproduce:** - Install Accounting and l10n_cl_edi_boletas - Switch to a Chilean company (e.g. CL Company) - Create a branch company for it - Create a product with a tax from "ILA" group -…
**Steps to reproduce:**
- Install Accounting and l10n_cl_edi_boletas
- Switch to a Chilean company (e.g. CL Company)
- Create a branch company for it
- Create a product with a tax from "ILA" group
- Switch to the branch company
- Create an invoice with the created product
- Confirm it
**Issue:**
A traceback is raised while trying to fetch some tax groups:
- self.env.ref(f'account.{cid}_tax_group_ila')
- self.env.ref(f'account.{cid}_tax_group_retenciones') where {cid} is the id of the branch company.
**Cause:**
There is no tax group defined in the branch company. The taxes and the tax groups are defined in the parent company.
**Solution:**
Do not raise an error if the XMLID cannot be found and also check tax groups from parent companies as the taxes could come from them.
Use the "ref" method defined in "account.chart.template" model that is doing it.
opw-4227241
Related comminity PR: https://github.com/odoo/odoo/pull/182798
Forward-Port-Of: odoo/enterprise#71708
Forward-Port-Of: odoo/enterprise#71476**Steps to reproduce:** - Install Accounting and l10n_de_reports - Switch to a German company - Create a 19% included tax - Create an invoice with the following line: * Product: [any] * Quantity: 1.00 * Price: 19.95 * Taxes: [the 19% included tax] - Confirm the invoice - Go to "Accounting / Reporting / Audit Reports / General Ledger" - Download "DATEV DATA (ZIP)" and check "EXTF_accounting_entries.csv" **Issue:** The line for the created invoice has an amount of 19.94 inst
Original PR description
**Steps to reproduce:** - Install Accounting and l10n_de_reports - Switch to a German company - Create a 19% included tax - Create an invoice with the following line: * Product: [any] * Quantity:…
**Steps to reproduce:** - Install Accounting and l10n_de_reports - Switch to a German company - Create a 19% included tax - Create an invoice with the following line: * Product: [any] * Quantity: 1.00 * Price: 19.95 * Taxes: [the 19% included tax] - Confirm the invoice - Go to "Accounting / Reporting / Audit Reports / General Ledger" - Download "DATEV DATA (ZIP)" and check "EXTF_accounting_entries.csv" **Issue:** The line for the created invoice has an amount of 19.94 instead of 19.95. **Cause:** As the tax is included, the balance on the line is computed and rounded. When the report is generated, "compute_all" is executed with the rounded balance to retrieve the total price with the taxes. Because the balance used in "compute_all" has been rounded and therefore is not exactly the same than the original computed value, there can be a 0.01 difference. **Solution:** Use directly "price_total" field when available. opw-4191876 Forward-Port-Of: odoo/enterprise#71729 Forward-Port-Of: odoo/enterprise#70801
In this context, the sentence seems better phrased with "en" rather than "dans": - Vous avez lettré 2 transactions dans 45 secondes. Becomes: - Vous avez lettré 2 transactions en 45 secondes. Forward-Port-Of: odoo/enterprise#71386 Forward-Port-Of: odoo/enterprise#70449
Original PR description
In this context, the sentence seems better phrased with "en" rather than "dans": - Vous avez lettré 2 transactions dans 45 secondes. Becomes: - Vous avez lettré 2 transactions en 45 secondes. Forward-Port-Of: odoo/enterprise#71386 Forward-Port-Of: odoo/enterprise#70449
Steps to reproduce: - Install subscription and pos_sale_subscription - Create a sale order with a recurring product (a subscription) - Settle the sale order in the point of sale - The date of the next invoice is not updated To fix this issue, when the pos_order is paid, we will update the next invoice date of all sale orders in lines that are of type subscription. opw-4072950 Forward-Port-Of: odoo/enterprise#71722 Forward-Port-Of: odoo/enterprise#71204
Original PR description
Steps to reproduce: - Install subscription and pos_sale_subscription - Create a sale order with a recurring product (a subscription) - Settle the sale order in the point of sale - The date of the next invoice is not updated To fix this issue, when the pos_order is paid, we will update the next invoice date of all sale orders in lines that are of type subscription. opw-4072950 Forward-Port-Of: odoo/enterprise#71722 Forward-Port-Of: odoo/enterprise#71204
Steps: - Create a contact with two sub-contacts: Sub1 and Sub2. - Create a service product that generates a project upon order. - Create a quotation for Sub1 with the created product and confirm it. - Go to the created project and create a task. - Edit the task and change the customer to Sub2. - Add a line in the timesheet tab. - Click on the dropdown of the sale order item. Issue: - The sale order item does not appear in the dropdown list. Cause: - Incorrect domain on sale order
Original PR description
Steps: - Create a contact with two sub-contacts: Sub1 and Sub2. - Create a service product that generates a project upon order. - Create a quotation for Sub1 with the created product and confirm it. - Go to the created project and create a task. - Edit the task and change the customer to Sub2. - Add a line in the timesheet tab. - Click on the dropdown of the sale order item. Issue: - The sale order item does not appear in the dropdown list. Cause: - Incorrect domain on sale order items in timesheets in the project task. Solution: - Correct the domain to link project task timesheets to any sale order related to the company or its children. task-4081462 Forward-Port-Of: odoo/enterprise#71438