Original PR description

In the Netherlands localization, the Balance Sheet and Profit&Loss reports are only currently built on account codes. We want to add another version of the accounting reports that uses account tags.

Enterprise PR: odoo/enterprise#58487
Task link: https://www.odoo.com/web#model=project.task&id=3794536
task-3794536

Forward-Port-Of: odoo/odoo#157362

Original PR description

## Description
Following cef5ae8a80988c4e0529c1770b1c1e573490f6e7, the default `batch_size` for generating the mails was changed from `500`->`50`. But one instance seems to have been missed, during the generation of mails in the wizard, which is used by the mass-mailing cron.
To address this, we are just changing `self.batch_size` in the wizard from `500`->`50` (the variable may have been overridden in custom code, so we keep the static variable)

Backport of ac51f29f91e34cf4794164658a8c27d8b7759230

## Reference
opw-4142511

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#180830

Original PR description

… is not set"

This reverts commit fd1da69f8331dbc55be2d164fad381fca1622a67.

The l10n_it_document_type belongs to `l10n_it_edi_ndd` module.
This module exists to add this stored field that was missing.
When the error that this commit tried to fix happens, which is due
to the fact that the compute doesn't find a correct matching document, we
don't want to block the flow. The user can still set a document type himself
through Odoo (if he has the aforementioned module installed) or directly in
the XML.

Forward-Port-Of: odoo/odoo#184481

Original PR description

Issue: The `.o_default_snippet_text` class was not being removed when applying formatting (e.g., bold, italic, font-size) to a portion of the default text in an editable snippet.

Steps to reproduce:

1. Insert a snippet with default placeholder text containing the `.o_default_snippet_text` class. E.g. A Banner.
2. Select part of the placeholder text (not the entire text). E.g. "Easily" in the "Banner" snippet
3. Apply a formatting command (bold, italic, font-size change).
4. The formatting is applied, but the `.o_default_snippet_text` class remains on the element.
5. Save and re-edit
6. Click on the title -> The text is entirely selected because it's still treated as a default text.

This commit ensures the correct behaviour of this feature.

task-4147162

Forward-Port-Of: odoo/odoo#183179

Original PR description

Follow up of https://github.com/odoo/odoo/pull/171393

The method should forward all kwargs to the super call.

Issue manifesting in particular in 18.0 when attempting to fix cloud storage at https://github.com/odoo/odoo/pull/184331

Forward-Port-Of: odoo/odoo#184506

Original PR description

New image development was started in August but
now being released in October, so bump version from 24.08 -> 24.10.

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#184318

Original PR description

With this commit, the tour test_01_ui is fixed for differents tests triggers: community version and no demo data.

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#183578
Forward-Port-Of: odoo/odoo#183503

Original PR description

Steps to reproduce the bug:

- In website dit mode.
- Click on the footer.
- Enable the "Scroll Top Button" option for the footer.
- Disable the "Copyright" option for the footer.
- Bug: There is a white space below the footer.

task-4208475

Forward-Port-Of: odoo/odoo#183514

Original PR description

As the portal user, change your profile picture to a svg image, then show it via the normal /web/image URL. The downloaded picture lacks a valid content-type header.

Related stored attachment fields were served via the method `Stream.from_binary_field` instead of `Stream.from_attachment`, only the latter is capable of copying the attachment mimetype on the stream.

---

Also gave a shot at making the `odoo-bin --test-tags webserver:TestHttpStaticWebServer` test green again.

Forward-Port-Of: odoo/odoo#183596
Forward-Port-Of: odoo/odoo#177105

Original PR description

Steps to reproduce the issue:

- In website edit mode.
- Inspect the HTML code of the "Video" snippet in the snippet menu.
- The YouTube iframe is loaded even though the "Video" snippet has not
been dropped into the page.

We need to fix this in stable because a recent update of Chrome [1] is
now triggering an error during several tests in edit mode on runbot.
This error is due to the fact that we are contacting the YouTube API
during the tests, which cannot be done when a test is being executed on
runbot. Note that this fix is no longer necessary starting from version
saas-17.4 because, from this version, the HTML code of the snippets are
no longer in the snippet menu.

After this commit, snippets containing an iframe will have their iframe
loaded only when the drag-and-drop starts.

[1]: https://developer.chrome.com/release-notes/125#the_compute_pressure_api

runbot-102187

Forward-Port-Of: odoo/odoo#184443

Original PR description

Problem:
When editing images, the company context is not respected during operations such as `get_image_info` and `modify_image`. This occurs because we use `self._clean_context()` during creating of attachment which was introduced [here](https://github.com/odoo/odoo/commit/a137f22363ff538ab86f50d15851730af1b8ed76) , it strips the company from the context. This fix ensures that company information is skipped for these methods as well, similar to attachment creation.

Steps to Reproduce:
- Select a company other than the default one.
- Create a quotation.
- In the description, add an image and save.
- Try to crop the image and save again. The operation fails due to the company context issue.

opw-4173391
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#183112

Original PR description

Versions
--------
- 16.0+

Steps
-----
1. Create a zero-priced product template;
2. add some attribute values;
3. configure price extras for the attributes;
4. configure eCommerce to prevent sale of zero-priced products;
5. go to eCommerce products page.

Issue
-----
Product is displayed as "Not Available For Sale," even though you can click on it, select a price-extra attribute, add it to cart, and purchase it.

Cause
-----
The template doesn't consider potential `price_extra` attributes when displaying the not available message.

Solution
--------
Add a `t-elif` element to the template, checking if the product has any non-zero price-extra attribute values, if so, don't display the not available message, but also don't display the zero price.

opw-4225183

Forward-Port-Of: odoo/odoo#184052

Original PR description

Description of the issue/feature this PR addresses:
It is necessary to be able to select document type "60 CUENTAS DE VENTA Y LIQUIDO PRODUCTO A" in an invoice  or refund.
    
Current behavior before PR:
User is not able to select document types "60 CUENTAS DE VENTA Y LIQUIDO PRODUCTO A" in an invoice or refund.

Desired behavior after PR is merged:
User is able to select document types "60 CUENTAS DE VENTA Y LIQUIDO PRODUCTO A" in an invoice or refund.
    
Task Adhoc side: 40557
Task latam: 1254

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#176858

Original PR description

When starting a PoS session a useless sequence was created every time

Steps to reproduce:
-------------------
* Open a PoS session on different days
> Observation: Go to the sequence list in the settings, there is one
sequence for each days you opened a session

Why the fix:
------------
The sequence was actually not used so we just remove it.

opw-4166554
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#184503

Original PR description

This Error occurs when a user tries to archive multiple journals.

Steps to reproduce:

- Install the ```account``` module
- Go to Invoicing / Configuration / Accounting / Journals.
- Select two or more journals and try to archive them.

```ValueError: Expected singleton: account.journal(15, 18)```

An error occurs at [1] because the system attempts to retrieve the id from 'self', which contains multiple records.

link [1]:https://github.com/odoo/odoo/blob/1f7debc24bab4e0a7f2ef0d85e50d9381e1826cd/addons/account/models/account_journal.py#L801

To resolve this issue, Use an ```ids``` instead of an ```id``` to get a multiple records.

Sentry-5917175119

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#182664
Forward-Port-Of: odoo/odoo#182043

Original PR description

**Steps to reproduce the bug:**
- Enable the "Expiration Date" feature in inventory settings.
- Create a non-tracked product "P1".
- Create a receipt with one unit of P1.
- Mark it as "To Do".
- Go to the detailed operation.

**Problem:**
You are able to set an expiration date even though the product is not tracked.

opw-4256125

Forward-Port-Of: odoo/odoo#183993

Original PR description

Bootstrap adds an ugly white background to `table` tags when we add the `table` class.  
We now force it to be transparent.

Forward-Port-Of: odoo/odoo#184515

Original PR description

Issue:

if 'sequence' in vals and self and self[-1].id == self._prefetch_ids[-1]: TypeError: 'PrefetchX2many' object is not subscriptable

Cause of the issue:
PrefetchX2many object does not have __getitem__ method, only __iter__




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#183224

Original PR description

**Current behavior before PR:**

When an elements next sibling is a whitespace node, followed by a `contentEditable=false` element, performing the deleteforward action did not remove the `contentEditable=false` element.

**Desired behavior after PR is merged:**

When an elements next sibling is a whitespace node, followed by a `contentEditable=false` element, performing the deleteforward action will now remove both the whitespace and the entire `contentEditable=false` element.

task:4058770

Forward-Port-Of: odoo/odoo#179639

Original PR description

*l10n_din5008, l10n_din5008_purchase, l10n_din5008_repair, l10n_din5008_sale, l10n_din5008_stock

Related to: https://github.com/odoo/enterprise/pull/71710

Forward-Port-Of: odoo/odoo#183971
Forward-Port-Of: odoo/odoo#183268

Original PR description

An error message was missing a space in between "a" and "hamburger" in
"ahamburger". This commit fixes this typo.

Task-4173938

Forward-Port-Of: odoo/odoo#184584

Original PR description

Steps
---
* install `mrp`, `purchase`
* create the following products:
    * P, storable, route = manucfature, bom:
            * C storable (qty = 1)
            * K storable, (qty = 1) kit bom:
                * C (qty = 1)
* set the quantiy on hand for C to 1
* create a purchase order for 20 C
* create an MO for 5 P > *Confirm*
* in the overview we have 2 component line (each for C), but the 2nd
  line's status is *To Order* even though we already have a PO.
  if we look at the details of the first line, we can see the replenishment
  for the second line was wrongly assigned to the first.

Cause
---
When matching replenishments to bom line moves, we check if quantity
from the replenishments is enough for the move, if so we go on to the
next move. But when we do this we do not account for pre-reserved
quantity of partially available moves.

opw-4128775

Forward-Port-Of: odoo/odoo#178261

Original PR description

Problem:
After [this commit](https://github.com/odoo/odoo/commit/59e252c715ba96af5ec66f9c543c2c6195082c7d), the editor fails to properly check the state of selections containing the character `\ufeff`. Since `\ufeff` has no style applied, any style check on a selection that includes this character returns `false`. While reverting the change would break support for styling elements containing only spaces, the fix involves checking if an element is a BOM character and assuming it is styled.

Steps to reproduce:
- Open any page with the web editor.
- Add text with part of it formatted as a link.
- Try toggling any style (e.g., bold, italic).
- The style is applied but cannot be reverted, and the button state remains off.

opw-4213717

Forward-Port-Of: odoo/odoo#181793

Original PR description

This hook is used for fix in the corresponding enterprise commit. We do it this way instead of defining everything in enterprise for clarity and robustness.

Forward-Port-Of: odoo/odoo#184152

Original PR description

nodeValue on `input` always return null. To get the previous value of
the input cell, the query should be
`matrixInput.attributes.value.nodeValue`. That way unchanged cell won't
be send to the list of data to be updated.

opw: 3987284

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#184294

Original PR description

Issue -->

The field `available_currency_ids` is an empty recordset since `authorize` supports all currencies.
We're assuming that `authorize` supports all currencies because it uses the base `_get_supported_currencies` 
method which returns all currencies.

Solution --> Return the company currency as validation currency if no currency is set on the payment provider.

opw-4252974

Forward-Port-Of: odoo/odoo#184226

Original PR description

**Current behavior:**
Creating a new picking, adding some moves, then adding/changing the partner_id field all without saving will remove the added moves.

**Expected behavior:**
Changing the partner shouldn't affect the moves.

**Steps to reproduce:**
1. Create a new picking, add some moves, then add a partner (all without saving)

2. Observe the moves disappear after adding the partner

**Cause of the issue:**
In the onchange handling partner_id changes, we overwrite the new virtual moves with values and mark them as modified. This causes them to eventually get invalidated and they aren't saved once the update (overwrite) resolves.

**Fix:**
Don't update virtual moves (records without an _origin).

opw-4120108

Forward-Port-Of: odoo/odoo#182606

Original PR description

Variant Mixin logic is only used on ecommerce since the drop of the old product configurator (optional products modal) replaced by the backend one, thus `isWebsite` is always truthy and useless to check

Avoid verification of rental dates when the product is not a rental product.

Also adapt to community changes with the removal of `price_extra` key from combination info.

See also:
odoo/odoo#180774

Original PR description

The JS framework introduced the option to reorder records from the map view side panel. This is particularly useful to optimize the itinerary.
However, this feature is only available when records are ordered by an integer field, which isn't the case at the moment in project/fsm.
As a consequence, we need to order tasks by 'sequence > start date' in the map view of project/fsm.

task-4245177

Original PR description

In this commit:
merging `l10n_in_reports_gstr_spreadsheet` into `l10n_in_reports_gstr`

Related

- https://github.com/odoo/upgrade/pull/6630

task-4266231

Original PR description

The demo data are updated to make reference to odoo and remove external reference to other companies.

task-4071950

Original PR description

This commit improve UX and usability of Amazon marketplace.
- Compute name of account from marketplace so user don't
explicitly need to type account name to create an account.
- Add Pause and Resume action and button to connect and
disconnect account.
- Remove Marketplace and Products button from setting
and display `Link my Account` when user don't any already
existing account.
- Improve account form view.
- Add custom `New` button in list view instead main one
to open quick create dialog instead form view.

task-3627857

Original PR description

This commit replaces the use of `core.{_t,_lt}` with its equivalent from `@web/core/l10n/translation`. Calling these functions will now result in a warning.

This paves the way for the unification of `_t` and `_lt` into a single function, and the removal of the legacy `web.translation`.

Community: https://github.com/odoo/odoo/pull/124285

Original PR description

This commit removes the date widget on datetime fields. The widget is ignored if used on a datetime fields, see the tests : `DatetimeField with date/datetime widget (with day change) does not care about widget` and `DatetimeField with date/datetime widget (without day change) does not care about widget.`

This commit is part of a bigger task, that aim to raise an error if a widget is used in an unsupported field type, in this case the widget date, will only support the date type fields.

task-id: 4224192

Original PR description

This commit fix the supportedTypes of widget `carrier_type_selection`.

task-id: 4224192

Original PR description

This commit will remove the total below section setting and
ignore_totals_below_section options.

This change is done because, it brings useless complexity to reports. If the
totals line are needed, the specific report will have to add the lines by itself

task: 4182639

Original PR description

Steps to reproduce:
 - have two companies with different main currencies
 - have currency rates != 1 for the selected main company
 - open the trial balance with both companies selected

 => The amounts displayed in Debit and Credit column from the first company
 are not converted to the main company currency.

 Reason of the issue:
 The general ledger custom code rewrite the options 'date_from' to the
 fiscal year date from, which results in a Null join with the
 account_currency_table

Forward-Port-Of: odoo/enterprise#72006

Original PR description

Following the changes made in the community side in odoo/odoo#183190, adapts the tests to check that the dropships are properly considered as dropships in inter-company transactions.

Forward-Port-Of: odoo/enterprise#72188
Forward-Port-Of: odoo/enterprise#71688

Original PR description

In Morocco, the result can be affected from accounts 1181 and 1189, depending whether it's a profit or loss. To that effect, an entry must be passed at the beginning of the fiscal year to empty 9999 (unaffacted earnings) account, and put the result of the previous year to one of those accounts.

When trying to do that, the same amounts were taken multiple times into account, leading to an unbalanced balance sheet. The problem was the income/expense lines from the current year musn't be considered by that line of the BS. Only affectation must also be considered from within the current fiscal year.

Forward-Port-Of: odoo/enterprise#72337
Forward-Port-Of: odoo/enterprise#72021

Original PR description

If we receive a valid pairing code, block the
'Pair' button, since if it is pressed again it
will show an error as the pairing code has already been used.

task-4207295

Forward-Port-Of: odoo/enterprise#72416

Original PR description

Before this commit, when a user doesn't have any hr right, he can't see employee's picture.

With this commit, this issue is fixed and the user can access to the public employee form when he clicks on this picture. And "mark as done" option in three dot menu is invisible if the goal is already done.

task-4240631

Forward-Port-Of: odoo/enterprise#72362
Forward-Port-Of: odoo/enterprise#71459

Original PR description

Before this change, if a regular user was granted access to the IoT app, they would get a traceback on trying to pair an IoT box as they cannot access `ir.config_parameter`. This PR adds the missing `sudo` calls to fix this traceback and allow the user to pair an IoT box.

task-4216519

Forward-Port-Of: odoo/enterprise#72278
Forward-Port-Of: odoo/enterprise#72199

Original PR description

The model 349 wasn't working as expected, here are the points that have been changed:

- Some keys were missing, in particular the keys R, D, and C.

- Changed some wording of the report, such as replacing 'refunds' with 'rectifications'.

- The biggest change was changing the way the lines are computed in the report. Before this commit, we used only the domain engine, but now we need to use a custom engine to handle the rectifications part.

- Fixed some other bugs, like negative amounts which are not supposed to appear as the report only deals with positive values, and also ensured the discounts on the move lines are computed correctly.

task-3992046

Forward-Port-Of: odoo/enterprise#72430
Forward-Port-Of: odoo/enterprise#65074

Original PR description

## Steps to reproduce:
1. Create a quality control point for the operation type Manufacturing
2. Create a manufacturing order and plan it
3. Go to the Shop floor
4. Register the production & do the quality checks
5. The Quality Checks button is still there; clicking again displays a traceback because the quality checks are already done.

## Before this commit:
Upon reloading the production, the new data is not propagated to `this.record`.

## After this commit:
Change `this.record` when props are updated so it always contains the correct reference to the record.

opw-4176393

Forward-Port-Of: odoo/enterprise#72425
Forward-Port-Of: odoo/enterprise#70800

Original PR description

This commits add the first test for the fiskaly module.

This tests mock all the call made to the api so that we can make sure the module is working correctly.

opw-4171641

Forward-Port-Of: odoo/enterprise#71811
Forward-Port-Of: odoo/enterprise#70369

Original PR description

Forward-Port-Of: odoo/enterprise#72400
Forward-Port-Of: odoo/enterprise#72307

Original PR description

Steps to reproduce the bug:
- Create two Storable product:
    - “P1” -> product category A
    - “P2” -> product category B

- Create a quality point:
    - picking type: receipt
    - product category: Cat A & Cat B
    - Measure: by quantity

- Create a second quality point:
    - picking type: receipt
    - product category: Cat A
    - Measure: by quantity

- Create a receipt of one unit of P1 and P2
- Confirm

Problem:
Four quality checks are created instead of three because we check if the quality point corresponds to the picking type and if the quality point has no product selected. However, we don't verify if a product category is also not set.

opw-4240859

Forward-Port-Of: odoo/enterprise#71709
Forward-Port-Of: odoo/enterprise#71453

Original PR description

If a language is set on the customer when doing the followup, the attached Partner Ledger was always generated in the language of the active user. Instead, if a language is set on the customer, we want to use it.

Forward-Port-Of: odoo/enterprise#71529

Original PR description

**Steps to reproduce:**
	- Create a working calendar 8:00 - 12:00 13:00 - 15:00
	- Set in employee and company, as you mentioned everywhere.
	- The create a shift template 11 :00 - 15:00 (3 hrs)
	- Now create a planning slot with this shift template.
	- Expected start date - End date 11:00 - 15:00
	- Actual start - end 11:00 - 14:00

**Current behavior before PR:**
The end time is not calculated correctly if we have working calendar because we just add the duration to the start time without taking into consideration that there might be a break hour in the middle of the duration.

**Desired behavior after PR is merged:**
We are now considering the employee resource calendar in our calculation for the time of the slot.

opw-3890629

Forward-Port-Of: odoo/enterprise#72224
Forward-Port-Of: odoo/enterprise#63002

Original PR description

Recently, this commit is merged: https://github.com/odoo/enterprise/pull/63002/commits/32776c6eb7ce1dafca2f8f4d0f825c19da641b71

the test case is failing in the weekends or non-working days, so I have used freeze_time to run it as if it were a working day.

Forward-Port-Of: odoo/enterprise#72429
Forward-Port-Of: odoo/enterprise#72343

Original PR description

Steps to reproduce:
-------------------
- Create or rename any journal entry to have an empty name (Number).
- Open GL and make sure that this entry is included in the report.
- Click XLSX export, will give error: "TypeError: float() argument must be a string or a real number, not 'NoneType'".

Cause
-----
Since #50004, dynamic column width calculation for xlsx was added without handling the case where a filed can be empty.
A typecast to float was done with exception for ValueError only.

Fix
---
Add condition to check if the field is non empty before casting.

Forward-Port-Of: odoo/enterprise#71295

Original PR description

Currently since TestFrontend has test methods and is imported/inherited, the same test is executed three times.

Fixing it by extracting setup to an utility class

Forward-Port-Of: odoo/enterprise#72269
Forward-Port-Of: odoo/enterprise#69552

Original PR description

Resolve an issue where the compute method `_compute_is_there_shared_cert` was
triggered before the record was saved, causing the domain to be incorrectly
constructed with `company.id`. Replacing `company.id` with `company._origin.id`
to ensure the correct domain is applied by accessing the original record
instance.

Forward-Port-Of: odoo/enterprise#72084

Original PR description

When we save the folder without a name, it shows 'False' because the field isn't 
set as 'required.' Making it mandatory will trigger a red alert on save, ensuring 
a valid name is entered.

Task-4247496

Forward-Port-Of: odoo/enterprise#71726

Original PR description

Steps to reproduce
===================
- Create a booking using any appointment type.
- Delete that booking from Gantt view.
- The confirmation dialog is missing when deleting the record.

This PR addresses the issue of the missing confirmation dialog while deleting calendar event records.

Task-4228681

Forward-Port-Of: odoo/enterprise#71627

Original PR description

Improve tooling defined in marketing automation, notably
  * add more verbose errors;
  * add parameters for trace check, notably to be less strict in case of duplicate-like traces;
  * improve tool methods generating activities;
  * assert some keys to be sure we effectively check what is intended;
  * add some docstrings while passing by;

Task-2667099: [mail] Improve default template values
Prepares Task-4224145: [marketing_automation] Improve test coverage

Forward-Port-Of: odoo/enterprise#72420

Original PR description

For usability; the previous message caused a bit of confusion, and was too technical to actually be understandable.

Original PR description

After [this refactoring] a regression occurred. Where previously the "XML" and "Copy to Documents" buttons were disabled when we didn't have the whole hierarchy of a company with its branches selected, it is not anymore.

This commit fixes that.

[task-4260501](https://www.odoo.com/odoo/all-tasks/4260501)

[this refactoring]: https://github.com/odoo/enterprise/commit/1ea5dc3227913826a205b164c19e4771babc3326

Original PR description

This commit changes the way we display placeholder options for the CharField when being selected by studio.

Previously, it was confusing to edit the dynamic_placeholder option, which needs another option to work properly, and which don't make much sense in most cases. Instead, we choose to support only the recently added placeholder_field option, and to name it Dynamic Placeholder in the sidebar.

task-3901821

Original PR description

The groups s codes for work entry types were wrong. this commit adds the right codes for the work entry types.

task-4221186

Original PR description

Steps to reproduce:
 - have two companies with different main currencies
 - have currency rates != 1 for the selected main company
 - open the trial balance with both companies selected

 => The amounts displayed in Debit and Credit column from the first company
 are not converted to the main company currency.

 Reason of the issue:
 The general ledger custom code rewrite the options 'date_from' to the
 fiscal year date from, which results in a Null join with the
 account_currency_table

Original PR description

Forward-Port-Of: odoo/enterprise#72400
Forward-Port-Of: odoo/enterprise#72307

Original PR description

Steps to reproduce the bug:
- Create two Storable product:
    - “P1” -> product category A
    - “P2” -> product category B

- Create a quality point:
    - picking type: receipt
    - product category: Cat A & Cat B
    - Measure: by quantity

- Create a second quality point:
    - picking type: receipt
    - product category: Cat A
    - Measure: by quantity

- Create a receipt of one unit of P1 and P2
- Confirm

Problem:
Four quality checks are created instead of three because we check if the quality point corresponds to the picking type and if the quality point has no product selected. However, we don't verify if a product category is also not set.

opw-4240859

Forward-Port-Of: odoo/enterprise#71709
Forward-Port-Of: odoo/enterprise#71453

Original PR description

…ifferent trees

Add a field at the end of the "left" subgroup and remove the "right" subgroup.

```xml

<form>

  <group>

    <group>
      <field name="display_name" />
      [ADD A FIELD]
    </group>
[ REMOVE THIS GROUP
    <group>
    </group>
]
  </group>

</form>
```

Before this commit, when "normalizing" the xpaths, the add field operation was aggregated with the remove operation because no unchanged node was found in between.
We were left with the inheriting view:
```xml

<xpath expr="[..]/group[2]" position="replace">
  <field name="added_field" />
</xpath>
```

After this commit, this flow works and the two operations are independent.

part of task-4207793

Forward-Port-Of: odoo/enterprise#72273
Forward-Port-Of: odoo/enterprise#71289

Original PR description

The model 349 wasn't working as expected, here are the points that have been changed:

- Some keys were missing, in particular the keys R, D, and C.

- Changed some wording of the report, such as replacing 'refunds' with 'rectifications'.

- The biggest change was changing the way the lines are computed in the report. Before this commit, we used only the domain engine, but now we need to use a custom engine to handle the rectifications part.

- Fixed some other bugs, like negative amounts which are not supposed to appear as the report only deals with positive values, and also ensured the discounts on the move lines are computed correctly.

task-3992046

Forward-Port-Of: odoo/enterprise#72389
Forward-Port-Of: odoo/enterprise#65074

Original PR description

Before this change, if a regular user was granted access to the IoT app, they would get a traceback on trying to pair an IoT box as they cannot access `ir.config_parameter`. This PR adds the missing `sudo` calls to fix this traceback and allow the user to pair an IoT box.

task-4216519

Forward-Port-Of: odoo/enterprise#72199

Original PR description

Before this commit, when a user doesn't have any hr right, he can't see employee's picture.

With this commit, this issue is fixed and the user can access to the public employee form when he clicks on this picture. And "mark as done" option in three dot menu is invisible if the goal is already done.

task-4240631

Forward-Port-Of: odoo/enterprise#72189
Forward-Port-Of: odoo/enterprise#71459

Original PR description

Steps to reproduce:
-------------------
- Create or rename any journal entry to have an empty name (Number).
- Open GL and make sure that this entry is included in the report.
- Click XLSX export, will give error: "TypeError: float() argument must be a string or a real number, not 'NoneType'".

Cause
-----
Since #50004, dynamic column width calculation for xlsx was added without handling the case where a filed can be empty.
A typecast to float was done with exception for ValueError only.

Fix
---
Add condition to check if the field is non empty before casting.

Forward-Port-Of: odoo/enterprise#71295

Original PR description

Currently since TestFrontend has test methods and is imported/inherited, the same test is executed three times.

Fixing it by extracting setup to an utility class

Forward-Port-Of: odoo/enterprise#72269
Forward-Port-Of: odoo/enterprise#69552

Original PR description

Steps to reproduce
===================
- Create a booking using any appointment type.
- Delete that booking from Gantt view.
- The confirmation dialog is missing when deleting the record.

This PR addresses the issue of the missing confirmation dialog while deleting calendar event records.

Task-4228681

Forward-Port-Of: odoo/enterprise#71627

Original PR description

Added base localization package with chart of accounts ,taxes and fiscal positions for Lebanon 🇱🇧 

Link to task: [#3927914](https://www.odoo.com/web#model=project.task&id=3927914)

Original PR description

CAF is based on the AVS Salary and not the GROSS

Original PR description

- 17.0

### Steps to reproduce:
- Install sale_timesheet_enterprise.
- Select Billing Rate Target and then Billing Rate Leaderboard in settings.
- Click on 'Set employee billing time targets'.
- Open Mitchell Admin form view and set the value of the Billing Time Target to 150 in the HR Setting tab.
- Open 'my timesheet'.
- Open the leaderboard, on the right-hand side.
- Notice that 'x/150' is displayed for Mitchell admin.
- Open Mitchell Admin employee form view.
- Set the value of the Billing Time Target to 100.
- Again open the leaderboard in the timesheet.

### Issue
'x/' is displayed without the new target value.

### Cause
Due to the wrong regular expression for the value.

### Solution
Correct the regular expression.


task-3970348

Original PR description

As Debian wants to remove pypdf2 and keep only pypdf (4.3) in
trixie, so we need to be compatible otherwise Odoo could not be released in the next Debian.

Original PR description

Harmonize 'phone' field, normalize email usage

Task-4154838

Original PR description

Steps to reproduce:
- Subscriptions app > New > Add 1 line with any recurring product twice
- Give both lines different discounts
- Confirm > Create Invoice > Confirm > Back to original subscription
- Upsell > Lines have the same discount

The lines should have the same discount disparity as they did on the original SO, this is even more important when the upsell is made in between periods as the product prices are also prorated, which makes editing the discount manually a lot trickier. Currently both lines will take the first parent that matches the original order line without taking the discount into consideration.

i.e a monthly recuring order upsold halfway through the month will already have a 50% discount (Because we only invoice half a period) which should be cumulative with the original line's discount.

opw-4081350

Forward-Port-Of: odoo/enterprise#72192

Original PR description

In the case of an AVS policy change, ac and acc rules do not verify that we are taking the previous amounts of the same policy, those rules are also from the previous version and can be simplified since all the computation is now done in the ACSALARY rule.

Original PR description

When the date in the modify wizard for assets is changed, the residual_value should be updated to give a better view to the user.

As this value is changed, the tests had to be changed accordingly.

The gain or loss account is now correctly adapted from the computed value (itself computed on the date) and the Asset Counterpart Account is hidden if there is no gain.

task-3981380

Forward-Port-Of: odoo/enterprise#70277

Original PR description

Before this fix, when setting up a new foreign VAT fiscal position, no corresponding draft closing move was created. Because of that, if nothing was made to generate it in the meantime, when the user posted the last of the other draft closing moves, the tax lock date was set, forbidding adding new invoices for the new foreign closing, even though it wasn't posted yet. Though corner cases are still possible, we alleviate that by automatically generating the draft move when the user creates a new foreign VAT fiscal position.

Original PR description

With a BE Company Setup
Go to Documents > Configuration > Settings
  - Enable Accounting (Centralize accounting files and documents)
  - Open Journals and synchronize the Customer Invoices journal with a workspace
 
Create an invoice
Click Send&Print
  - Check "BIS Billing 3.0"
  - Send the message, the invoice will now have 2 attachments: pdf and xml

Check the documents workspace

Issue: Only the pdf is present

This occurs because of the conditions needed to create the document.
When we send the message we create the attachment but the move does not
have attachment_ids set yet, so we fail to assign the first one.
In this phase we just need to link the xml as the pdf will be registered
when assigned as main attachment of the move

opw-4088910

Original PR description

Problem:
When changing a variant in the rental product page, the availability is not updated because the `/rental/product/availabilities` endpoint is not called. This results in situations where users can attempt to rent unavailable variants without being warned.

Steps to reproduce:
- Create a rental product with two variants.
- Try to rent the second variant when it is unavailable.
- The `/rental/product/availabilities` endpoint is not called, so availabilities are not updated, and no warning is displayed.

opw-4130172

Original PR description

If we receive a valid pairing code, block the
'Pair' button, since if it is pressed again it
will show an error as the pairing code has already been used.

task-4207295

Original PR description

Due to a quirk in the JS framework, when a device
form view is opened from the IoT box form view,
it opens in a dialog box where it's `js_class`
is not run. This causes updates to Display URL
and Keyboard layout not to sync to the IoT box.

This PR works around the issue by forcing the
full device form view to open, rather than the
dialog box.

task-4141053

Original PR description

Before this fix, after cancelling a CFDI within a global invoice, the "reset to draft" option was not visible, preventing the user from modifying the invoice.

Steps to reproduce:
1. Generate 2 invoices
2. Use the option to generate a global invoice (for any period)
3. Go to any of the individual invoices and cancel the CFDI
4. After the cancellation, the option to reset the invoice to draft is not available.

With this fix, the "reset to draft" option will be available after cancelling a CFDI in a global invoice, allowing users to reset the invoice for further modifications.

Original PR description

Direct update sanitized_acc_number is not allowed.