Saturday, October 26, 2024
7 changes · 18.0
Resolved issues and error corrections
Fixes an error that could occur when visitors sorted forum posts by activity. This keeps the forum browsing experience stable and prevents users from seeing a crash page during normal navigation.
Original PR description
Currently, a traceback is occurring when the user tries to sort a website forum posts. To reproduce this issue: 1) Install website_forum 2) Open `Forum` in the website and tries to sort based on activity Error:- ``` AttributeError: 'NoneType' object has no attribute 'groupby' ``` Here in the website_forum post, the query was passed as None, and because of the recent changes from the below-mentioned commit, a traceback occurs from the line[1]. https://github.com/odoo/odoo/blob/0bac60a7085c51ac8cb4f793b013dbea927d180c/addons/website_forum/controllers/website_forum.py#L126 Line[1]:- https://github.com/odoo/odoo/blob/0bac60a7085c51ac8cb4f793b013dbea927d180c/odoo/models.py#L5614-L5615 Commit:- https://github.com/odoo/odoo/pull/183925/commits/6b1df3fddedec486bc20010131ea8da566dade32 We can resolve this issue by passing an empty query instead of None. sentry-6008918989
Miscellaneous changes
Follow-up of [1] which was not enough to fully fix the issue. Indeed, there was a remaining call to `.carousel("pause")` in an editor option `start` that funnily enough actually unpaused the carousel. Indeed, it created the carousel bootstrap instance, paused... but meant to restart on first mouseleave. The `slider` public widget is in charge of pausing the carousel in edit mode. And it does so by preventing it to cycle for the whole edit mode duration. But because of that editor opti
Original PR description
Follow-up of [1] which was not enough to fully fix the issue.
Indeed, there was a remaining call to `.carousel("pause")` in an editor
option `start` that funnily enough actually unpaused the carousel.
Indeed, it created the carousel bootstrap instance, paused... but meant
to restart on first mouseleave.
The `slider` public widget is in charge of pausing the carousel in edit
mode. And it does so by preventing it to cycle for the whole edit mode
duration. But because of that editor option code, it happened too late.
[1]: https://github.com/odoo/odoo/commit/9eff9ae1904e0583f5dc60c6d925c52b48b208ec
Forward-Port-Of: odoo/odoo#185355Steps to reproduce: - On Safari, click on the searchbar from the header - Type anything that gives results (e.g.: "a") - Make a long press on a result. => The search results are closed without leading to the page. This is due to Safari not focusing links and buttons by design (!)[1]. The condition in `_onFocusOut` (no element in the searchbox is the active element) is thus true and the searchbox is rerendered, making the click unresponsive. [1]: https://bugs.webkit.org/show_bug.cgi?
Original PR description
Steps to reproduce: - On Safari, click on the searchbar from the header - Type anything that gives results (e.g.: "a") - Make a long press on a result. => The search results are closed without leading to the page. This is due to Safari not focusing links and buttons by design (!)[1]. The condition in `_onFocusOut` (no element in the searchbox is the active element) is thus true and the searchbox is rerendered, making the click unresponsive. [1]: https://bugs.webkit.org/show_bug.cgi?id=22261#c68 opw-4116832 Forward-Port-Of: odoo/odoo#184580
Steps to reproduce: - Have two Companies A and B - Create an Analytic Account (AA) for Company A - In B (A multiselected), create an invoice: company=Company B Set the AA analytic Distribution - Unselect company A and try to enter the invoice Issue: Access error Solution: After discussion with PO tsb, children companies need to have access to analytic account (and analytic related stuff) from parent opw-3764627 Forward-Port-Of: odoo/odoo#179819 Forward-Port-Of: odoo/odoo#179282
Original PR description
Steps to reproduce: - Have two Companies A and B - Create an Analytic Account (AA) for Company A - In B (A multiselected), create an invoice: company=Company B Set the AA analytic Distribution - Unselect company A and try to enter the invoice Issue: Access error Solution: After discussion with PO tsb, children companies need to have access to analytic account (and analytic related stuff) from parent opw-3764627 Forward-Port-Of: odoo/odoo#179819 Forward-Port-Of: odoo/odoo#179282
Once the ewaybill is generated, cancelled and resetted to pending the name is not resetted After this commit: we reset ewaybill name once it's been reset to pending task-4285220 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#185066
Original PR description
Once the ewaybill is generated, cancelled and resetted to pending the name is not resetted After this commit: we reset ewaybill name once it's been reset to pending task-4285220 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#185066
Some cities that process service invoices [1] have stricter hsCode validations than others and error on the hsCode we send. Avalara requires periods to be removed from the hsCode field for goods transactions. This was already the case. For services they inform us that the periods should be kept but leading zeroes should be stripped [2]. [1] e.g. Belo Horizonte [2] There's no documentation on this. This was specified by Avalara support in an internal support ticket. opw-4009684 Forward
Original PR description
Some cities that process service invoices [1] have stricter hsCode validations than others and error on the hsCode we send. Avalara requires periods to be removed from the hsCode field for goods transactions. This was already the case. For services they inform us that the periods should be kept but leading zeroes should be stripped [2]. [1] e.g. Belo Horizonte [2] There's no documentation on this. This was specified by Avalara support in an internal support ticket. opw-4009684 Forward-Port-Of: odoo/enterprise#72835 Forward-Port-Of: odoo/enterprise#72641
- Add support for batch payment via Zengin and bank statement import - Currently only support txt files task-3304270 Forward-Port-Of: odoo/enterprise#72826 Forward-Port-Of: odoo/enterprise#71290
Original PR description
- Add support for batch payment via Zengin and bank statement import - Currently only support txt files task-3304270 Forward-Port-Of: odoo/enterprise#72826 Forward-Port-Of: odoo/enterprise#71290