Saturday, October 26, 2024
18 changes
2 changes
Miscellaneous changes
In some theme customizations, images were replaced by new ones without specifying the usual image classes `img img-fluid mx-auto`. While two of them could be ignored, this is not the case of `img-fluid`, which limits the maximum width of an image to 100%. Without it, grid images in mobile view are overflowing, because the rule forcing their width to 100% has been moved in commit [1], to be applied on the desktop view only. This commit fixes this issue by adding a rule for grid images, limitin
Original PR description
In some theme customizations, images were replaced by new ones without specifying the usual image classes `img img-fluid mx-auto`. While two of them could be ignored, this is not the case of `img-fluid`, which limits the maximum width of an image to 100%. Without it, grid images in mobile view are overflowing, because the rule forcing their width to 100% has been moved in commit [1], to be applied on the desktop view only. This commit fixes this issue by adding a rule for grid images, limiting their width to 100%. The problematic themes will also be fixed in the associated design PR. [1]: https://github.com/odoo/odoo/commit/710d000f1872fd99b41d52ec3d6923756bba7cba Forward-Port-Of: odoo/odoo#183013
Steps to reproduce: - On Safari, click on the searchbar from the header - Type anything that gives results (e.g.: "a") - Make a long press on a result. => The search results are closed without leading to the page. This is due to Safari not focusing links and buttons by design (!)[1]. The condition in `_onFocusOut` (no element in the searchbox is the active element) is thus true and the searchbox is rerendered, making the click unresponsive. [1]: https://bugs.webkit.org/show_bug.cgi?
Original PR description
Steps to reproduce: - On Safari, click on the searchbar from the header - Type anything that gives results (e.g.: "a") - Make a long press on a result. => The search results are closed without leading to the page. This is due to Safari not focusing links and buttons by design (!)[1]. The condition in `_onFocusOut` (no element in the searchbox is the active element) is thus true and the searchbox is rerendered, making the click unresponsive. [1]: https://bugs.webkit.org/show_bug.cgi?id=22261#c68 opw-4116832 Forward-Port-Of: odoo/odoo#184580
10 changes
Resolved issues and error corrections
Clicking into template-based text areas no longer automatically highlights the default text. This makes editing marketing, helpdesk, and website content feel more predictable and helps prevent accidental replacement of template text.
Original PR description
*: marketing_automation, website_helpdesk This commit removes the default behavior of automatically selecting text when clicking on an element that contains pre-defined text originating from templates. Previously, when interacting with such elements, the default template text would be highlighted upon click, which could lead to unintended user experiences, especially in scenarios where the user does not expect or desire the selection of content by default. By eliminating this automatic selection, we ensure a more intuitive and streamlined interaction, giving users greater control over their text editing process when working with elements populated from templates. task-4147162
6 changes
Miscellaneous changes
Follow-up of [1] which was not enough to fully fix the issue. Indeed, there was a remaining call to `.carousel("pause")` in an editor option `start` that funnily enough actually unpaused the carousel. Indeed, it created the carousel bootstrap instance, paused... but meant to restart on first mouseleave. The `slider` public widget is in charge of pausing the carousel in edit mode. And it does so by preventing it to cycle for the whole edit mode duration. But because of that editor opti
Original PR description
Follow-up of [1] which was not enough to fully fix the issue.
Indeed, there was a remaining call to `.carousel("pause")` in an editor
option `start` that funnily enough actually unpaused the carousel.
Indeed, it created the carousel bootstrap instance, paused... but meant
to restart on first mouseleave.
The `slider` public widget is in charge of pausing the carousel in edit
mode. And it does so by preventing it to cycle for the whole edit mode
duration. But because of that editor option code, it happened too late.
[1]: https://github.com/odoo/odoo/commit/9eff9ae1904e0583f5dc60c6d925c52b48b208ec
Forward-Port-Of: odoo/odoo#185355When users duplicate a spreadsheet list or pivot, the new item name now clearly includes “(copy)”. This helps users distinguish originals from duplicates and reduces confusion when managing spreadsheet data.
Original PR description
## Description This commit appends "(copy)" to the name when a list or pivot is duplicated. Task: 4269121
Miscellaneous changes
Some cities that process service invoices [1] have stricter hsCode validations than others and error on the hsCode we send. Avalara requires periods to be removed from the hsCode field for goods transactions. This was already the case. For services they inform us that the periods should be kept but leading zeroes should be stripped [2]. [1] e.g. Belo Horizonte [2] There's no documentation on this. This was specified by Avalara support in an internal support ticket. opw-4009684 Forward
Original PR description
Some cities that process service invoices [1] have stricter hsCode validations than others and error on the hsCode we send. Avalara requires periods to be removed from the hsCode field for goods transactions. This was already the case. For services they inform us that the periods should be kept but leading zeroes should be stripped [2]. [1] e.g. Belo Horizonte [2] There's no documentation on this. This was specified by Avalara support in an internal support ticket. opw-4009684 Forward-Port-Of: odoo/enterprise#72835 Forward-Port-Of: odoo/enterprise#72641
- Add support for batch payment via Zengin and bank statement import - Currently only support txt files task-3304270 Forward-Port-Of: odoo/enterprise#72855 Forward-Port-Of: odoo/enterprise#71290
Original PR description
- Add support for batch payment via Zengin and bank statement import - Currently only support txt files task-3304270 Forward-Port-Of: odoo/enterprise#72855 Forward-Port-Of: odoo/enterprise#71290
Before this commit, when the user alters the unit_amount field of an analytic account line which is not a timesheet and the amount has more than 6 digits then the user will get a user error saying he cannot encode a number with more than 6 digits for the unit amount field. This commit makes sure the check made on the unit amount is only made when the analytic line altered is a timesheet. Forward-Port-Of: odoo/enterprise#72755
Original PR description
Before this commit, when the user alters the unit_amount field of an analytic account line which is not a timesheet and the amount has more than 6 digits then the user will get a user error saying he cannot encode a number with more than 6 digits for the unit amount field. This commit makes sure the check made on the unit amount is only made when the analytic line altered is a timesheet. Forward-Port-Of: odoo/enterprise#72755
The error occurs when we validate the quality worksheet template. Steps to reproduce: --- - Install the ``quality_mrp_workorder_worksheet`` module - Quality > Configuration > Quality Worksheet Templates - Click on ``Design Template`` - Click on ``Close`` - Click on ``Validate`` Traceback: --- ``ValueError: Expected singleton : quality.check()`` This error occurs at [1], where we are receiving ``self`` as empty. Previous behavior: --- When we try to design a template in the
Original PR description
The error occurs when we validate the quality worksheet template. Steps to reproduce: --- - Install the ``quality_mrp_workorder_worksheet`` module - Quality > Configuration > Quality Worksheet…
The error occurs when we validate the quality worksheet template. Steps to reproduce: --- - Install the ``quality_mrp_workorder_worksheet`` module - Quality > Configuration > Quality Worksheet Templates - Click on ``Design Template`` - Click on ``Close`` - Click on ``Validate`` Traceback: --- ``ValueError: Expected singleton : quality.check()`` This error occurs at [1], where we are receiving ``self`` as empty. Previous behavior: --- When we try to design a template in the ``Quality Worksheet Templates`` the studio opens as expected. However, if we close it without making any changes, we are redirected to the form view. In this view, we encounter strange behavior and are unable to perform any actions. After behavior: --- Now, when we click on ``Design Template`` from the list view and then close it, we are redirected to the form view of the ``Quality Worksheet Templates``. [1]- https://github.com/odoo/enterprise/blob/7eb1131b413afc2549382d2524ec83445803b682/quality_mrp_workorder_worksheet/models/quality.py#L12 sentry-5695518176 Forward-Port-Of: odoo/enterprise#68341
steps: -> populate the portal user's appointments with enough appointments to have multiple pages in the portal -> go on the portal, filter by "past" -> go to page 2 --> the filter by "past" is removed from the url opw-4236596 Forward-Port-Of: odoo/enterprise#71965
Original PR description
steps: -> populate the portal user's appointments with enough appointments to have multiple pages in the portal -> go on the portal, filter by "past" -> go to page 2 --> the filter by "past" is removed from the url opw-4236596 Forward-Port-Of: odoo/enterprise#71965
The query count in single module build is higher than the one with all modules installed. - test_mail_enterprise   - test_mail_enterprise + documents_project    - test_mail_enterprise + documents_project   In summary, a one2many fields document_ids on document_projects triggers an [orm optimisation](https://github.com/odoo/odoo/pull/111651/files) leading to 10 less queries. In 16.0 the query count adapted in an all-enterprise build fails in single module In 17.0 a regression of performance was missed because a margin is added on a bunch of query count that didn't break in the all-enterprise build This pr proposes to add a field with the corresponding optimization in the test module in stable, to have reliable query counter. This field will be moved to the document module in master. RunbotError-65777 Forward-Port-Of: odoo/enterprise#72700 Forward-Port-Of: odoo/enterprise#72598
The field fetching status is used to check if we need to call the synchronization. In case there is an error during the synchronization, the user would be block with his connection. The solution is to reset the fetching status when fetching the transaction or use the new reset button on the list view of the online accounts. task:4262788 Forward-Port-Of: odoo/enterprise#72745 Forward-Port-Of: odoo/enterprise#72492
Original PR description
The field fetching status is used to check if we need to call the synchronization. In case there is an error during the synchronization, the user would be block with his connection. The solution is to reset the fetching status when fetching the transaction or use the new reset button on the list view of the online accounts. task:4262788 Forward-Port-Of: odoo/enterprise#72745 Forward-Port-Of: odoo/enterprise#72492
**Version:** - 17.0 **Current Behaviour:** - Whenever tags were added to the document, the saved notification would appear, which looked odd. - Adding multiple tags caused the field size to increase, which was inappropriate. **Updated Behaviour:** - The saved notification will only appear when exiting the document. - A CSS class has been added to maintain a fixed size when adding multiple tags. task-4164151 Forward-Port-Of: odoo/enterprise#72664 Forward-Port-Of: odoo/enterpris
Original PR description
**Version:** - 17.0 **Current Behaviour:** - Whenever tags were added to the document, the saved notification would appear, which looked odd. - Adding multiple tags caused the field size to increase, which was inappropriate. **Updated Behaviour:** - The saved notification will only appear when exiting the document. - A CSS class has been added to maintain a fixed size when adding multiple tags. task-4164151 Forward-Port-Of: odoo/enterprise#72664 Forward-Port-Of: odoo/enterprise#70195
Steps to reproduce: - On Safari, click on the searchbar from the header - Type anything that gives results (e.g.: "a") - Make a long press on a result. => The search results are closed without leading to the page. This is due to Safari not focusing links and buttons by design (!)[1]. The condition in `_onFocusOut` (no element in the searchbox is the active element) is thus true and the searchbox is rerendered, making the click unresponsive. [1]: https://bugs.webkit.org/show_bug.cgi?
Original PR description
Steps to reproduce: - On Safari, click on the searchbar from the header - Type anything that gives results (e.g.: "a") - Make a long press on a result. => The search results are closed without leading to the page. This is due to Safari not focusing links and buttons by design (!)[1]. The condition in `_onFocusOut` (no element in the searchbox is the active element) is thus true and the searchbox is rerendered, making the click unresponsive. [1]: https://bugs.webkit.org/show_bug.cgi?id=22261#c68 opw-4116832 Forward-Port-Of: odoo/odoo#184580
Steps to reproduce: - Have two Companies A and B - Create an Analytic Account (AA) for Company A - In B (A multiselected), create an invoice: company=Company B Set the AA analytic Distribution - Unselect company A and try to enter the invoice Issue: Access error Solution: After discussion with PO tsb, children companies need to have access to analytic account (and analytic related stuff) from parent opw-3764627 Forward-Port-Of: odoo/odoo#179819 Forward-Port-Of: odoo/odoo#179282
Original PR description
Steps to reproduce: - Have two Companies A and B - Create an Analytic Account (AA) for Company A - In B (A multiselected), create an invoice: company=Company B Set the AA analytic Distribution - Unselect company A and try to enter the invoice Issue: Access error Solution: After discussion with PO tsb, children companies need to have access to analytic account (and analytic related stuff) from parent opw-3764627 Forward-Port-Of: odoo/odoo#179819 Forward-Port-Of: odoo/odoo#179282
Once the ewaybill is generated, cancelled and resetted to pending the name is not resetted After this commit: we reset ewaybill name once it's been reset to pending task-4285220 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#185066
Original PR description
Once the ewaybill is generated, cancelled and resetted to pending the name is not resetted After this commit: we reset ewaybill name once it's been reset to pending task-4285220 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#185066
Some cities that process service invoices [1] have stricter hsCode validations than others and error on the hsCode we send. Avalara requires periods to be removed from the hsCode field for goods transactions. This was already the case. For services they inform us that the periods should be kept but leading zeroes should be stripped [2]. [1] e.g. Belo Horizonte [2] There's no documentation on this. This was specified by Avalara support in an internal support ticket. opw-4009684 Forward
Original PR description
Some cities that process service invoices [1] have stricter hsCode validations than others and error on the hsCode we send. Avalara requires periods to be removed from the hsCode field for goods transactions. This was already the case. For services they inform us that the periods should be kept but leading zeroes should be stripped [2]. [1] e.g. Belo Horizonte [2] There's no documentation on this. This was specified by Avalara support in an internal support ticket. opw-4009684 Forward-Port-Of: odoo/enterprise#72835 Forward-Port-Of: odoo/enterprise#72641
- Add support for batch payment via Zengin and bank statement import - Currently only support txt files task-3304270 Forward-Port-Of: odoo/enterprise#72826 Forward-Port-Of: odoo/enterprise#71290
Original PR description
- Add support for batch payment via Zengin and bank statement import - Currently only support txt files task-3304270 Forward-Port-Of: odoo/enterprise#72826 Forward-Port-Of: odoo/enterprise#71290