Sunday, October 27, 2024
3 changes · 18.0
Miscellaneous changes
…line Steps to reproduce: - Create two taxes T1 and T2 of 17% with two tax grids lines (+) and (-) - Configure a payment term of 2% discount - Create a payment of `-762.20` for a partner with a reference 'ref123' - Create and confirm a bill for the same partner, with a ref 'ref123', with the payment term and two lines; L1{'amount': 739.95 , 'tax': T1} L2{'amount': 37.8, 'tax':T2} - In Dashboard > Bank > select the transaction Issue: The last line tax will be 0.14 (difference of one 1
Original PR description
…line
Steps to reproduce:
- Create two taxes T1 and T2 of 17% with two tax grids lines (+) and (-)
- Configure a payment term of 2% discount
- Create a payment of `-762.20` for a partner with a reference 'ref123'
- Create and confirm a bill for the same partner, with a ref 'ref123', with the payment term and two lines; L1{'amount': 739.95 , 'tax': T1} L2{'amount': 37.8, 'tax':T2}
- In Dashboard > Bank > select the transaction
Issue:
The last line tax will be 0.14 (difference of one 1)
Cause:
The rounding issues sum up and we arbitrarily assign it to the last tax line (which can result in an unbalance).
Solution:
Instead, we assign this difference to the "biggest" base line (as the change will proportionnaly be smaller). While doing so, we keep consistencies between the tax lines.
opw-3966041
Forward-Port-Of: odoo/odoo#182386When having a tax with a specific tax as source account in the tax mapping of a fiscal position. The mapping does not apply if the product has a different tax from the tax of the account and no income/expense account set. This is because we extend `_get_product_accounts` in `datev` and replace the default income/expense account by an account that have the product tax. With this fix, we replace defualt income/expense accounts only if we find an account. Steps: - Have a FP with an account mapp
Original PR description
When having a tax with a specific tax as source account in the tax mapping of a fiscal position. The mapping does not apply if the product has a different tax from the tax of the account and no income/expense account set. This is because we extend `_get_product_accounts` in `datev` and replace the default income/expense account by an account that have the product tax. With this fix, we replace defualt income/expense accounts only if we find an account. Steps: - Have a FP with an account mapping: 8400 -> 2315 - Have a product P with a different tax from the one set on 8400 account, and that is not set on any other account - Create an invoice, set the FP, select the product P -> Account on the aml is 8400 instead of 2315 opw-4075846 Forward-Port-Of: odoo/odoo#185322 Forward-Port-Of: odoo/odoo#185232
In countries using extensively cash roundings, invoices having a early payment discount can usually be paid within a cash rounding tolerance. e.g. with a cash rounding of 0.05, and an early payment discount of 5%, for a total amount of 868.25, a discount amount of 824.84 will be stored. If a customer pays slightly more (eg 824.85), the early payment will not be recognized in the reconciliation widget, resulting at best in a partial payment that will require extra work for the accountant to
Original PR description
In countries using extensively cash roundings, invoices having a early payment discount can usually be paid within a cash rounding tolerance. e.g. with a cash rounding of 0.05, and an early payment discount of 5%, for a total amount of 868.25, a discount amount of 824.84 will be stored. If a customer pays slightly more (eg 824.85), the early payment will not be recognized in the reconciliation widget, resulting at best in a partial payment that will require extra work for the accountant to write off properly for early payment discount. By allowing to customize the comparison between open amount and total discount, it allows to implement any kind of tolerance in custom modules without breaking anything in the actual reconciliation mechanism. OPW-3985470 Forward-Port-Of: odoo/enterprise#72367 Forward-Port-Of: odoo/enterprise#68523