Daily updates from Odoo
Tuesday, October 29, 2024
2 changes
1 change
Code cleanup and technical improvements
This update tidies the internal structure of several files by reordering imports and removing outdated header annotations. It does not change business behavior, but helps keep the codebase easier to maintain and align with current Odoo standards.
Original PR description
- Reordering and cleaning imports; - Removing encoding declaration; - Removing javascript module annotations (optional since commit Odoo/odoo@5f2c505836002ac7851c29c28d612f721d467bc4); Community PR: - https://github.com/odoo/odoo/pull/185347
1 change
Code cleanup and technical improvements
This update makes Odoo's automated guided tours better at finding usable screen elements by ignoring disabled options during the search. This should reduce flaky tour failures and provide clearer error messages when a tour step cannot proceed.
Original PR description
In this commit, we improve the algorithm for finding the trigger. In fact, in macro.js, when each time the findTrigger method returns "false", then we wait for the next mutation to run findTrigger again. So in fact, it is not correct to check if the element found for the tour step is disabled AFTER having found it. We must find an element that meets specific criteria, namely that it is not disabled. We take advantage of this commit to improve the error messages. We take advantage of this commit to move the pointer in tour_automatic and no longer have to pass it in tour_step_automatic. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr