Wednesday, October 30, 2024
6 changes · 17.0
Resolved issues and error corrections
This update resolves an issue where the Helpdesk module was incorrectly creating an empty partner record when attempting to 'Plan Intervention' on a ticket without a defined contact. The fix prevents the system from generating a partner when required information is missing, ensuring data integrity and preventing unnecessary record creation.
Original PR description
Steps: Create a ticket with no partner. Click on 'Plan Intervention'. The modal opens. Issue: See that a partner "@" has been created and set. Cause: Clicking on the button calls `action_generate_fsm_task`, which calls `_find_or_create_partner`, but the args, `self.partner_name` and `self.partner_email`, are empty. Solution: Not try to create a partner when the fields both empty. task-4265584
This update fixes an issue where the SLA success rate was incorrectly calculated, considering all historical tickets instead of just those closed in the last 7 days. This change aligns the reporting with how the SLA is displayed in Odoo, providing a more accurate reflection of performance. The fix ensures that SLA metrics are reliable for tracking team effectiveness.
Original PR description
The SLA success rate was previously being computed using the entire history of closed tickets as the domain. This is contrary to the expected behavior, given the helper text on Odoo and the list view of tickets that opens up if you click the percentage. This commit changes the domain to only consider tickets that were closed in the last 7 days. To reproduce on Runbot, follow the steps laid out here, as the process involves forcing tickets to fail and be older than 7 days closed: https://www.odoo.com/odoo/49/tasks/4206255 opw-4206255
This update resolves an issue where the preparation display would generate an error if a product's category wasn't found. The change ensures that the display gracefully handles missing categories, preventing errors and improving the user experience. This backport addresses a previous bug.
Original PR description
Before this commit, if one of the product's categories was not included in the preparation display, it would lead to an error. Backport of https://github.com/odoo/enterprise/pull/66479 opw-4292494
This update fixes a calculation error in the Deferred Expense Report. When the report's end date is before its start date (e.g., looking at a previous month), the report was incorrectly displaying negative amounts. This change ensures the report accurately shows a zero amount in these scenarios, preventing incorrect financial reporting.
Original PR description
Version: 17.0+ Issue: In the Deferred Expense Report, there is a missing check for if the `period_end` is before the `period_start` for when the deferred method is 'day'. If the `period_end` is in the same month as selected month of the report, the later column will compute the amount to be negative of the `amount_per_day` times the difference of days. For example, if the end date is 2024-11-04 and we look at the month of November, the later column will display the negative amount of 26 days. In this example the amount is expected to be 0. Purpose of this PR: To add an additional condition, if the `period_end` is before the `period_start` then the amount should be 0. opw-4231549
This update fixes an issue where return labels were incorrectly using the customer's information as the shipper. Now, the shipper field accurately reflects the original sender (ship-to) ensuring correct billing for returned shipments. This improves the accuracy of our return processes.
Original PR description
**Current behavior:** Return labels are being generated with the `shipper` field set to the partner defined on the delivery picking (i.e., customer). **Expected behavior:** `shipper` should match the `ship_to` field (the original sender) as this field informs who gets billed for the return shipment. **Steps to reproduce:** Generate a return label with `delivery_ups_rest`. **Cause of the issue:** The return label is generated with `shipper=picking.partner_id`. **Fix:** Set it to `shipper=picking.picking_type_id.warehouse_id.partner_id` (which matches the `ship_to` argument). opw-4147118 Forward-Port-Of: odoo/enterprise#72482
Miscellaneous changes
This pull request updates the French translations for the l10n_fr_fec_import and l10n_fr_reports modules. These updates ensure that the Odoo Enterprise software is correctly localized for French-speaking users, improving the user experience and accuracy of reports and data import functionalities.
Original PR description
*l10n_fr_fec_import,l10n_fr_reports Related to https://github.com/odoo/odoo/pull/185817 Forward-Port-Of: odoo/enterprise#73048