Odoo Changelog — 2024-11-07

[FW][FIX] sale_{project,timesheet}: unharcode domain methods of fields

Core18.0sale_projectsale_timesheet

Since domain methods of fields are set using the actual class method instead of a lambda, it is not possible to inherit those methods when inheriting the model. This issue is fixed by using a lambda function to call the domain method. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#186073 Forward-Port-Of: odoo/odoo#185419

Original PR description

Since domain methods of fields are set using the actual class method instead of a lambda, it is not possible to inherit those methods when inheriting the model.

This issue is fixed by using a lambda function to call the domain method.

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#186073
Forward-Port-Of: odoo/odoo#185419

[FW][FIX] mail: Make popout feature work in chatter topbar

PR #186368

Core18.0mail

Before this commit, the chatter popout button was not working. This comes from recent changes to popout service that were affected to popout from attachment but not from chatter [1]. task-4275364 [1]: https://github.com/odoo/odoo/pull/174878 Forward-Port-Of: odoo/odoo#184742

Original PR description

Before this commit, the chatter popout button was not working.
This comes from recent changes to popout service that were affected to popout from attachment but not from chatter [1].

task-4275364

[1]: https://github.com/odoo/odoo/pull/174878

Forward-Port-Of: odoo/odoo#184742

[FW] Read-only controllers

PR #186608

Core18.0hr_attendancemailportalweb

First pass on the most used controllers which can be flagged as read-only. Forward-Port-Of: odoo/odoo#186319

Original PR description

First pass on the most used controllers which can be flagged as read-only.

Forward-Port-Of: odoo/odoo#186319

[FW][FIX] mail: escape on chatwindow thread rename

PR #186616

Core18.0mail

Before this PR, pressing `Escape` while renaming a thread in the chat window closed the entire chat window instead of simply exiting the rename mode. This PR ensures that pressing `Escape` only exits the rename action, keeping the chat window open. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#186538 Forward-Port-Of: odoo/odoo#185833

Original PR description

Before this PR, pressing `Escape` while renaming a thread in the chat window closed the entire chat window instead of simply exiting the rename mode.
This PR ensures that pressing `Escape` only exits the rename action, keeping the chat window open.

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#186538
Forward-Port-Of: odoo/odoo#185833

[FW][FIX] sale_mrp: Incorrect move kit qty after change on SOL

PR #186567

Core18.0sale_mrp

We can have a user that has enough rights to generate sales orders, but not enough right to check a BoM. When creating a new sale order for a kit, everything works fine. Before this commit, if we updated the quantity on the sale order line, the quantity on the moves would become incorrect. After this commit, the BoM is always found in order to correctly recompute the quantity on the moves. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forwar

Original PR description

We can have a user that has enough rights to generate sales orders, but not enough right to check a BoM.
When creating a new sale order for a kit, everything works fine.

Before this commit, if we updated the quantity on the sale order line, the quantity on the moves would become incorrect.

After this commit, the BoM is always found in order to correctly recompute the quantity on the moves.

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#186446
Forward-Port-Of: odoo/odoo#180442

[FW][IMP] test_mail_sms: cleanup phone/mobile search tests

PR #186577

Core18.0test_mail_sms

Use loops with clear input/expected structure to ease changes and debugging. Add few tests while passing by. Task-3943087 Forward-Port-Of: odoo/odoo#186468

Original PR description

Use loops with clear input/expected structure to ease changes and debugging. Add few tests while passing by.

Task-3943087

Forward-Port-Of: odoo/odoo#186468

[FW][FIX] account: ensure registry is loaded

PR #186600

Core18.0account

During a major upgrade the registry my be `loaded` but not `ready`. https://github.com/odoo/odoo/blob/9918e8f3d627f3c52238d6b04bcd15c05d34e40c/odoo/modules/registry.py#L159-L160 This causes unnecessary warnings during upgrades (blocking the CI). --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#186501 Forward-Port-Of: odoo/odoo#186467

Original PR description

During a major upgrade the registry my be `loaded` but not `ready`. https://github.com/odoo/odoo/blob/9918e8f3d627f3c52238d6b04bcd15c05d34e40c/odoo/modules/registry.py#L159-L160

This causes unnecessary warnings during upgrades (blocking the CI).

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#186501
Forward-Port-Of: odoo/odoo#186467

[FW][FIX] base: improve performance on res.device model

PR #186582

Core18.0

Issue: ------- The `res.device.log` model contains a huge number of records and this causes a performance problem for users belonging to the `base.group_system` group. The `res.device` table is a non-materialized view defined with a `DISTINCT ON` clause that uses the `user_id`, `session_identifier`, `platform`, `browser` columns. When we want to retrieve the `res.device` records for a user, two queries are performed. The first will retrieve the `res.device` ids for the user. ```sql

Original PR description

Issue: ------- The `res.device.log` model contains a huge number of records and this causes a performance problem for users belonging to the `base.group_system` group. The `res.device` table is a…

Issue:
-------

The `res.device.log` model contains a huge number of records and this causes a performance problem
for users belonging to the `base.group_system` group.

The `res.device` table is a non-materialized view defined with a `DISTINCT ON` clause
that uses the `user_id`, `session_identifier`, `platform`, `browser` columns.

When we want to retrieve the `res.device` records for a user, two queries are performed.
The first will retrieve the `res.device` ids for the user.
```sql
SELECT d.id FROM res_device d WHERE d.user_id=<user_id>
```
The second will retrieve the information for the `res.device` found in the first query.
```sql
SELECT d.* FROM res_device WHERE d.id IN (<device_ids>)
```

The second query will be very slow for an administrator, because Postgresql cannot use
the index on the primary key (`id`). Only the fields used in the `DISTINCT ON` clause
can be used as an index.
As a result, Postgresql will have to scan the entire `res_device_log` table, which is very large.

For a user who does not belong to the `base.group_system` group, an `ir.rule` is applied
so that they can only see their own `res_device`. For them, the second query is:
```sql
SELECT d.* FROM res_device WHERE d.id IN (<device_ids>) AND d.user_id = <user_id>
```
Postgresql can use the index on `user_id` to filter the table very quickly.
Then it is very fast to find the devices corresponding to the ids in the reduced table.

Solution:
----------

Unfortunately, it doesn't make sense to add the `id` column to the `DISTINCT ON` clause.
One solution could be to keep the `ir.rule` for people in the `base.group_system` group,
but we want administrators to have access to the `res.device` records of all users.
This solution was therefore rejected.

The solution adopted is to modify the non-materialized view so that Postgresql can use
the index on the primary key.

The goal of the view is to deduplicate records from the `res.device.log` model.
If for a given record, we find another record which has the same `user_id`, `session_identifier`,
`platform`, `browser` with a more recent `last_activity`, then we don't keep it.
Add a comparison between the `id` if the `last_activity` values are the same.

In addition, we need to take into account the case where we are unable to determine
the `platform` and the `browser` with the user agent.
This leads to `NULL` values, which must be handled with `IS DISTINCT FROM`.

To improve performance, we can also add a composite index with `user_id`, `session_identifier`,
`platform` and `browser` on `res.device.log`.

Appendices:
------------

Non administrator:
```
EXPLAIN ANALYZE SELECT * FROM res_device WHERE id=1 AND user_id=2;
 Subquery Scan on res_device  (cost=4.46..4.48 rows=1 width=126) (actual time=0.114..0.125 rows=0 loops=1)
   Filter: (res_device.id = 1)
   Rows Removed by Filter: 2
   ->  Unique  (cost=4.46..4.47 rows=1 width=126) (actual time=0.089..0.113 rows=2 loops=1)
         ->  Sort  (cost=4.46..4.46 rows=1 width=126) (actual time=0.086..0.095 rows=3 loops=1)
               Sort Key: d.session_identifier, d.platform, d.browser, d.last_activity DESC, d.id DESC
               Sort Method: quicksort  Memory: 25kB
               ->  Index Scan using res_device_log__user_id_index on res_device_log d  (cost=0.43..4.45 rows=1 width=126) (actual time=0.049..0.064 rows=3 loops=1)
                     Index Cond: (user_id = 2)
                     Filter: (NOT revoked)
 Planning Time: 0.224 ms
 Execution Time: 0.171 ms
```

Administrator:
```
EXPLAIN ANALYZE SELECT * FROM res_device WHERE id=1;
 Subquery Scan on res_device  (cost=475345.64..1031211.97 rows=20000 width=126) (actual time=32385.982..32425.079 rows=0 loops=1)
   Filter: (res_device.id = 1)
   Rows Removed by Filter: 3999995
   ->  Unique  (cost=475345.64..981211.93 rows=4000003 width=126) (actual time=5740.682..27526.236 rows=3999995 loops=1)
         ->  Gather Merge  (cost=475345.64..941211.90 rows=4000003 width=126) (actual time=5740.679..17382.463 rows=4000003 loops=1)
               Workers Planned: 2
               Workers Launched: 2
               ->  Sort  (cost=474345.61..478512.28 rows=1666668 width=126) (actual time=5723.180..8743.966 rows=1333334 loops=3)
                     Sort Key: d.user_id, d.session_identifier, d.platform, d.browser, d.last_activity DESC, d.id DESC
                     Sort Method: external merge  Disk: 159344kB
                     Worker 0:  Sort Method: external merge  Disk: 158864kB
                     Worker 1:  Sort Method: external merge  Disk: 159360kB
                     ->  Parallel Seq Scan on res_device_log d  (cost=0.00..85632.68 rows=1666668 width=126) (actual time=74.375..1997.856 rows=1333334 loops=3)
                           Filter: (NOT revoked)
 Planning Time: 0.215 ms
 JIT:
   Functions: 9
   Options: Inlining true, Optimization true, Expressions true, Deforming true
   Timing: Generation 1.220 ms, Inlining 84.317 ms, Optimization 86.161 ms, Emission 52.570 ms, Total 224.268 ms
 Execution Time: 32443.730 ms
```

Administrator with corrected view:
```
EXPLAIN ANALYZE SELECT * FROM res_device WHERE id=1;
 Sort  (cost=16.93..16.94 rows=1 width=126) (actual time=0.854..0.864 rows=0 loops=1)
   Sort Key: d.last_activity DESC
   Sort Method: quicksort  Memory: 25kB
   ->  Nested Loop Anti Join  (cost=0.86..16.92 rows=1 width=126) (actual time=0.844..0.852 rows=0 loops=1)
         ->  Index Scan using res_device_log_pkey on res_device_log d  (cost=0.43..8.45 rows=1 width=126) (actual time=0.608..0.613 rows=1 loops=1)
               Index Cond: (id = 1)
               Filter: (NOT revoked)
         ->  Index Scan using res_device_log__session_identifier_index on res_device_log d2  (cost=0.43..8.46 rows=1 width=49) (actual time=0.221..0.223 rows=1 loops=1)
               Index Cond: ((session_identifier)::text = (d.session_identifier)::text)
               Filter: ((NOT revoked) AND (NOT ((platform)::text IS DISTINCT FROM (d.platform)::text)) AND (NOT ((browser)::text IS DISTINCT FROM (d.browser)::text)) AND (user_id = d.user_id) AND ((last_activity > d.last_activity) OR ((last_activity = d.last_activity) AND (id > d.id))))
               Rows Removed by Filter: 1
 Planning Time: 8.539 ms
 Execution Time: 0.930 ms
```

Administrator with corrected view and index:
```
EXPLAIN ANALYZE SELECT * FROM res_device WHERE id=1;
 Sort  (cost=16.93..16.94 rows=1 width=126) (actual time=0.151..0.163 rows=0 loops=1)
   Sort Key: d.last_activity DESC
   Sort Method: quicksort  Memory: 25kB
   ->  Nested Loop Anti Join  (cost=0.86..16.92 rows=1 width=126) (actual time=0.140..0.149 rows=0 loops=1)
         ->  Index Scan using res_device_log_pkey on res_device_log d  (cost=0.43..8.45 rows=1 width=126) (actual time=0.063..0.067 rows=1 loops=1)
               Index Cond: (id = 1)
               Filter: (NOT revoked)
         ->  Index Only Scan using res_device_log__composite_idx on res_device_log d2  (cost=0.43..8.46 rows=1 width=49) (actual time=0.064..0.066 rows=1 loops=1)
               Index Cond: ((user_id = d.user_id) AND (session_identifier = (d.session_identifier)::text))
               Filter: ((NOT ((platform)::text IS DISTINCT FROM (d.platform)::text)) AND (NOT ((browser)::text IS DISTINCT FROM (d.browser)::text)) AND ((last_activity > d.last_activity) OR ((last_activity = d.last_activity) AND (id > d.id))))
               Rows Removed by Filter: 1
               Heap Fetches: 1
 Planning Time: 11.480 ms
 Execution Time: 0.225 ms
```

Forward-Port-Of: odoo/odoo#186106

[FW][FIX] hr_holidays: Use less aggressive cache invalidation

PR #186318

Core18.0hr_holidays

Before this commit, when the accrual cron was running and there was a leave in the future to account for, it would calculate the number of days by processing a fake allocation and invalidating it afterwards. However, the cache invalidation was too aggressive and would also invalidate any changes that were made to existing accrual allocations that were not yet flushed. This commit fixes this behavior by invalidating the recordset so as to only invalidate the fake allocations. opw-4200067 F

Original PR description

Before this commit, when the accrual cron was running and there was a leave in the future to account for, it would calculate the number of days by processing a fake allocation and invalidating it afterwards. However, the cache invalidation was too aggressive and would also invalidate any changes that were made to existing accrual allocations that were not yet flushed.

This commit fixes this behavior by invalidating the recordset so as to only invalidate the fake allocations.

opw-4200067

Forward-Port-Of: odoo/odoo#185957

[FW][FIX] hr: change default job title on employee badge

PR #186508

Core18.0hr

Issue: When printing an employee badge for an employee without a job position, the default title was set to "Software Developer." Steps to Reproduce: -Create an employee with an empty job position. -Alternatively, remove the job position of an existing employee. -Generate and print a badge (in HR settings). Explanation: In `hr_employee_badge.xml`, the default value was set to "Software Developer." opw-4255102 --- I confirm I have signed the CLA and read the PR guidelines at www.

Original PR description

Issue:
When printing an employee badge for an employee without a job position, the default title was set to "Software Developer."

Steps to Reproduce:
-Create an employee with an empty job position.
-Alternatively, remove the job position of an existing employee. -Generate and print a badge (in HR settings).

Explanation:
In `hr_employee_badge.xml`, the default value was set to "Software Developer."

opw-4255102

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#186152
Forward-Port-Of: odoo/odoo#185458

[FW][FIX] core: browser: storage in non-storing context

PR #186520

Core18.0webweb_editorwebsite

Blacklist Odoo in your browser from having access to the local and session storages (security parameters). Before this commit, there were unrecoverable crashes because even doing `window.[localStorage|sessionStorage]` is forbidden. After this commit, we catch those exceptions and make a RamStorage instead. opw-4226366 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA

Original PR description

Blacklist Odoo in your browser from having access to the local and session storages (security parameters).

Before this commit, there were unrecoverable crashes because even doing `window.[localStorage|sessionStorage]` is forbidden.

After this commit, we catch those exceptions and make a RamStorage instead.

opw-4226366

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#186294
Forward-Port-Of: odoo/odoo#185811

[FW][FIX] l10n_sa_invoice: Fixed Labels and Translations

PR #186204

Core18.0l10n_gcc_invoicel10n_sal10n_sa_edi

Description of the issue/feature this PR addresses: Link to task: [#4218972](https://www.odoo.com/web#model=project.task&id=4218972) This change fixes english and arabic labels & translations in the l10n_sa_invoice module Current behavior before PR: Some labels are inaccurate or do not match the saudi arabia ZATCA invoice template. Desired behavior after PR is merged: Labels are more accurate and match the saudi arabia ZATCA invoice template. --- I confirm I have signed the CL

Original PR description

Description of the issue/feature this PR addresses:
Link to task: [#4218972](https://www.odoo.com/web#model=project.task&id=4218972)
This change fixes english and arabic labels & translations in the l10n_sa_invoice module 

Current behavior before PR:
Some labels are inaccurate or do not match the saudi arabia ZATCA invoice template.

Desired behavior after PR is merged:
Labels are more accurate and match the saudi arabia ZATCA invoice template.



---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#186096
Forward-Port-Of: odoo/odoo#184060

[FW][IMP] l10n_es: Add new tax grid for es

PR #185876

Core18.0l10n_es

[IMP] l10n_es: Add new tax grid for es *Create a new tax grid mod390[110] *Add this tax grid to all taxes in l10n_es on Distribution lines that already have mod303[120] *Make the modelo 390 use that tax grid on the line 110 task-4058894 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#175354

Original PR description

[IMP] l10n_es: Add new tax grid for es

*Create a new tax grid mod390[110]
*Add this tax grid to all taxes in l10n_es on Distribution lines that already have mod303[120] *Make the modelo 390 use that tax grid on the line 110

task-4058894

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#175354

[FW][FIX] pos_loyalty: promotion not applied in combo product

PR #186533

Core18.0pos_loyalty

Steps to reproduce: ==== - Create a promotion program - Rule: Condition --> Select combo product, Reward --> type - discount specific product - Combo product - Open POS and add combo product. - Click on reward button and select on available reward. Issue: === - Promotion is not applied if combo product is added. Fix: === - Previously, when a specific combo product was added as a loyalty reward, it wasn’t properly handled in promotions. This update ensures that combo products in

Original PR description

Steps to reproduce:
====
- Create a promotion program 
- Rule: Condition --> Select combo product,  Reward --> type - discount specific product - Combo product 
- Open POS and add combo product.
- Click on reward button and select on available reward.

Issue:
===
- Promotion is not applied if combo product is added.

Fix:
===
- Previously, when a specific combo product was added as a loyalty reward, it wasn’t properly handled in promotions. This update ensures that combo products included in loyalty rewards and promotion is applied.

task-4285895

Forward-Port-Of: odoo/odoo#186231
Forward-Port-Of: odoo/odoo#185780

[FW][IMP] web_editor, html_editor: autoscroll latest response in chatgpt

PR #185901

Core18.0html_editorweb_editor

**Behaviour before PR:** In chatGPT prompt dialog, scroll position is not set to the latest message automatically after hitting 3-4 prompts. User has to scroll to bottom manually. **After this PR:** This commit aims to make sure that the scroll postion is set to the latest message after submitting prompt. task-4256085 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#185784 Forward-Port-Of: odoo/odoo#183862

Original PR description

**Behaviour before PR:**

In chatGPT prompt dialog, scroll position is not set to the latest message automatically after hitting 3-4 prompts. User has to scroll to bottom manually.

**After this PR:**

This commit aims to make sure that the scroll postion is set to the latest message after submitting prompt.

task-4256085




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#185784
Forward-Port-Of: odoo/odoo#183862

[FW][PERF] stock: improve perf of _get_report_lines

PR #186521

Core18.0stock

Description of the issue/feature this PR addresses: - Improve _get_report_lines performance Current behavior before PR: - A lag is seen when opening Manufacturing orders, because it goes to compute `components_availability`, calling https://github.com/odoo/odoo/blob/0d3ab1203ad00e2c41768f3209e45cd673e519e7/addons/mrp/models/mrp_production.py#L344 function, which ends up calling https://github.com/odoo/odoo/blob/0d3ab1203ad00e2c41768f3209e45cd673e519e7/addons/stock/report/stock_forecasted.

Original PR description

Description of the issue/feature this PR addresses: - Improve _get_report_lines performance Current behavior before PR: - A lag is seen when opening Manufacturing orders, because it goes to compute…

Description of the issue/feature this PR addresses:
- Improve  _get_report_lines performance

Current behavior before PR:
- A lag is seen when opening Manufacturing orders, because it goes to compute `components_availability`, calling
https://github.com/odoo/odoo/blob/0d3ab1203ad00e2c41768f3209e45cd673e519e7/addons/mrp/models/mrp_production.py#L344 function, which ends up calling https://github.com/odoo/odoo/blob/0d3ab1203ad00e2c41768f3209e45cd673e519e7/addons/stock/report/stock_forecasted.py#L190 
- currently, in `_get_report_lines` function, **transit_stock**
https://github.com/odoo/odoo/blob/0d3ab1203ad00e2c41768f3209e45cd673e519e7/addons/stock/report/stock_forecasted.py#L353  is calculated by summing quantities with list comprehension on the **currents** dictionary for each product.
https://github.com/odoo/odoo/blob/0d3ab1203ad00e2c41768f3209e45cd673e519e7/addons/stock/report/stock_forecasted.py#L327  
- This becomes slow when handling huge number of products and large currents entries. due to O(n * m) complexity

Desired behavior after PR is merged:
- A dictionary of pre-computed product quantity, minimizes the time taken.

### Here are few benchmarks and stats.

**At time of function call :** 
- As the test database is populated with 2 location ids `_get_report_lines` is called twice during testing, because of https://github.com/odoo/odoo/blob/6e9ace2df2dd3750472c227f818d3dc8d5ba5016/addons/stock/models/stock_move.py#L515-L517
- size of currents dict :  2539 + 2600 
- No. of product :  2539 + 2412

## Before
![before](https://github.com/user-attachments/assets/f99c11b3-ee11-4b09-80c1-e769589b6156)

## After
![after](https://github.com/user-attachments/assets/597687dc-fc1f-452f-b5a5-e5579880ed61)

opw- 4285618
upg- 2179723

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#186238

[FW][FIX] {,website_}sale_product_configurator: shrink cart button

PR #186505

Core18.0salewebsite_sale

Versions -------- - 16.0 _(sale_product_configurator)_ - 17.0+ _(website_sale_product_configurator)_ Steps ----- 1. Enable Dutch language; 2. go to eCommerce; 3. switch to mobile view; 4. go to a product which has optional products; 5. add to cart. Issue ----- There's not enough space in the configurator to properly display the "Toevoegen aan winkelmandje" button. Cause ----- The view isn't mobile-responsive. Solution -------- Replace the button with a simple cart ico

Original PR description

Versions
--------
- 16.0  _(sale_product_configurator)_
- 17.0+ _(website_sale_product_configurator)_

Steps
-----
1. Enable Dutch language;
2. go to eCommerce;
3. switch to mobile view;
4. go to a product which has optional products;
5. add to cart.

Issue
-----
There's not enough space in the configurator to properly display the "Toevoegen aan winkelmandje" button.

Cause
-----
The view isn't mobile-responsive.

Solution
--------
Replace the button with a simple cart icon to ensure consistency between localisations while keeping things simple.

opw-4198786

Forward-Port-Of: odoo/odoo#186050
Forward-Port-Of: odoo/odoo#185133

[FW][IMP] calendar: remove redundant start time in UI

PR #186477

Core18.0calendar

When in daily and weekly calendar views, the start time of events are shown twice in the event card, poluting the user interface. This commit removes the isolated start time for making the event card cleaner. task-4161302 Forward-Port-Of: odoo/odoo#186177 Forward-Port-Of: odoo/odoo#178984

Original PR description

When in daily and weekly calendar views, the start time of events are shown twice in the event card, poluting the user interface.

This commit removes the isolated start time for making the event card cleaner.

task-4161302

Forward-Port-Of: odoo/odoo#186177
Forward-Port-Of: odoo/odoo#178984

[FW][FIX] point_of_sale: broken combo selection

PR #186503

Core18.0point_of_sale

Steps: - Open Terminal and click on the burger combo - Select burger and click the cancel button - Select the burger again and click OK with the default selection - Select a drink Issue: - After selecting all components of the product, the `Add to Order` button remains disabled, preventing the combo from being added to the cart. Cause: - The combo state is not being reset when discarding or closing the product configuration popup. Fix: - Implemented a proper reset of the combo st

Original PR description

Steps:
- Open Terminal and click on the burger combo
- Select burger and click the cancel button
- Select the burger again and click OK with the default selection
- Select a drink

Issue:
- After selecting all components of the product, the `Add to Order` button remains disabled, preventing the combo from being added to the cart.

Cause:
- The combo state is not being reset when discarding or closing the product configuration popup.

Fix:
- Implemented a proper reset of the combo state upon closing the configuration popup.

task-4285981

Forward-Port-Of: odoo/odoo#186393
Forward-Port-Of: odoo/odoo#185296

[FW][FIX] l10n_in: Remove Enterprise Widget from E-invoice

PR #186556

Core18.0l10n_in

System shows Enterprise Widget on E-invoice module Although the module is available in community addons Steps to Reproduce : Run only community Install l10n_in module. Now Go to the Settings -> Invoicing. See the Enterprise Widget is on E-Invoice (Indian Integration). Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submi

Original PR description

System shows Enterprise Widget on E-invoice  module

Although the module is available in community addons

Steps to Reproduce :
Run only community
Install l10n_in module.
Now Go to the Settings -> Invoicing.
See the Enterprise Widget is on E-Invoice (Indian Integration).

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#186469
Forward-Port-Of: odoo/odoo#186389

[FW][FIX] maintenance: wait for drag_and_drop target rendering

PR #186332

Core18.0maintenance

During `test_drag_and_drop_event_in_calendar`, an error occurs due to the target not being found in drag and drop steps. When the test is performed on the same week as the event, there is a likely chance for the drag and drop steps to be triggered before the rendering of the Monthly Calendar view. When we are changing from weekly to monthly view, we will wait for the latter to be rendered before calling the next steps. runbot-error-105708 runbot-error-105709 Forward-Port-Of: odoo/odoo#18

Original PR description

During `test_drag_and_drop_event_in_calendar`, an error occurs due to the target not being found in drag and drop steps.

When the test is performed on the same week as the event, there is a likely chance for the drag and drop steps to be triggered before the rendering of the Monthly Calendar view. When we are changing from weekly to monthly view, we will wait for the latter to be rendered before calling the next steps.

runbot-error-105708
runbot-error-105709

Forward-Port-Of: odoo/odoo#186142

[FW][FIX] project: hide `Task Management` section in project if no options is active

PR #186519

Core18.0project

Fixed issue introduced in this PR: https://github.com/odoo/odoo/pull/119154. In the above PR, the recurring setting was removed, but the recurring groups were not removed from the group configuration, which caused the group's string to still appear. This issue has now been fixed. Steps to Reproduce and Verify the Fix: 1) Install the Project App. 2) Go to the Project App. 3) Activate the Recurring Feature in the settings. 4) Open any project and verify

Original PR description

Fixed issue introduced in this PR: https://github.com/odoo/odoo/pull/119154.

  In the above PR, the recurring setting was removed, but the recurring groups
  were not removed from the group configuration, which caused the group's string
  to still appear. This issue has now been fixed.

  Steps to Reproduce and Verify the Fix:
      1) Install the Project App.
      2) Go to the Project App.
      3) Activate the Recurring Feature in the settings.
      4) Open any project and verify the settings.

  task-4260042



---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#183861

[FW][FIX] industry_fsm_sale: adapt to domain method not harcoded anymore

PR #73351

Enterprise18.0

Since domain method for the Sales Order Item field is not harcoded anymore, the inheritance in this module is now considered, so it needs to be adapted to work correctly with the expected value, i.e. returning a list instead of a string. [FIX] helpdesk_sale_timesheet: unharcode domain method of SO line field Since domain method of the Sales Order Item field is set using the actual class method instead of a lambda, it is not possible to inherit that method when inheriting the model.

Original PR description

Since domain method for the Sales Order Item field is not harcoded
anymore, the inheritance in this module is now considered, so it needs
to be adapted to work correctly with the expected value, i.e. returning
a list instead of a string.

[FIX] helpdesk_sale_timesheet: unharcode domain method of SO line field

Since domain method of the Sales Order Item field is set using the
actual class method instead of a lambda, it is not possible to inherit
that method when inheriting the model.

This issue is fixed by using a lambda function to call the domain
method.

Forward-Port-Of: odoo/enterprise#73188
Forward-Port-Of: odoo/enterprise#72931

[FW][FIX] l10n_es_reports: fix "Type for mod 347" default value

PR #73508

Enterprise18.0

**Steps to reproduce:** - Install l10n_es_reports and Sales - Create a SO for a Spanish customer - Create an invoice from the SO - Check "AEAT data" tab of the invoice **Issue:** "Type for mod 347" is not set. It should be set to "Regular operation" as it is done when creating an invoice manually. **Cause:** The default is handled by a function that depends on another field. However that other field is not set when computing the default value and the result is always False. **So

Original PR description

**Steps to reproduce:**
- Install l10n_es_reports and Sales
- Create a SO for a Spanish customer
- Create an invoice from the SO
- Check "AEAT data" tab of the invoice

**Issue:**
"Type for mod 347" is not set.
It should be set to "Regular operation" as it is done when creating an invoice manually.

**Cause:**
The default is handled by a function that depends on another field.
However that other field is not set when computing the default value and the result is always False.

**Solution:**
There were a function for the default (_default_mod_349_invoice_type) and an onchange on partner (_onchange_partner_id_set_347_invoice_type). Both of them were checking different conditions.
The fix is merging these 2 methods by converting the field into a computed stored field where both conditions are handled.

opw-4194030

Forward-Port-Of: odoo/enterprise#72958

[FW][FIX] planning: fix 'requests to switch' filter's timezone problem

PR #73435

Enterprise18.0

The 'Requests to switch' filter is supposed to show slots that are unwanted and that are not in the past. Prior to this commit, some shifts that were in the future were not shown by the filter. That was because the planning.slot field end_datetime was encoded in UTC while the datetime.datetime.now() function in the filter's domain was returning the datetime in the client's timezone. Shifts in the time difference between the user's timezone and UTC would be mistakenly marked as "past shifts

Original PR description

The 'Requests to switch' filter is supposed to show slots that are unwanted and that are not in the past.

Prior to this commit, some shifts that were in the future were not shown by the filter.

That was because the planning.slot field end_datetime was encoded in UTC while the datetime.datetime.now() function in the filter's domain was returning the datetime in the client's timezone. Shifts in the time difference between the user's timezone and UTC would be mistakenly marked as "past shifts" while they might still be in the future.

We fix this by using the 'to_utc()' function which should make the filter domain's comparisson between 2 UTC datetimes.

Fix done in 17.0

task-4286161

Forward-Port-Of: odoo/enterprise#72820

[FW][FIX] hr_payroll: no traceback adding line to draft payslip wizard

PR #73326

Enterprise18.0

Steps --- * Create a payslip for an Employee with a contract (e.g. Anita Oliver) (*Payroll > Payslips > All Payslips > New*) * From the *Edit Payslip Lines* action, try to add a new worked day line (first list) with a non 0 amount * *Validate Edition* => Traceback Cause --- When saving new worked days lines, we try to recompute the amount of the *Basic Salary* payslip line, but if the payslip is still a **draft** it was never computed, and so the action we are calling does not exist

Original PR description

Steps
---
* Create a payslip for an Employee with a contract (e.g. Anita Oliver) 
  (*Payroll > Payslips > All Payslips > New*)
* From the *Edit Payslip Lines* action, try to add a new worked day line (first list) with a non 0 amount
* *Validate Edition* => Traceback

Cause
---
When saving new worked days lines, we try to recompute the amount of the *Basic Salary* payslip line, but if the payslip is still a **draft** it was never computed, and so the action we are calling does not exist.

task-4191349

Forward-Port-Of: odoo/enterprise#72031
Forward-Port-Of: odoo/enterprise#71373

[FW][FIX] account_reports,account_reports_cash_basis: translate filter options

PR #73421

Enterprise18.0

The problem: In the accounting reports, filter options were not being translated. Steps to reproduce: Install and change to the Danish language. Navigate to Accounting > Reporting > Partner ledger (Kontoudtog) Activate the filter "Only Show Unreconciled Entries" (Vis kun ikke udlignede posteringer) Generate the PDF report. Why it was happening: The array `extra_options` was built dynamically by concatenating raw python strings to it. Those raw strings will not be translated. The f

Original PR description

The problem:
In the accounting reports, filter options were not being translated.

Steps to reproduce:

Install and change to the Danish language.
Navigate to Accounting > Reporting > Partner ledger (Kontoudtog)
Activate the filter "Only Show Unreconciled Entries" (Vis kun ikke udlignede posteringer)
Generate the PDF report.
Why it was happening:
The array `extra_options` was built dynamically by concatenating raw python strings to it. Those raw strings will not be translated.

The fix:
Now, we create local variables for each string, using the syntax `<t t-set="label_raw_string">Raw String</t>` which makes the string label_raw_string translatable, then we append it to `extra_options`.

opw-4213562

Forward-Port-Of: odoo/enterprise#73352
Forward-Port-Of: odoo/enterprise#72870

[FW][FIX] sale_subscription_stock: exclude renewed subs from stock forecast

PR #73413

Enterprise18.0

Steps to reproduce: - New product > Storable; Recurring; Edit 'On Hand Quantity' to 10 - New subscription > Add your product > Confirm - Create Invoice > Confirm > Back to sub - View forecast on order line > 1 reserved; 1 forecasted for next period (This is correct, the subscription is ongoing) - Renew > Confirm > View forecast - 1 reserved for original sub (OK); 2 forecasted for next period This is wrong because renewed subscriptions should no longer have recurring invoices, meaning th

Original PR description

Steps to reproduce:
- New product > Storable; Recurring; Edit 'On Hand Quantity' to 10
- New subscription > Add your product > Confirm
- Create Invoice > Confirm > Back to sub
- View forecast on order line > 1 reserved; 1 forecasted for next period (This is correct, the subscription is ongoing)
- Renew > Confirm > View forecast
- 1 reserved for original sub (OK); 2 forecasted for next period

This is wrong because renewed subscriptions should no longer have recurring invoices, meaning there is no reason to forecast a stock decrease for them. i.e here it should only forecast 1 unit for the next period corresponding to our new subscription (Created by renew).

Prior to 17.0 a storable product cannot also be recurring, so this issue is irrelevant there.

opw-4239989

Forward-Port-Of: odoo/enterprise#73347
Forward-Port-Of: odoo/enterprise#72397

[FW][FIX] web_studio: handle logic for not groups attribute

PR #73419

Enterprise18.0

Have a node that goes: ```xml <div groups="!module.some_group" /> ``` Before this commit, this case was not handled and that not-group was just ignored. This created confusion as the node, when the user was part of the group, would be invisible, the checkbox invisible would be ticked, and uniticking it had no effect. After this commit, we handle the case, with a second selector in the studio sidebar. opw-4273853 Forward-Port-Of: odoo/enterprise#73341 Forward-Port-Of: odoo/enter

Original PR description

Have a node that goes:
```xml
<div groups="!module.some_group" />

```

Before this commit, this case was not handled and that not-group was just ignored.

This created confusion as the node, when the user was part of the group, would be invisible, the checkbox invisible would be ticked, and uniticking it had no effect.

After this commit, we handle the case, with a second selector in the studio sidebar.

opw-4273853

Forward-Port-Of: odoo/enterprise#73341
Forward-Port-Of: odoo/enterprise#73233

[FW][FIX] account_3way_match: fix computation of "release_to_pay"

PR #73424

Enterprise18.0

**Steps to reproduce:** - Install account_3way_match - Go to "Invoicing / Vendors / Bills" - Create a bill - (Edit the view in order to display "release_to_pay" field) - (Make sure that "Force Status" (force_release_to_pay) is always checked) - Set "Should Be Paid" (release_to_pay_manual) to "Yes" => "release_to_pay" becomes "Yes" - Save the bill => "release_to_pay" stays "Yes" - Change "Should Be Paid" to "No" => "release_to_pay" becomes "No" - Save the bill => "release_to_pay" reverts

Original PR description

**Steps to reproduce:**
- Install account_3way_match
- Go to "Invoicing / Vendors / Bills"
- Create a bill
- (Edit the view in order to display "release_to_pay" field)
- (Make sure that "Force Status" (force_release_to_pay) is always checked)
- Set "Should Be Paid" (release_to_pay_manual) to "Yes" => "release_to_pay" becomes "Yes"
- Save the bill => "release_to_pay" stays "Yes"
- Change "Should Be Paid" to "No" => "release_to_pay" becomes "No"
- Save the bill => "release_to_pay" reverts to "Yes"

**Issue:**
Upon save, "release_to_pay" reverts to "Yes", even if it has been correctly computed to "No" before saving.

opw-4181752

Forward-Port-Of: odoo/enterprise#73289
Forward-Port-Of: odoo/enterprise#72190

[FW][FIX] account_asset: compare_amounts return 1 not bigger than 1

PR #73321

Enterprise18.0

To check that an amount is greater than another one, compare_amounts need to be bigger than 0 not 1 Forward-Port-Of: odoo/enterprise#73183 Forward-Port-Of: odoo/enterprise#73159

Original PR description

To check that an amount is greater than another one, 
compare_amounts need to be bigger than 0 not 1

Forward-Port-Of: odoo/enterprise#73183
Forward-Port-Of: odoo/enterprise#73159

[FW][FIX] planning: fix color of icons on the "ask to switch" toast

PR #73420

Enterprise18.0

Currently, when the "Ask to Switch" toast is displayed, the fa-check-circle and fa-exclamation-circle are not visible because they have the same color as the background of the toast. This PR will remove their color, making them dark and visible. task-3919543 Forward-Port-Of: odoo/enterprise#71345

Original PR description

Currently, when the "Ask to Switch" toast is displayed, the fa-check-circle and fa-exclamation-circle are not visible because they have the same color as the background of the toast.

This PR will remove their color, making them dark and visible.

task-3919543

Forward-Port-Of: odoo/enterprise#71345

[FW][FIX] planning: allocated hours not recomputed in shift duplication

PR #73426

Enterprise18.0

Steps to reproduce: ------------------- 1. Install Planning app 2. Have an employee A with 40h/week working schedule and an employee B with 35h/week working schedule 3. Create a shift and assign it to employee A, the default allocated hours should be 8h 4. From the Gantt view, duplicate this shift and assign it to employee B (use drag and drop) 5. Problem: The allocated hours of the duplicated shift are not recomputed, they are equal to 8h instead of 7h Fix: ------------------- When d

Original PR description

Steps to reproduce:
-------------------
1. Install Planning app
2. Have an employee A with 40h/week working schedule and an employee B with 35h/week working schedule
3. Create a shift and assign it to employee A, the default allocated hours should be 8h
4. From the Gantt view, duplicate this shift and assign it to employee B (use drag and drop)
5. Problem: The allocated hours of the duplicated shift are not recomputed, they are equal to 8h instead of 7h

Fix:
-------------------
When duplicating a shift and assigning it to another resource, the copy() method is called with the resource_id of the target resource (an employee in this case). But _compute_allocated_hours() is not called so we have to call it explicitly in this case.

version-17.0
task-3978590

Forward-Port-Of: odoo/enterprise#69828

[FW][FIX] helpdesk{_timesheet, _sale_timesheet} : Show all non-billable projects

PR #73431

Enterprise18.0

### Current behavior before PR: When creating a Helpdesk team and the Timesheets option enabled and Time Billing disabled you will not get all non-billed projects in the dropdown menu. This is happening because the domain for project_id is checking the company_id to be the same as the company_id of the team. https://github.com/odoo/enterprise/blob/18.0/helpdesk_sale_timesheet/models/helpdesk_team.py#L10 Though since this commit https://github.com/odoo-dev/odoo/commit/16a07ed1bfd33a193b363f3e87

Original PR description

### Current behavior before PR: When creating a Helpdesk team and the Timesheets option enabled and Time Billing disabled you will not get all non-billed projects in the dropdown menu. This is…

### Current behavior before PR:
When creating a Helpdesk team and the Timesheets option enabled and Time Billing disabled you will not get all non-billed projects in the dropdown menu. This is happening because the domain for project_id is checking the company_id to be the same as the company_id of the team.
https://github.com/odoo/enterprise/blob/18.0/helpdesk_sale_timesheet/models/helpdesk_team.py#L10 Though since this commit https://github.com/odoo-dev/odoo/commit/16a07ed1bfd33a193b363f3e87aab3f9bd6f8bd0 company_id is not required for projects. Since the domain of the project_id field was introduced here https://github.com/odoo/enterprise/pull/4956/commits/c82b1b019cebd1f78749b9563e717fae88d7fae5 and the reason why we check the company_id is not the same anymore since the commit I mentioned above we should not use the same domain.

Also in this PR we are solving another issue which is where you enable both Timesheets and Time Billing options and choose a project that has both options enabled too then you disable the Time Billing option for the team the project that we chose before will be kept and have both options enabled and you can save it.

### Desired behavior after PR is merged:
We are now checking for the project of the team if the company_id is False or equal to the team's company_id.

Also when disbaling the Time Billing option we set the project_id to False.

opw-4275647
opw-4148207

Forward-Port-Of: odoo/enterprise#72935

Branch: saas-17.2

Other(17)

[FW][FIX] account: ensure registry is loaded

[FW][FIX] project: hide `Task Management` section in project if no options is active

[FW][FIX] l10n_in: Remove Enterprise Widget from E-invoice

[FW][FIX] sale_mrp: Incorrect move kit qty after change on SOL

[FW][PERF] stock: improve perf of _get_report_lines

[FW][FIX] mail: escape on chatwindow thread rename

[FW][FIX] google_calendar, mail: failure of deleted record cannot be removed

[FW][FIX] mail: im_status flickering

[FW][FIX] purchase_stock,stock_account: aml zero quantity case

[FW][FIX] hr_holidays: Use less aggressive cache invalidation

[FW][FIX] core: browser: storage in non-storing context

[FW][IMP] l10n_si: update Slovenian localization

[FW][IMP] test_mail_sms: cleanup phone/mobile search tests

[FW][FIX] auth_password_policy_signup: minlength in form

[FW][FIX] repair: clear the lot when changing the product

[FW][PERF] base_automation: update date_automation_last after filtering trigger_field_ids

[FW][FIX] web_editor: make columns added with powerbox have the same size

Branch: master

Improvements(3)

[IMP] account_online_payment: removing unused field

Branch: 18.0

Improvements(2)

[IMP] knowledge: re-enable embedViewFiltersSteps steps

Branch: saas-17.2

Other(17)

[FW][FIX] account: ensure registry is loaded

[FW][FIX] project: hide `Task Management` section in project if no options is active

[FW][FIX] l10n_in: Remove Enterprise Widget from E-invoice

[FW][FIX] sale_mrp: Incorrect move kit qty after change on SOL

[FW][PERF] stock: improve perf of _get_report_lines

[FW][FIX] mail: escape on chatwindow thread rename

[FW][FIX] google_calendar, mail: failure of deleted record cannot be removed

[FW][FIX] mail: im_status flickering

[FW][FIX] purchase_stock,stock_account: aml zero quantity case

[FW][FIX] hr_holidays: Use less aggressive cache invalidation

[FW][FIX] core: browser: storage in non-storing context

[FW][IMP] l10n_si: update Slovenian localization

[FW][IMP] test_mail_sms: cleanup phone/mobile search tests

[FW][FIX] auth_password_policy_signup: minlength in form

[FW][FIX] repair: clear the lot when changing the product

[FW][PERF] base_automation: update date_automation_last after filtering trigger_field_ids

[FW][FIX] web_editor: make columns added with powerbox have the same size

Branch: master

Improvements(3)

[IMP] account_online_payment: removing unused field

Branch: 18.0

Improvements(2)

[IMP] knowledge: re-enable embedViewFiltersSteps steps

[IMP] delivery_easypost: validate widgets with their supported type

Declare fields on BaseModel

Bug Fixes(5)

[FIX] web_studio: export MAGIC_COLUMNS

[FIX] stock_barcode_barcodelookup: Misspelled error message

[WIP] [FIX] hr_payroll_account: fix accounting app not installed

[FIX] sale_subscription: use daterange widget instead

[FIX] sale_commission: Prevent duplicate status display in list view

Refactoring(1)

[REF] point_of_sale: reorganize `utils` files structure

Other(20)

[FW][FIX] account_asset: convert assets non-deductible tax value into com…

[FW][ADD] l10n_cl_edi_factoring: pass responsability of an invoice to third party

[FW][FIX] industry_fsm_sale: adapt to domain method not harcoded anymore

[FW][FIX] l10n_mx_edi: missing field definition

[FW] PRHOOT 26

[FW][FIX] web_studio: fix approval tour on apps module.

[FW][FIX] planning: fix 'requests to switch' filter's timezone problem

[FW][FIX] sale_subscription_stock: exclude renewed subs from stock forecast

[FW][FIX] hr_payroll: no traceback adding line to draft payslip wizard

[FW][FIX] web_studio: handle logic for *not* groups attribute

[FW][IMP] account_bank_statement_extract: add journal type to user infos

[FW][FIX] industry_fsm_report: fix industry_fsm_report_tour tour

[FW][FIX] account_reports,account_reports_cash_basis: translate filter options

[FW][FIX] spreadsheet_edition: don't copy revisions with new data

[FW][FIX] documents: drag to trash reload search panel

[FW][FIX] sign: fix glitch with attachment button

[FW][FIX] project_sale_subscription: end reccurence on sub closing

[FW][FIX] sale_subcription_timesheet: fix post condition

[FW][IMP] mail: restrict template rendering by default

[FW][FIX] web_studio: handle logic for not groups attribute

[FIX] : redirect 17 documentation url to 18.0

[FW][FIX] web_studio: handle logic for not groups attribute