Daily updates from Odoo
Wednesday, November 20, 2024
56 changes · 18.0
Enhancements to existing features
Users can now re-import exported chart of accounts spreadsheets that include company-specific account code mappings without import failures. The update also improves account code uniqueness checks so Odoo proposes valid, available account codes more reliably across companies.
Original PR description
When exporting a CoA in Excel format, the user can export the code mapping for all the companies via the `code_mapping_ids/company_id` and `code_mapping_ids/code` columns. However, importing these…
When exporting a CoA in Excel format, the user can export the code mapping for all the companies via the `code_mapping_ids/company_id` and `code_mapping_ids/code` columns. However, importing these values fails because the import transforms these values into `CREATE` commands on `code_mapping_ids`, which are currently not handled. With this commit, we catch those CREATE commands in `account.account` `create` and `write` methods and modify the account's code in the relevant company. In addition, we take the opportunity to correctly rewrite the `_ensure_code_is_unique` check method. In https://github.com/odoo/odoo/pull/181352, we relaxed the constraint that prevented accounts from being mapped to an account code in a company the account doesn't belong to, if there already exists an account in that company that already has that code. However, the `_ensure_code_is_unique` wasn't rigorously rewritten, and it didn't apply the check in a consistent manner. We now rewrite it and provide tests for it. We also modify the `_search_new_account_codes` method accordingly, such that it proposes the first non-reserved account code. Enterprise PR: https://github.com/odoo/enterprise/pull/71910 task-4247869
Indian localization settings now clarify which HSN code length applies based on business value thresholds. Companies below 5 crore use 4-digit HSN codes, while those above 5 crore use 6-digit HSN codes, helping users follow reporting requirements more clearly.
Original PR description
Modified HSN display format based on crore thresholds: - 4-digit HSN for values below 5 crore. - 6-digit HSN for values above 5 crore. This update enhances clarity by providing distinct formats for HSN codes based on value thresholds. > Task: 4252228
A new automated test checks that non-admin users can access quotation documents as expected. This helps prevent future issues where regular sales users might be blocked from viewing or using quote documents.
Original PR description
This commit add test case to check quotation document access with non admin user to ensure user proparly able to access document without any issue. opw-4290856
Restaurant point-of-sale users can now return to the floor plan without waiting for a background server update to finish. This makes navigation feel quicker and removes an unnecessary notification when moving to the ticket screen.
Original PR description
- We don't wait anymore the server's response (from the call to `sync_from_ui`) when going to the floorplan. - Remove useless toaster notification when going to the ticket screen. task_id: 4329314 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Account imports now support accounts shared across companies by making the account code optional and allowing accounts to be matched by company-specific code, external ID, or database ID. Users can also import company-specific code mappings, helping multi-company setups maintain different account codes accurately.
Original PR description
We adjust the account import mechanism to the new reality that accounts can now be shared between companies, and have different codes in different companies. - The `code` column is now no longer required. Users can reference an account by its code in the current company (in which case only the account with that code that belongs to the current company will be matched), but can also reference an account by its external ID or database ID. - The user can import a code mapping for accounts via the `code_mapping_ids/company_id` and `code_mapping_ids/code` columns. We add a check that both of these columns must be simultaneously present. Community PR: https://github.com/odoo/odoo/pull/183695 task-4247869
Resolved issues and error corrections
This fixes a small visual alignment issue in the visitor live chat window. The avatar and conversation name now line up more cleanly, making the chat header look more polished and consistent.
Original PR description
In the backend, the avatar and conversation name is a clickable button to show more thread actions. When this is clickable, there's some spacing to align avatar nicely. In livechat from visitor perspective, however, the avatar was not spaced properly. This come from avatar and conversation name not being clickable to show more actions, because all actions are available in quick on the right side of header. This commit adds some spacing at beginning of header content of chat window when there's no actions menu, to compensate with the padding of the actions menu button. Before / After <img width="361" alt="Screenshot 2024-11-20 at 15 07 07" src="https://github.com/user-attachments/assets/0cbf75af-df85-4509-8ec3-31ed0893025b"> <img width="363" alt="Screenshot 2024-11-20 at 15 06 49" src="https://github.com/user-attachments/assets/2197a159-a64e-4b80-a5df-cd1b8fe3d578">
This fix lets website grid sections expand vertically when content needs more room, such as on smaller screens or in longer translated text. It helps prevent cramped or overflowing content, improving the visitor experience across devices and languages.
Original PR description
Website CSS grid bug fix affecting responsiveness to smaller screen resolutions. **Description of the issue/feature this PR addresses:** Having `grid-auto-rows` fixed at 50px stops the grid cells from growing in order to accommodate its content when the content narrows and increases in height. **Current behavior before PR:** Div does not respond to changes in screen resolution or changes caused by the content being translated to a different language. **Desired behavior after PR is merged:** Using the `minmax()` CSS function allows the grid cells to expand vertically to accommodate content that exceeds the minimum height of 50px, improving responsiveness on smaller screens. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix allows website content blocks to grow vertically when text wraps on smaller screens or after translation. It helps prevent cramped or cut-off content, improving the viewing experience across devices and languages.
Original PR description
Website CSS grid bug fix affecting responsiveness to smaller screen resolutions. **Description of the issue/feature this PR addresses:** Having `grid-auto-rows` fixed at 50px stops the grid cells from expanding vertically in order to accommodate it's content when the content narrows and increases in height. **Current behavior before PR:** Div does not respond to changes in screen resolution or changes caused by the content being translated to a different language. **Desired behavior after PR is merged:** Using the `minmax()` CSS function allows the grid cells to expand vertically to accommodate content that exceeds the minimum height of 50px, improving responsiveness on smaller screens. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Task records will no longer show duplicate update messages when a linked customer name changes. This keeps project communication logs clearer and avoids unnecessary noise for users reviewing task activity.
Original PR description
Before this commit, the `partner_name` was tracked in `project.task` model because `name` of `res.partner` model is tracked and so the related setup will keep the value set on `name` field of `res.partner` to also make the related field tracked. This commit removes the tracking on the related field in task since it was not expected. Moreover, we will get a duplicated tracking message with `partner_id` field which is also tracked in `project.task` model.
This fixes an issue where empty company-specific numeric or yes/no fields could cause database errors when records were loaded. Businesses using multi-company setups should see more reliable access to records with optional fields left blank.
Original PR description
Issue --> For company dependant fields of type `boolean`, `integer`, `float`, `monetary`, casting a `null` value leads to a `cannot cast jsonb null to type _` error on postgresql. For example,…
Issue -->
For company dependant fields of type `boolean`, `integer`, `float`, `monetary`, casting a `null` value leads to a `cannot cast jsonb null to type _` error on postgresql.
For example, consider the following ->
1. Database has two companies : 'a' and 'b'
2. has one res.partner record with no `credit_limit` set.
3. `credit_limit` (float or numeric) is not a required field and does not have a default value
`credit_limit` on the backend looks like `{"a.id": null, "b.id": null}`
Fetching the value for this field leads to method `_field_to_sql` which builds the select query, while also casting the type to each field. In this case, with no fallback default value and a float field, the query is `SELECT ("res_partner"."credit_limit"->'a.id')::double precision FROM res_partner` which resolves to `null(jsonb)::double precision` which unfortunately, is not supported on Postgresql.
Solution -->
Remove the condition for the types `boolean`, `integer`, `float`, `monetary` and use the `field->company_id->>0` logic instead. This works because the `->>` operator returns a text object; the text `null` value can be cast into the types mentioned above.
https://github.com/odoo/odoo/blob/2ed38db47ac3152eef1a0e328c8ff572474d079f/odoo/models.py#L2964-L2967
opw-4313425
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThe Discuss sidebar counter bubbles now keep their rounded shape even when channel or conversation names are long. This prevents the notification count from looking squeezed, improving readability and polish in the messaging interface.
Original PR description
This commit sets the `flex-shrink` of the counter element to `0` so it won't be reduced when a sidebar item has a long name. We can also remove the `min-width` from `o-discuss-badge` as all `.o-discuss-badge` cases use `.badge` which has a `min-width: 2.7ch`.
Portal users can now view pages containing the Blog snippet without hitting an error. The fix changes how the author name is shown so it no longer depends on permissions that portal users do not have.
Original PR description
Since [1], the template attempted to display the author's name using `record.author_id.name`, which caused access errors for portal users due to insufficient permissions on the res.partner model. By switching to the related field `author_name`, the template no longer requires direct access to `res.partner`, ensuring smooth functionality for all users. Steps to reproduce: - Log in as an administrator - Navigate to Website - Enter Edit Mode - Add a "Blog" snippet to the home page - Save the changes - Log out - Log in as a portal user - Observe that a traceback occurs [1]: https://github.com/odoo/odoo/commit/dbb72d1f68cf7f462e1d6bdf8998f29627ccc2f0 opw-4330845
Worldline payments can now correctly recognize additional statuses returned during validation. This prevents valid in-progress or declined payments from being misclassified, reducing payment follow-up issues for customers and staff.
Original PR description
Adding missing payment statuses: 'REDIRECTED', 'PENDING_CAPTURE' and 'CAPTURE_REQUESTED' as 'pending' states, 'REJECTED_CAPTURE' as 'declined' state as those statuses can effectively be received from Worldline.
The website's rounded box header now keeps proper spacing on mobile screens. This prevents header content from touching the border, improving the appearance and readability of mobile pages.
Original PR description
This PR aims to fix a spacing issue within the `rounded box` header template, which has no spacing in mobile, making the first and last element stick to the border of the header. To fix that behavior, we simply need to set a `padding` utility class on Mobile as well. - task-3608124 - extracted from https://github.com/odoo/odoo/pull/171050 | 18.0 | This PR | |--------|--------| |  |  | --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Mentions in Odoo Discuss now display correctly on Safari when messages span multiple lines. This prevents overlapping text, making conversations easier to read and improving the visual reliability of the messaging interface.
Original PR description
Before this commit, rendering of `@`mentions in Discuss on Safari was bigger than line height, which results in unintended UI overlap. This is mostly visible and problematic when 2 successive text…
Before this commit, rendering of `@`mentions in Discuss on Safari was bigger than line height, which results in unintended UI overlap. This is mostly visible and problematic when 2 successive text lines have mentions in the same horizontal range. This happens because discuss mentions are `<a>` and anchor links have `display: inline`. As a reminder, `inline` does not respect top/bottom padding and margin of element in its container so this is very likely prone to overlap vertically with sibling nodes. `inline-block`, on the other hand, take vertical padding and margin into account so it doesn't overlap. If the element takes more space, then siblings are pushed accordingly. This commit fixes the issue by setting `display: inline-block` to all discuss mentions, so that there's no risk of overlap in multi-line especially on Safari. Before / After <img width="520" alt="Screenshot 2024-11-20 at 12 54 31" src="https://github.com/user-attachments/assets/c1888680-e579-4573-930b-69bdf400f8e8"> <img width="523" alt="Screenshot 2024-11-20 at 12 54 12" src="https://github.com/user-attachments/assets/acfdfe8c-b6ef-49cc-8baf-816cf3058516">
This fix prevents an error when collaboration details for another editor are unavailable. It helps keep the HTML editor stable during shared editing sessions instead of interrupting users with a crash.
Original PR description
The `getPeerMetadata` function can return a falsy value and that was not taken into account.
This fixes an issue where users working in right-to-left languages could not see the table picker in Firefox. It restores access to table insertion in the HTML editor, improving reliability for affected language users.
Original PR description
Issue: ====== Table picker doesn't appear in rtl language in firefox Steps to reproduce the issue: ============================= - Make sure you use rtl lang - Create a new todo - Try to add table -…
Issue: ====== Table picker doesn't appear in rtl language in firefox Steps to reproduce the issue: ============================= - Make sure you use rtl lang - Create a new todo - Try to add table - Table picker doesn't appear Origin of the issue: ==================== The case of `left < 0` was handled wrong. They can both be handled by the sane formule. When left > 0 it will be like this: `|---left---||---width---||---right---|` `|-----------------window-------------|` So here `right = window-left-width` And when left < 0 it will be like this `|---width-----||---right------------------------ |` `|---left---| |` ` |-----------------window--------------|` And here `right = window - left - width` (left here is < 0) task-4282549 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The accounting screen now shows the secured entry status only when an entry is already secured or its journal is configured to secure posted entries with a hash. This prevents users from seeing a misleading status indicator just because they have access to inalterability features.
Original PR description
Before this **PR**: Since the visibility of the status bar for secured entries was controlled by the security group 'Show Inalterability Features', once assigned to a user, it would make the status bar visible indefinitely, regardless of whether the "Secure Posted Entries with Hash" option was activated or not. After this **PR**: The status bar for secured entries is now displayed only for entries that are already secured or belong to journals where the "Secure Posted Entries with Hash" option is enabled. **task**-4314073
This fix removes an incorrect blocking warning that prevented credit notes from being sent with UBL XML files when no recipient bank was set. Businesses can now process and send credit notes normally while keeping the bank requirement for customer invoices where it applies.
Original PR description
The previous warning asking to add a Recipient Bank was shown incorrectly in previous versions in case of Credit Notes. With the rework, we escalated this warning to a danger warning that prevent from sending, as in case of Customer Invoices it is a blocking error. The combinations of those two is now preventing Credit Notes to be sent with an UBL XML file. See: https://github.com/odoo/odoo/commit/9e769e1b11f22890e5245859053bc8dd31e42634 task-no
Regular employees can once again open their time off dashboard when their allocation uses an accrual plan. The fix ensures available time off is calculated correctly without exposing unnecessary setup details to users.
Original PR description
Accrual plans are not readable for regular users, so once a user has an accrual plan set on one of his allocation, he cannot open anymore his time off dashboard when it tries to get his allocation data (the time off he has). To ensure the correct computation of available time off, we add a sudo. This has been introduced in https://github.com/odoo/odoo/pull/172892/ --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Unfollow action in messages now uses the correct icon setup, preventing a broken or incorrect icon from appearing. This keeps the messaging interface visually consistent and easier for users to understand.
Original PR description
Follow-up of https://github.com/odoo/odoo/pull/184552 Commit above fixed an issue with `.oi` icon not showing correctly. To fix the issue, it puts the appropriate prefix `.fa` and `.oi` in the icon of the message action. The "Unfollow" message action was not properly adapted, which results in buggy icon due to missing `.fa`. This commit adds `.fa` in its icon definition similarly to how all message actions that use a font awesome icon should do.
The product catalog now waits for component changes to finish before refreshing shopfloor records. This prevents newly added manufacturing components from temporarily disappearing when users close the catalog quickly, improving reliability for shopfloor workflows and tests.
Original PR description
### Issue: Since 18.0, the catalog is used in certain actions of the shopfloor However, if you leave the catalog fast enough after your last change (something of the order of ~0.5 sec in localhost),…
### Issue: Since 18.0, the catalog is used in certain actions of the shopfloor However, if you leave the catalog fast enough after your last change (something of the order of ~0.5 sec in localhost), you can trigger a reload of the shopfloor records and call a `web_read` prior to the update of these records. ### Note: This is easily reproducible by hand in localhost and should worsen if you have server delay.In addition, Also, it makes it impossible to write a proper tour involving the catalog in the shopfloor. ### Steps to reproduce: - Create a product with a bom and an operation op1 - Create and confirm an MO for 1 unit of that product - Go to the shopfloor > on the operation > wheel > Add component - Add a component to be consumed in that operation - Close the catalog fast (using ESC for instance) #### > While the componenet was correctly added to the MO and linked to the WO it is not visible on the shopfloor. ### Cause of the issue: When a product is added from the catalog it triggers an rpc call to update the data's of the MO (notably creating a new raw move): https://github.com/odoo/odoo/blob/193c9a49dfc039ee93fbc8e171819236697b5c50/addons/product/static/src/product_catalog/kanban_record.js#L62-L69 https://github.com/odoo/odoo/blob/193c9a49dfc039ee93fbc8e171819236697b5c50/addons/mrp/models/mrp_production.py#L2898-L2901 On the other hand, closing the product catalog will reload the mrp record that started the action that opened the catalog: https://github.com/odoo/enterprise/blob/c1346dd2279bf3882b47b260b8d03ef9651ffaf1/mrp_workorder/static/src/mrp_display/dialog/mrp_menu_dialog.js#L41-L45 Since this reload is currently not waiting for the update of the record the associated `web_read` might be called prior to the last update of the record and the newly created raw moves might not be displayed. ### Fix: We use the props option of the action opening the catalog to transfer a callback to reload the records when all the record update promisses are resolved. Enterprise: https://github.com/odoo/enterprise/pull/72942 opw-4199156 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Translation has been forgotten in the forward port of the following PR: https://github.com/odoo/odoo/pull/187686 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Original PR description
Translation has been forgotten in the forward port of the following PR: https://github.com/odoo/odoo/pull/187686 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The UK CIS reporting module no longer loads test code during regular startup. This keeps testing logic separate from normal business use, reducing unnecessary processing and avoiding potential setup issues.
Original PR description
Tests should not be imported in module init. The import is done when tests are enabled.
Changing the project while creating a new timesheet no longer accidentally starts timers or creates duplicate records. The timer now starts only when users intentionally launch it from the timesheet timer header, reducing erroneous timesheet entries.
Original PR description
Steps to reproduce:
- List/grid view
- Click 'New'
- Change project field (1 or more times)
- Switch to kanban view
=> Timer started and many records created
Source of the bug:
- due to this condition 'record.isNew && record.data.project_id', introduced in commit 576c0eac3b8431a5080b6383ae256a0699ba7c7d,
each time project_id field is changed, action_start_new_timesheet_timer is called to start the timer and create a new record.
Fix:
- Start the timer only if new is called from the header timer by checking is_timer_running for that record.
task-4210112Uninstalling the Sign app after signing a document now also removes related activity reminders that would otherwise point to deleted records. This prevents users from seeing confusing missing-record errors after removing the app.
Original PR description
The issue: When uploading and signing a document, then uninstalling the Sign module, the following error message appears: `Missing Record Record does not exist or has been deleted. (Record: documents.document(42,), User: 2)` How to reproduce the issue: - Install Sign and Documents modules - Upload a PDF document and click on sign - Go to Apps and uninstall Sign When signing a document from `documents.document`, its `res_model` is set to `sign.template`, and a `mail.activity` is created for validation. On uninstalling Sign, all records with `res_model = 'sign.template'` are removed, but not in `mail.activity`. This happens because deletion occurs via cascade (`sign.template` -> `attachment.id` -> `documents.document`), meaning that`unlink` from `documents.document`is not called. opw-4283568
When an appointment creates a CRM lead, the lead now keeps the attendee-provided description. This helps sales teams see important appointment answers directly on the lead, where they are easier to use during follow-up.
Original PR description
commit [1] removes the hard-coded description on appointment calendar events. We still want to use the "attendee description" on crm leads as questions are not easily accessible from there. [1] 8b9a1a4462453bf64e7bc1307ededd0d127a27fa task-4347415
The Belgian payroll process now skips freelancers when allocating paid time off. This prevents incorrect leave allocations for workers who should not receive employee time off entitlements.
This fix prevents document updates or upgrades from failing when certain document tags are missing. It makes the Documents module more reliable during setup and migration by avoiding errors from optional setup records.
Original PR description
The server actions refer to document tags added in this version. Since the records have the `forcecreate=0` flag, the might not exist, triggering an error. To reproduce: - Create a fresh db in 18. - Delete any referenced tag in the file (eg `documents.documents_tag_inbox`) - Update documents This error will also happen during upgrades from previous versions if the old record to be renamed is missing. ``` ValueError: External ID not found in the system: documents.documents_tag_inbox ```
This update improves the signing experience by fixing mobile display problems, preventing expired items from appearing in completion dialogs, and ensuring refused signature requests are properly cancelled. It also stabilizes related automated checks so archived or cancelled requests are handled consistently.
Original PR description
Before this commit, some things were unclear. The mobile view was not working as expected and expired sign items were displayed in the thank you dialog. Refusing sign request would not cancel them.…
Before this commit, some things were unclear. The mobile view was not working as expected and expired sign items were displayed in the thank you dialog. Refusing sign request would not cancel them. Moreover this commit fix the sign tests. This commit aims to fix an issue with test_archived_requests_dont_send_reminders. Previously the test was trying to archive a record by performing a direct write command, but since we have a designated action for archiving sign requests, it should be used. Another issue is that when we archive a sign request, its state is set to 'canceled', and for canceled sign requests we cannont update the validity, however the test was trying to update the validity (as a way of jumping to the future). But this is not the correct way of doing it, since we shouldn't change the validity if state is canceled. To fix the issue, a mock_datetime_and_now is introduced. Note: this is the backport of https://github.com/odoo/enterprise/pull/73156 task: 4294860
This change ensures manufacturing work orders are marked as started before they are completed. It prevents an incorrect date sequence that could block users with an error when finishing work orders immediately.
Original PR description
As we immediatly call button_done on the wworkorder, the start_date is greater than the end_date which raises a user error. So we start the workorder before setting it to done
Code cleanup and technical improvements
The payroll work entry export process has been reorganized to make its data structures clearer and easier to maintain. This is an internal improvement that should help future updates for Belgian payroll export providers be safer and more consistent, without changing day-to-day user workflows.
Original PR description
This Refactor aims to make the work entry export more readable and easier to maintain by defining explicit classes for each work entry data structure with explicit way to use them defined by their respective classes task-4244397
Documentation and clarification updates
This pull request adds a signed individual contributor agreement for jamesbcn. It is an administrative legal update that helps confirm contribution eligibility and does not change product behavior.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
When our own bank is used as a payment means, it shouldn't be populated in the OIOUBL XML. When using Peppol, the XML would ignore the endpoint that is set in the electronic invoicing settings, the <cbc:EndpointID> should be the defined Peppol endpoint and the schemeID should be 'GLN'. task-4017019 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#171945
Original PR description
When our own bank is used as a payment means, it shouldn't be populated in the OIOUBL XML. When using Peppol, the XML would ignore the endpoint that is set in the electronic invoicing settings, the <cbc:EndpointID> should be the defined Peppol endpoint and the schemeID should be 'GLN'. task-4017019 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#171945
step to reproduce: 1. create a db in 16.0 with appointment and account_payment module 2. create ``User-defined default`` (ir_default): Settings -> Technical -> User-defined Defaults - Field = Unit of Measure (product.template) - Default Value (JSON format) = 3 (pick any id that is not in the same category as `uom.product_uom_unit`) 2. upgrade db to 17.0 version below mentioned traceback will raised because appointment_account_payment is auto install. ``` Traceback (most recent call last):
Original PR description
step to reproduce: 1. create a db in 16.0 with appointment and account_payment module 2. create ``User-defined default`` (ir_default): Settings -> Technical -> User-defined Defaults - Field = Unit of…
step to reproduce:
1. create a db in 16.0 with appointment and account_payment module
2. create ``User-defined default`` (ir_default): Settings -> Technical -> User-defined Defaults
- Field = Unit of Measure (product.template)
- Default Value (JSON format) = 3 (pick any id that is not in the same category as `uom.product_uom_unit`)
2. upgrade db to 17.0 version below mentioned traceback will raised because appointment_account_payment is auto install.
```
Traceback (most recent call last):
File "/home/odoo/src/odoo/17.0/odoo/service/server.py", line 1313, in preload_registries
registry = Registry.new(dbname, update_module=update_module)
File "<decorator-gen-16>", line 2, in new
File "/home/odoo/src/odoo/17.0/odoo/tools/func.py", line 87, in locked
return func(inst, *args, **kwargs)
File "/home/odoo/src/odoo/17.0/odoo/modules/registry.py", line 114, in new
odoo.modules.load_modules(registry, force_demo, status, update_module)
File "/home/odoo/src/odoo/17.0/odoo/modules/loading.py", line 480, in load_modules
processed_modules += load_marked_modules(env, graph,
File "/home/odoo/src/odoo/17.0/odoo/modules/loading.py", line 364, in load_marked_modules
loaded, processed = load_module_graph(
File "/home/odoo/src/odoo/17.0/odoo/modules/loading.py", line 227, in load_module_graph
load_data(env, idref, mode, kind='data', package=package)
File "/home/odoo/src/odoo/17.0/odoo/modules/loading.py", line 71, in load_data
tools.convert_file(env, package.name, filename, idref, mode, noupdate, kind)
File "/home/odoo/src/odoo/17.0/odoo/tools/convert.py", line 627, in convert_file
convert_xml_import(env, module, fp, idref, mode, noupdate)
File "/home/odoo/src/odoo/17.0/odoo/tools/convert.py", line 693, in convert_xml_import
obj.parse(doc.getroot())
File "/home/odoo/src/odoo/17.0/odoo/tools/convert.py", line 613, in parse
self._tag_root(de)
File "/home/odoo/src/odoo/17.0/odoo/tools/convert.py", line 556, in _tag_root
f(rec)
File "/home/odoo/src/odoo/17.0/odoo/tools/convert.py", line 567, in _tag_root
raise ParseError(msg) from None # Restart with "--log-handler odoo.tools.convert:DEBUG" for complete traceback
odoo.tools.convert.ParseError: while parsing /home/odoo/src/enterprise/17.0/appointment_account_payment/data/product_data.xml:8
The default Unit of Measure and the purchase Unit of Measure must be in the same category.
View error context:
'-no context-'
```
why this traceback is raised because here in default values of [``uom_po_id``](https://github.com/odoo/odoo/blob/834e8a8789d1d451f62ae1e841845baf7d3931a4/addons/product/models/product_template.py#L36) getting default value of uom_id due to that other catefory uom_id is coming and [validation](https://github.com/odoo/odoo/blob/834e8a8789d1d451f62ae1e841845baf7d3931a4/addons/product/models/product_template.py#L456)
error raised and db got blocked
opw-4313919
upg-2182151
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#187825
Forward-Port-Of: odoo/odoo#187663When modifying an existing order in the PoS the sales team would be unset. Steps to reproduce: ------------------- * Open a table and add some items to it * Leave the table and go back on it 2 times * Validate the order > Observation: Go on the sale report and group by sale team, your order will appear under the "None" section Why the fix: ------------ We make sure that when we write on the order we will the values of the crm team defined on the pos config opw-4232473 --- I co
Original PR description
When modifying an existing order in the PoS the sales team would be unset. Steps to reproduce: ------------------- * Open a table and add some items to it * Leave the table and go back on it 2 times * Validate the order > Observation: Go on the sale report and group by sale team, your order will appear under the "None" section Why the fix: ------------ We make sure that when we write on the order we will the values of the crm team defined on the pos config opw-4232473 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#184585
This re-adds the possibility for a user with approval rights, but no accounting rights to reset an expense to draft after it has been refused/approved. opw-4328933 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#187397
Original PR description
This re-adds the possibility for a user with approval rights, but no accounting rights to reset an expense to draft after it has been refused/approved. opw-4328933 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#187397
Description of the issue this PR addresses: Current behavior before PR: I. Pasting content within `blockquote` and `pre` elements resulted in each node being converted into separate `blockquote` or `pre` elements. II. When pasting the clipboard content as plain text (CTRL+SHIFT+V) inside a `PRE` element would convert each line break into a new paragraph. III. When text with a url is pasted within a pre tag the text is converted to a link. Desired behavior after PR is merged: I. `bl
Original PR description
Description of the issue this PR addresses: Current behavior before PR: I. Pasting content within `blockquote` and `pre` elements resulted in each node being converted into separate `blockquote` or…
Description of the issue this PR addresses: Current behavior before PR: I. Pasting content within `blockquote` and `pre` elements resulted in each node being converted into separate `blockquote` or `pre` elements. II. When pasting the clipboard content as plain text (CTRL+SHIFT+V) inside a `PRE` element would convert each line break into a new paragraph. III. When text with a url is pasted within a pre tag the text is converted to a link. Desired behavior after PR is merged: I. `blockquote` and `pre` should be considered like wrappers, allowing paragraph-related elements to be pasted inside them. II. When pasting the clipboard content as plain text within `pre`, every new line should be pasted within the `pre` tag. III. When text with a url is pasted within a pre tag it should not convert it to a link. IV. The `pre` tag does not have automatic word-wrapping or line-breaks as it is intended to keep the formatting of the text. This commit ensures that long text within `pre` tags does not overflow. task-4154465 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#187312 Forward-Port-Of: odoo/odoo#178965
When confirming a BILL via Project's Updates, the generated payment terms line will have the analytic account of the project assigned Version: 17.0+ Steps to reproduce: - Have a project (i.e. Renovations) - Create a Purchase Order - Add on the line the analytic account of the project - Go to Projects Kanban view - Open Project 3 dots menu > Reporting > Project Updates - Open the created PO, Create Bill Issue: Analytic account will be assigned to the payment term line opw-4193509
Original PR description
When confirming a BILL via Project's Updates, the generated payment terms line will have the analytic account of the project assigned Version: 17.0+ Steps to reproduce: - Have a project (i.e. Renovations) - Create a Purchase Order - Add on the line the analytic account of the project - Go to Projects Kanban view - Open Project 3 dots menu > Reporting > Project Updates - Open the created PO, Create Bill Issue: Analytic account will be assigned to the payment term line opw-4193509 Forward-Port-Of: odoo/odoo#187612
*: pos_sale, pos_loyalty, pos_restaurant, pos_event Before all lines was sent to the backend to be processed, if the backend had a line that wasn't sent by the frontend, it was removed from the order. Now the frontend sends only modified lines to the backend, if a line is deleted from the frontend, it will be deleted from the backend too. But the backend doesn't remove lines that weren't sent by the frontend. This change was made to avoid losing information when the backend delete a lin
Original PR description
*: pos_sale, pos_loyalty, pos_restaurant, pos_event Before all lines was sent to the backend to be processed, if the backend had a line that wasn't sent by the frontend, it was removed from the order. Now the frontend sends only modified lines to the backend, if a line is deleted from the frontend, it will be deleted from the backend too. But the backend doesn't remove lines that weren't sent by the frontend. This change was made to avoid losing information when the backend delete a line that wasn't sent by the frontend. Cherry-picked from bdd57e0576ad2c061494676325a26644a8427c5e Forward-Port-Of: odoo/odoo#187268
The aim of this PR is to reduce the number of queries executed when opening the Replenishment View of the Inventory module. The following ideas were implemented ### Usage of `filtered` instead of a continue inside compute functions. `filtered` sets the _prefetch_ids to the records that matches the condition. This reduces the size of the expanded recordset whose computed field value needs to be recomputed. ### Batch `orderpoint._quantity_in_progress` The method `_quantity_in_progress`
Original PR description
The aim of this PR is to reduce the number of queries executed when opening the Replenishment View of the Inventory module. The following ideas were implemented ### Usage of `filtered` instead of a…
The aim of this PR is to reduce the number of queries executed when opening the Replenishment View of the Inventory module.
The following ideas were implemented
### Usage of `filtered` instead of a continue inside compute functions.
`filtered` sets the _prefetch_ids to the records that matches the condition. This reduces the size of the expanded recordset whose computed field value needs to be recomputed.
### Batch `orderpoint._quantity_in_progress`
The method `_quantity_in_progress` is designed to be used on a recordset. Calling it once before the for loop in
`stock_orderpoint.py:_compute_qty_to_order_computed` speeds up the whole compute function.
### Introduce a rule cache in `orderpoint._compute_rules`
A product without stock.rules have no impact on the call to `product_id._get_rules_from_locations`. It's only used to search on stock.rule in `procurement.group._search_rule`. We can therefore partition the orderpoints between orderpoints whose products have and don't have route_ids. This saves calls to `product_id._get_rules_from_locations` because now it only depends on (orderpoint.location_id, orderpoint.route_id) which have more hits than (orderpoint.product_id, orderpoint.location_id, orderpoint.route_id).
### Add preliminary checks to `_compute_days_to_order`
In both mrp and purchase_stock, `_compute_days_to_order` does some computations when the rule_ids' action is 'manufacture' and 'buy' respectively. This forces the computation of rule_ids on all orderpoints in self. Adding some precheck and prefiltering on self reduces the size of the recordset that needs the value of rule_ids.
### Introduce `_search_rule_for_warehouses`
Introduce a new method, `_search_rule_for_warehouses`. It's kind of batched version of `_search_rule` that works for multiple
location_dest_ids and warehouse_ids. It is designed to be called by `_get_rule`.
This method uses a _read_group to group the stock.rules by (location_dest_id, warehouse_id, route_id). It then constructs
a dict mappin (location_dest_id, route_id) -> warehouse_id -> stock.rule. This is done because when bool(warehouse_id) in parameter is False, any existing rule matching the location_dest_id, route_id is fine. When bool(warehouse_id) in parameter is True, the candidate stock.rules.warehouse must be equal to the parameter or False.
`_get_rule` is also revamped to find the correct stock.rule among the candidates. It first goes through the location hierarchy, starting from location_id, to build the rule_domain. Then, using the result of `_search_rule_for_warehouses`, it goes through the hierarchy again in the while loop, breaking at the first valid stock.rule found.
`_search_rule` is kept as is in case of overriding.
----
### Benchmark:
Customer saas-17.4 database with 10 000 active orderpoints and 140 active stock.rules.
Requests when opening Replenishment: run + search_panel_select_range + web_search_read
#### Before PR:
Number of queries: 90569 + 90471 + 90497 = 271 352 queries
Timings: 1min30 + 2min40 + 1min30 = 5min40
#### After PR:
Number of queries: 36819 + 36744 + 36767 = 110 330 queries
Timings: 43s + 1min20s + 54s = 2min57
Queries reduction: 250%
Speedup: 192%
NB: Should this PR be merged, it will be backported to 17.0 with some modifications.
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#182407This PR fixes an issue about the pager buttons having a wrong `border-radius` in RTL languages. Prior to this PR, the icons were defined at the button level. On top of being unusual, this had a side-effect. In RTL languages, we use a CSS `transform: rotate(180deg);` on our directional icons,in order to flip their direction and match the RTL or LTR. While this works totally fine, having the icon sets on the button directly means the whole button will be flipped, meaning the border-radius wi
Original PR description
This PR fixes an issue about the pager buttons having a wrong `border-radius` in RTL languages. Prior to this PR, the icons were defined at the button level. On top of being unusual, this had a…
This PR fixes an issue about the pager buttons having a wrong `border-radius` in RTL languages. Prior to this PR, the icons were defined at the button level. On top of being unusual, this had a side-effect. In RTL languages, we use a CSS `transform: rotate(180deg);` on our directional icons,in order to flip their direction and match the RTL or LTR. While this works totally fine, having the icon sets on the button directly means the whole button will be flipped, meaning the border-radius will be inverted. To prevent this behaviour, we simply need to use a `<i/>` tag for both icons, which will allow them to be flipped without affecting the button design. | 17.0 | This PR | |--------|--------| | <img width="159" alt="image" src="https://github.com/user-attachments/assets/2afc13b3-0b4b-4baf-a306-2196a3c83867"> | <img width="159" alt="image" src="https://github.com/user-attachments/assets/a405e167-6a0f-4a49-a15d-4e36735d95f5"> | task-4345233 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#187741
## Problem: When generating sorting URLs, the `post` dictionary only contains a single selected attribute. This is due to `request.params` only passing the first `attrib` parameter during dispatch, even though there can be multiple. ## Solution: Modify the `post` dictionary to store attributes as a list before passing it to the `_shop_get_query_url_kwargs` method. This ensures that all selected attributes are preserved and properly passed to the `keep` query parameters. ## Steps to repro
Original PR description
## Problem: When generating sorting URLs, the `post` dictionary only contains a single selected attribute. This is due to `request.params` only passing the first `attrib` parameter during dispatch, even though there can be multiple. ## Solution: Modify the `post` dictionary to store attributes as a list before passing it to the `_shop_get_query_url_kwargs` method. This ensures that all selected attributes are preserved and properly passed to the `keep` query parameters. ## Steps to reproduce: - Go to `/shop`. - Apply multiple attribute filters (ensure more than one attribute is selected). - Change the sorting option. - Only the first selected attribute is applied in the filter. opw-4244895 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#187694 Forward-Port-Of: odoo/odoo#183927
The Turkish National Identification Number (NIN) consists of 11 digits in the format NNNNNNNNNNN where the last two digits are check digits. The Vergi Kimlik Numarasi (VKN) is a 10-digit number in the format NNNNNNNNNN. The Vergi Kimlik Numaras is the Turkish tax identification number used for businesses and certain foreign individuals. task: 4282883 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#187524 Forward
Original PR description
The Turkish National Identification Number (NIN) consists of 11 digits in the format NNNNNNNNNNN where the last two digits are check digits. The Vergi Kimlik Numarasi (VKN) is a 10-digit number in the format NNNNNNNNNN. The Vergi Kimlik Numaras is the Turkish tax identification number used for businesses and certain foreign individuals. task: 4282883 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#187524 Forward-Port-Of: odoo/odoo#185884
Steps to reproduce: - Calendar > New > Tick 'Recurrent' - 'Until' => 'Number of repetitions' or 'Forever' - Set meeting start time in 5 mins - Add reminder => Notification - 15 Minutes > Save The notification is not sent, this is due to the use of 'until' to fetch the last event date of recurrent meetings despite that field only being set if the recrrence type is 'End date'. We want to check that date to avoid sending notifications for past meetings, but 'Number of Repetitions' recursions
Original PR description
Steps to reproduce: - Calendar > New > Tick 'Recurrent' - 'Until' => 'Number of repetitions' or 'Forever' - Set meeting start time in 5 mins - Add reminder => Notification - 15 Minutes > Save The notification is not sent, this is due to the use of 'until' to fetch the last event date of recurrent meetings despite that field only being set if the recrrence type is 'End date'. We want to check that date to avoid sending notifications for past meetings, but 'Number of Repetitions' recursions use a count instead of a date, and 'Forever' obviously doesn't need a date. Using the meeting end date instead should do the trick since it will always be in the future at the moment we want to send the reminder and it should never go over the last event date since no meeting record will be created after the recurrence ends anyway. opw-4247282 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#187423
Description of the issue/feature this PR addresses: Updated the code to make sure that the context object includes the current context. This change makes it easier to use all the relevant context-specific info in the process. Current behavior before PR: Currently, it only adds the warehouse information to the context variable. Desired behavior after PR is merged: The context object will include the warehouse information and the current context, ensuring that all necessary context
Original PR description
Description of the issue/feature this PR addresses: Updated the code to make sure that the context object includes the current context. This change makes it easier to use all the relevant context-specific info in the process. Current behavior before PR: Currently, it only adds the warehouse information to the context variable. Desired behavior after PR is merged: The context object will include the warehouse information and the current context, ensuring that all necessary context data is properly included when making the call. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#187229 Forward-Port-Of: odoo/odoo#178546
`BLOCK` button in the workcenter blocking wizard should be in lowercase --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#187384
Original PR description
`BLOCK` button in the workcenter blocking wizard should be in lowercase --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#187384
When adding a rules in loyalty program that had a product set, if you try to refund an order containing this product you would get an error Steps to reproduce: ------------------- * Create a loyalty program with a rules that has product_ids set to any product. * Open PoS and make an order with the product set on the loyalty program * Validate the order * Try to refund the order > Observation: You get an error saying you cannot refund giftcards or eWallets Why the fix: -----------
Original PR description
When adding a rules in loyalty program that had a product set, if you try to refund an order containing this product you would get an error Steps to reproduce: ------------------- * Create a loyalty program with a rules that has product_ids set to any product. * Open PoS and make an order with the product set on the loyalty program * Validate the order * Try to refund the order > Observation: You get an error saying you cannot refund giftcards or eWallets Why the fix: ------------ This was happening because `trigger_product_ids` is related to `rule_ids.product_ids`. And when checking if a product is a giftcard or eWallet we first checked that `trigger_product_ids` was set. Now we only check the type of the program linked to a product. opw-4206226 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#187231 Forward-Port-Of: odoo/odoo#184319
fiscalyear_last_day and fiscalyear_last_month can be defined in order to use fiscal years not aligned on the civil calendar. In enterprise, it works fine (it's overridden there to add functionalities), however, community forgot to make use of these fields, even though they are declared in it. Forward-Port-Of: odoo/odoo#187645 Forward-Port-Of: odoo/odoo#187250
Original PR description
fiscalyear_last_day and fiscalyear_last_month can be defined in order to use fiscal years not aligned on the civil calendar. In enterprise, it works fine (it's overridden there to add functionalities), however, community forgot to make use of these fields, even though they are declared in it. Forward-Port-Of: odoo/odoo#187645 Forward-Port-Of: odoo/odoo#187250
The aim of this commit is to allow detection of tax report that still need to be send easily by putting back the tax report to be sent activity that was deleted by commit 7bace07feea5 It also make sure those activities exists before using them to ensure the feature works even without updating the module. Context: The deletion of that activity makes this detection much harder and removes the possibility to know if was sent or not. Before the commit: It is impossible to know if a tax re
Original PR description
The aim of this commit is to allow detection of tax report that still need to be send easily by putting back the tax report to be sent activity that was deleted by commit 7bace07feea5 It also make sure those activities exists before using them to ensure the feature works even without updating the module. Context: The deletion of that activity makes this detection much harder and removes the possibility to know if was sent or not. Before the commit: It is impossible to know if a tax report has been sent or not. After the commit: The tax report to be sent can be found easily by looking for the tax report to be sent activity. We can assume the tax report was sent once the activity has been deleted. task-id: 4292304 Forward-Port-Of: odoo/enterprise#73615
This PR aims to increase the contrast between the default and the `focus` state of our `btn-primary`. | 17.0 | This PR | |--------|--------| | <img width="729" alt="image" src="https://github.com/user-attachments/assets/19c29432-4467-46bf-b240-41017d435c09"> | <img width="717" alt="image" src="https://github.com/user-attachments/assets/1efc15cc-6e10-460b-9040-4088cf3a98e0"> | Prior to this PR, the color was not dark enough to grant enough visual feedback on focus. This can be solve quic
Original PR description
This PR aims to increase the contrast between the default and the `focus` state of our `btn-primary`. | 17.0 | This PR | |--------|--------| | <img width="729" alt="image" src="https://github.com/user-attachments/assets/19c29432-4467-46bf-b240-41017d435c09"> | <img width="717" alt="image" src="https://github.com/user-attachments/assets/1efc15cc-6e10-460b-9040-4088cf3a98e0"> | Prior to this PR, the color was not dark enough to grant enough visual feedback on focus. This can be solve quickly by tweaking the value directly. task-3382308 Forward-Port-Of: odoo/enterprise#71793
This re-adds the possibility for a user with approval rights, but no accounting rights to reset an expense to draft after it has been refused/approved. opw-4328933 Forward-Port-Of: odoo/enterprise#73902
Original PR description
This re-adds the possibility for a user with approval rights, but no accounting rights to reset an expense to draft after it has been refused/approved. opw-4328933 Forward-Port-Of: odoo/enterprise#73902
## [FIX] l10n_be_reports: 281.50 and exchange diff The aim of this commit is to prevent a Zero devision error by excluding irrelevant 'zeroed' exchange difference. Context: Some misc entry with a 0 balance and some amount_currency might be present and taken into account for the computation. Such moves have an `amount_total_signed` equal to 0 leading to the zeroDivisionError issue in the query computation. Before the commit: When having such entry considered by the query, creating th
Original PR description
## [FIX] l10n_be_reports: 281.50 and exchange diff The aim of this commit is to prevent a Zero devision error by excluding irrelevant 'zeroed' exchange difference. Context: Some misc entry with a 0 balance and some amount_currency might be present and taken into account for the computation. Such moves have an `amount_total_signed` equal to 0 leading to the zeroDivisionError issue in the query computation. Before the commit: When having such entry considered by the query, creating the 325.50 form leads to a traceback. After the commit: Those irrelevant moves are ignored and the process carry on smoothly. task-id: None - Issue spotted on next ## [FIX] l10n_be_reports: 281.50, no 0-0-0-0-0 form The aim of this commit is to avoid generating a 281.50 form if there isn't any amounts to fill in the form. task-id: None - Dicussed with TSB Forward-Port-Of: odoo/enterprise#74142 Forward-Port-Of: odoo/enterprise#73842
This commits makes the redirect button label mandatory when there is a specified redirect URL. It also improves the hiding of the redirect label field when there is no redirect URL specified. task-4174120 Forward-Port-Of: odoo/enterprise#74003 Forward-Port-Of: odoo/enterprise#69866
Original PR description
This commits makes the redirect button label mandatory when there is a specified redirect URL. It also improves the hiding of the redirect label field when there is no redirect URL specified. task-4174120 Forward-Port-Of: odoo/enterprise#74003 Forward-Port-Of: odoo/enterprise#69866
### Steps to reproduce: - Create a delivery order for 5 units of a product - Scan 1 unit and click on the pencil icon to edit the record further - On the digipad access the backend (for instance by clicking the external link arrow next to the location). - Come back to the record #### > The line now displayed a 1/1 but does not records what remains: 0/4. ### Cause of the Issue: Setting a quantity of 1 on the move line will trigger a write call on the related stock move line to update
Original PR description
### Steps to reproduce: - Create a delivery order for 5 units of a product - Scan 1 unit and click on the pencil icon to edit the record further - On the digipad access the backend (for instance by…
### Steps to reproduce: - Create a delivery order for 5 units of a product - Scan 1 unit and click on the pencil icon to edit the record further - On the digipad access the backend (for instance by clicking the external link arrow next to the location). - Come back to the record #### > The line now displayed a 1/1 but does not records what remains: 0/4. ### Cause of the Issue: Setting a quantity of 1 on the move line will trigger a write call on the related stock move line to update its quantity. However, when you leave the barcode, even thought it will save these change, it will not split the move in 2 for the barcode app to be able to rely on the backend data to generate a correct sate of the record. Threfore, when you come back to the record, the main component will be regenerated from the backend values of the `get_barcode_data`: https://github.com/odoo/enterprise/blob/7b28f4bbd3c20559e529c3134e5b65b089b78806/stock_barcode/static/src/components/main.js#L76-L80 And will onlydisplay the "1/1" line that was reported fromt he back end. ### Fix: The `split_uncompleted_moves` method taking care of splitting the moves for barcode data compatibility: https://github.com/odoo/enterprise/blob/7b28f4bbd3c20559e529c3134e5b65b089b78806/stock_barcode/models/stock_move.py#L9-L11 is already called when you exit the barcode via the exit button: https://github.com/odoo/enterprise/blob/7b28f4bbd3c20559e529c3134e5b65b089b78806/stock_barcode/static/src/components/main.js#L228-L231 https://github.com/odoo/enterprise/blob/7b28f4bbd3c20559e529c3134e5b65b089b78806/stock_barcode/static/src/models/barcode_picking_model.js#L762-L765 These were added by commit 2eb6465e4f18c701efdf28ea4b8f95f3119d3db8 However, it should IMO be called every time you leave the app that is just before destroying the component. Furthermore, note that it will only split the moves if a save happend (which is the expacted behavior). opw-4232106 --- Forward-Port-Of: odoo/enterprise#73664 Forward-Port-Of: odoo/enterprise#72453
### Steps to reproduce: - Create a product with a bom and an operation op1 - Create and confirm an MO for 1 unit of that product - Go to the shopfloor > on the operation > 3 dots > Add component - Add a component to be consumed in that operation #### > While the componenet was correctly added to the MO and linked to the WO it is not visible on hte shopfloor. ### Cause of the issue: The only moves that are visible on "MrpDisplayRecord"'s are the move that are in `manual_consumption = T
Original PR description
### Steps to reproduce: - Create a product with a bom and an operation op1 - Create and confirm an MO for 1 unit of that product - Go to the shopfloor > on the operation > 3 dots > Add component -…
### Steps to reproduce: - Create a product with a bom and an operation op1 - Create and confirm an MO for 1 unit of that product - Go to the shopfloor > on the operation > 3 dots > Add component - Add a component to be consumed in that operation #### > While the componenet was correctly added to the MO and linked to the WO it is not visible on hte shopfloor. ### Cause of the issue: The only moves that are visible on "MrpDisplayRecord"'s are the move that are in `manual_consumption = True` see: https://github.com/odoo/enterprise/blob/88a092acd261db8f3a8ee1f0cf8174c3d7089472/mrp_workorder/static/src/mrp_display/mrp_display_record.js#L188-L191 However, when a product is added via the `action_add_component` > `add_product`, the `manual_consumption` of the move is computed as if it was added to the MO without being linked to a `bom_line_id`: https://github.com/odoo/enterprise/blob/88a092acd261db8f3a8ee1f0cf8174c3d7089472/mrp_workorder/wizard/additional_product.py#L36-L46 https://github.com/odoo/odoo/blob/2d652f42f63c2501b1a9feb7a4830ea3d7d05f51/addons/mrp/models/mrp_production.py#L1198 As a result the move_raw is added as a manual_consumption = False. ### Note: Thank to Commit eb751b5f861b25205dbb0b0fb90ddcdbbcd10f55 , the issue is not reproducible in 18.0 anymore. This was soved in the same manner: https://github.com/odoo/enterprise/blob/2a0ccbe7058f8d4383a63ed1897945bec3a1cec3/mrp_workorder/models/mrp_production.py#L36-L38 https://github.com/odoo/enterprise/blob/2a0ccbe7058f8d4383a63ed1897945bec3a1cec3/mrp_workorder/models/mrp_production.py#L107-L114 opw-4199156 Forward-Port-Of: odoo/enterprise#72569 Forward-Port-Of: odoo/enterprise#71803