Daily updates from Odoo
Thursday, December 5, 2024
6 changes · saas-17.4
Resolved issues and error corrections
This update brings Odoo’s spreadsheet component up to the latest maintenance version and fixes several issues affecting spreadsheet interactions. It improves reliability for action buttons, sheet naming, and pivot-related calculations, helping users avoid errors in day-to-day spreadsheet work.
Original PR description
### Contains the following commits: https://github.com/odoo/o-spreadsheet/commit/9b13f22de [REL] 17.4.15 Task: 0 https://github.com/odoo/o-spreadsheet/commit/992622618 [FIX] action button: use nextProps instead of this.props Task: 0 https://github.com/odoo/o-spreadsheet/commit/06b13c9fd [FIX] helpers: Add generic helper to sanitize sheet names Task: 4347719 https://github.com/odoo/o-spreadsheet/commit/094335658 [FIX] pivot: handle boolean-like function arguments in `getPivotCellFromPosition` Task: 4207502 Co-authored-by: Anthony Hendrickx (anhe) <anhe@odoo.com> Co-authored-by: Alexis Lacroix (laa) <laa@odoo.com> Co-authored-by: Lucas Lefèvre (lul) <lul@odoo.com> Co-authored-by: Dhrutik Patel (dhrp) <dhrp@odoo.com> Co-authored-by: Adrien Minne (adrm) <adrm@odoo.com> Co-authored-by: Mehdi Rachico (mera) <mera@odoo.com> Co-authored-by: Rémi Rahir (rar) <rar@odoo.com> Co-authored-by: Pierre Rousseau (pro) <pro@odoo.com> Co-authored-by: Vincent Schippefilt (vsc) <vsc@odoo.com>
Fixes an issue where imported pricelists could ignore percentage markups on cost-based pricing rules. This ensures sales quotations use the intended marked-up prices after pricelists are exported and re-imported.
Original PR description
Versions -------- - saas-17.4+ Steps ----- 1. Create a pricelist; 2. add a rule using a cost-based formula; 3. add a 50% markup; 4. export pricelist, then delete or archive it; 5. import pricelist;…
Versions -------- - saas-17.4+ Steps ----- 1. Create a pricelist; 2. add a rule using a cost-based formula; 3. add a 50% markup; 4. export pricelist, then delete or archive it; 5. import pricelist; 6. use pricelist on a quotation. Issue ----- The markup isn't applied. Cause ----- Commit 06d0053763cd added the `price_markup` field to `product.pricelist.item`. Whenever the markup is set/changed, the `price_discount` field is supposed to get set to its negative value. Currently this only happens in an `onchange` method, which does not get called during import: https://github.com/odoo/odoo/blob/9905de54a55b6d77f67772dde7b2d0ea21adaff1/addons/product/models/product_pricelist_item.py#L322-L325 The value of `price_discount` is what eventual price calculations are based on, so if this isn't updated along with `price_markup`, any price mark-up gets ignored. Solution -------- Ensure `price_markup` & `price_discount` are consistent with each other on using `_compute_price_markup` and `_inverse_price_markup`. opw-4282087
Miscellaneous changes
Currently, when using a language that translates the abbreviation of quarters (Q) to anything else, the formula `=filter.value(...)` would return the translated version, which then could not be used on other formulas like `=odoo.balance`, this can be observed by opening the Finance/accounting dashboard while in french and selecting a filter in quarter. After this fix, the formula filter.value will always return Q1 to Q4 for quarter names. Task: 4274741 --- I confirm I have signed
Original PR description
Currently, when using a language that translates the abbreviation of quarters (Q) to anything else, the formula `=filter.value(...)` would return the translated version, which then could not be used on other formulas like `=odoo.balance`, this can be observed by opening the Finance/accounting dashboard while in french and selecting a filter in quarter. After this fix, the formula filter.value will always return Q1 to Q4 for quarter names. Task: 4274741 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#187140 Forward-Port-Of: odoo/odoo#187043
Versions -------- - 16.0+ Steps ----- 1. Schedule the "Calendar: Event Reminder" to run once a day; 2. create an event that started 2 hours ago, and ended 1 hour ago; 3. run the event reminder cron. Issue ----- A reminder email is sent, event though the event has passed. Cause ----- The alarm manager doesn't check whether the reminders it sends are still relevant. Solution -------- When looking querying events to send reminders for, ensure their `stop` date is before the
Original PR description
Versions -------- - 16.0+ Steps ----- 1. Schedule the "Calendar: Event Reminder" to run once a day; 2. create an event that started 2 hours ago, and ended 1 hour ago; 3. run the event reminder cron. Issue ----- A reminder email is sent, event though the event has passed. Cause ----- The alarm manager doesn't check whether the reminders it sends are still relevant. Solution -------- When looking querying events to send reminders for, ensure their `stop` date is before the current time. opw-4191612 Forward-Port-Of: odoo/odoo#189479 Forward-Port-Of: odoo/odoo#189340
Since commit [1], a new option was added to set the text color of the navbar in "over the content" mode. However, this option also affects the text color of the "mobile navbar", which it should not. This commit fixes the issue by stopping the "over the content" text color from applying to the mobile navbar. Steps to reproduce: - Enter "Website" edit mode. - Click on the "header". - Set the "Header Position" option to "Over The Content". - Select a "red" color in the colorpicker of the "
Original PR description
Since commit [1], a new option was added to set the text color of the navbar in "over the content" mode. However, this option also affects the text color of the "mobile navbar", which it should not. This commit fixes the issue by stopping the "over the content" text color from applying to the mobile navbar. Steps to reproduce: - Enter "Website" edit mode. - Click on the "header". - Set the "Header Position" option to "Over The Content". - Select a "red" color in the colorpicker of the "Navbar" option. - Click the "Mobile Preview" button. - Click the "Hamburger menu" button to open the mobile navbar. - Bug: The text color is not "red". [1]: https://github.com/odoo/odoo/commit/1e30600d9e0e12e43fcbca60760a64f2551e3c8f opw-4364765 Forward-Port-Of: odoo/odoo#189417
LNE Certification (scales certification) requires not to be able to reboot the IoT Box with a simple button. We removed it from the homepage. Enterprise PR: [https://github.com/odoo/enterprise/pull/75074](https://github.com/odoo/enterprise/pull/75074) Task: 4345731 Forward-Port-Of: odoo/odoo#189644 Forward-Port-Of: odoo/odoo#189467
Original PR description
LNE Certification (scales certification) requires not to be able to reboot the IoT Box with a simple button. We removed it from the homepage. Enterprise PR: [https://github.com/odoo/enterprise/pull/75074](https://github.com/odoo/enterprise/pull/75074) Task: 4345731 Forward-Port-Of: odoo/odoo#189644 Forward-Port-Of: odoo/odoo#189467