Daily updates from Odoo
Tuesday, December 10, 2024
6 changes · 17.0
Resolved issues and error corrections
This update resolves a warning message appearing in payment receipts for Mexican invoices. The fix addresses an issue with how PyPDF2 handles XML data, preventing errors during CFDI generation. This ensures payment receipts are consistently produced without technical disruptions.
Original PR description
**Steps to reproduce:** - Make sure that PyPDF2 is in version 1.26.0 - Install l10n_mx_edi - Switch to a Mexican company - Create an invoice: * Customer: [a Mexican customer] * Payment Way:…
**Steps to reproduce:**
- Make sure that PyPDF2 is in version 1.26.0
- Install l10n_mx_edi
- Switch to a Mexican company
- Create an invoice:
* Customer: [a Mexican customer]
* Payment Way: [Effectivo]
* An invoice line with a product having a UNSPSC Category
- Confirm the invoice
- Generate CFDI via "Send & Print" button
- Register a payment with "Efectivo" Payment Way
- Update Payments on the invoice
- Go to the payment
- Force CFDI
- Make sure the CFDI status of the payment is "Signed"
- Print "Payment Receipt"
**Issue:**
PyPDF2 raises a traceback:
"IndexError: list index out of range".
**Cause:**
PyPDF2 is executing this code to format a warning: file = filename.replace("/", "\\").rsplit("\\", 1)[1] where filename is something liked "<xxx>" (coming from the qweb compilation). Therefore, there is no index 1.
The warning is coming from lxml and is due to the fact that we are evaluating a xml value as it is in a qweb template:
"FutureWarning: Use specific 'len(elem)' or 'elem is not None' test instead." And since this commit:
https://github.com/odoo/odoo/commit/fd67b56fc695526d09706d2b6218519ea255fc30 Python's "warning.py" is overridden in PyPDF2.
**Solution:**
Use "len(cfdi['cfdi_node'])" as advised to check if the xml node has children in the payment receipt template.
opw-4359466
opw-4366016This update resolves an issue where appointment templates weren't consistently rendering correctly. The fix ensures the website appointment template no longer relies on updates to the underlying appointment module, guaranteeing stable template rendering across Odoo versions. This improves the user experience for appointment scheduling.
Original PR description
Versions -------- - 17.0 - saas-17.2 - saas-17.4 - 18.0 Steps ----- 1. Install appointment pre efd76940c999; 2. install website post efd76940c999. Issue ----- Template rendering issue. Cause ----- The commit added a xpath to website_appointment relying on an updated appointment module, which isn't always the case in stable. Solution -------- Make the xpath in website_appointment not rely on the appointment change. opw-4394557
This update resolves intermittent errors that prevented the documents access rights tour from completing successfully. The fix involves adding a check to ensure the page correctly transitions between companies before the tour finishes, improving the user experience and reliability of this onboarding feature. The issue was identified through automated testing and addressed with a targeted code change.
Original PR description
backport of pr-s [68962](https://github.com/odoo/enterprise/pull/68962) and [68770](https://github.com/odoo/enterprise/pull/68770). broken runbot builds are [here](https://runbot.odoo.com/web#id=60274&menu_id=424&cids=1&action=573&model=runbot.build.error&view_type=form) Added an extra trigger, that will check that the page has properly changed from one company to another, and to let this page to load before finishing the tour.
This update resolves a bug where users managing appraisals without specific group access were unable to view appraisal feedback. The fix ensures that users with manager roles for an appraisal can correctly access the feedback, regardless of their group membership. This improves usability and prevents workflow disruptions for managers.
Original PR description
To reproduce: ============= - assign a user U without any group access to Appraisal app as manager of an appraisal - login as this user U and ask for feedback on the appraisal - fill the feedback, and change it's deadline to the past - try to consult the answers as user U -> redirected to survey expired error page Problem: ======== the access to appraisal feedback is checked based on the user's group access, but the user can be the manager of the appraisal without any group access to the appraisal app Solution: ========= in addition to the group access, check if the user is the manager of the appraisal opw-4354685
This update fixes a visual issue in the mobile and form views of Odoo where long checkbox labels would overlap with the checkboxes themselves. Now, checkbox labels and checkboxes are properly aligned, ensuring a cleaner and more user-friendly experience. This improves readability and usability for users.
Original PR description
`*` = [sale_subscription] Before this commit: In the mobile and form view, when a checkbox field had a long label, the checkbox would appear on top, with the label text displayed below. After this commit: In the mobile and form view, checkbox fields with long labels are now properly aligned, with the checkbox and label text displayed. Task-4269578
This update fixes a display issue in the General Ledger report where the table overflowed, causing the right side of the page to be cut off. The fix addresses a problem with a column width that was too wide, ensuring the report is fully visible and readable. This improves the user experience when generating and reviewing financial reports.
Original PR description
Steps to reproduce ================== - Install account_accountant,l10n_ch_reports - Use the CH company - Create a new chart of account 12345 "Current Account Abcdgraph Labs 12345 Pvt Ltd" - Create a new customer "Abcdefghijklm Abcdefghijklm 1234" - Create and post a new journal entry for journal 12345 - Go to the General Ledger - Print the ledger => The right side of the page is cut off Cause of the issue ================== The column containing account is too wide and the table overflows the body  opw-4286133