Tuesday, December 10, 2024
2 changes · 17.0
Resolved issues and error corrections
This update resolves an issue where appointment templates weren't consistently rendering correctly. The fix ensures the website appointment template no longer relies on updates to the underlying appointment module, guaranteeing stable template rendering across Odoo versions. This improves the user experience for appointment scheduling.
Original PR description
Versions -------- - 17.0 - saas-17.2 - saas-17.4 - 18.0 Steps ----- 1. Install appointment pre efd76940c999; 2. install website post efd76940c999. Issue ----- Template rendering issue. Cause ----- The commit added a xpath to website_appointment relying on an updated appointment module, which isn't always the case in stable. Solution -------- Make the xpath in website_appointment not rely on the appointment change. opw-4394557
This update resolves a bug where users managing appraisals without specific group access were unable to view appraisal feedback. The fix ensures that users with manager roles for an appraisal can correctly access the feedback, regardless of their group membership. This improves usability and prevents workflow disruptions for managers.
Original PR description
To reproduce: ============= - assign a user U without any group access to Appraisal app as manager of an appraisal - login as this user U and ask for feedback on the appraisal - fill the feedback, and change it's deadline to the past - try to consult the answers as user U -> redirected to survey expired error page Problem: ======== the access to appraisal feedback is checked based on the user's group access, but the user can be the manager of the appraisal without any group access to the appraisal app Solution: ========= in addition to the group access, check if the user is the manager of the appraisal opw-4354685