Wednesday, December 11, 2024
9 changes
5 changes
Resolved issues and error corrections
Sales users without Settings or administrator rights can now open quotation templates that include quote builder headers or footers. This prevents access errors and lets sales teams use configured quote layouts without needing elevated permissions.
Original PR description
Problem: When users with no Settings/Admin rights attempt to access the header/footers of the quote builder, an access error is thrown because they have no access to the private attachments. Purpose: Users with access to Sales should have access to the headers/footers to use the quote builder. To resolve the bug, the header/footer attachments needs to have both res_model and res_id of the quotation documents. Steps to Reproduce on Runbot: 1. Install Sales 2. Log in as admin and create a quotation template with a header attached in the quote builder 3. Log in as a demo user with no setting rights but is a sales admin 4. Navigate to a quotation template with headers attached --> access error opw-4318572 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix makes sales order lines use their own warehouse when deciding whether items should be supplied on demand. It prevents incorrect procurement or delivery planning when a line uses a different warehouse than the overall sales order.
Original PR description
…on sale.order.line Description of the issue/feature this PR addresses: Since v18.0, the warehouse_id field on sale.order.line is now computed. Before v18.0, the field was related to the warehouse of the order (order_id.warehouse_id). Current behavior before PR: The method _compute_is_mto() is still referencing the warehouse of the order instead of the warehouse of the line. As a result, in cases where the warehouse of the line differs from that of the order, the is_mto value may be incorrect. Desired behavior after PR is merged: The is_mto value should be computed based on the warehouse of the line, not the order. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update fixes several business-impacting issues across accounting, CRM lead assignment, tax reporting, and the web interface. It helps prevent incorrect tax report entries, removes blockers in accounting cut-off workflows, ensures older CRM leads can still be manually assigned, and makes PDF and error handling behavior clearer for users.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixed an issue where the Documents Email Links page showed a blank page when creating or opening an email link. Users can now manage document-related email links without being blocked by an empty screen.
Original PR description
Steps to reproduce: 1. Go to Configuration > Email Links 2. click on New -> Blank page 3. click on a record -> Blank page Technical Reason: passed an empty form view and the id got overwritten because of the same name. After this commit: - form view will be open - 'documents.document' related aliases here Task-4265660
Several spreadsheet formulas in the accounting dashboards were corrected so they point to the right data and use the proper calculation signs. This helps ensure dashboard figures are consistent and accurate for financial reporting and analysis.
4 changes
Resolved issues and error corrections
This update fixes an issue where the initial balance in reports was incorrectly using outdated exchange rates. The change ensures all financial calculations, including the initial balance, now utilize the most current exchange rate available, leading to more accurate reporting. This improves the reliability of financial data.
Original PR description
### Steps to reproduce the issue: 1. Create two Companies, one in EUR, the other in USD 2. In EUR Company, create two Invoices with the following settings: - Total price of 1000 - Invoice date: today…
### Steps to reproduce the issue:
1. Create two Companies, one in EUR, the other in USD
2. In EUR Company, create two Invoices with the following settings:
- Total price of 1000
- Invoice date: today and one month ago
- You must be able to isolate them using Partner Ledger filters (not date)
3. In USD Company, add EUR Rates as follows:
- Today: 1USD = 1EUR
- One month ago: 1USD = 0.9EUR
4. In USD Company, open General Ledger and isolate the Invoices
5. First, set the timeframe from beginning last month to end of this month
6. The Invoice of last month is using the current rate, with an amount of 1000$
7. Second, set the timeframe to the current month only
8. The Initial Balance is using the previous rate, with an amount of 1111.11$
### Explanation:
The initial balance is the balance of the company before the start of the currently reviewed timeframe. To calculate it, we must update the options to target the time before the current timeframe. Since we retrieve the rate used for this calculation using the updated options, we use the last rate before the current timeframe instead of the rate used in the current timeframe.
### Fix reasoning:
Since every amount must be calculated using the current rate, we will retrieve it using the main options and not the updated ones.
opw-4299153This fix resolves an issue where order tracking notifications were being sent to all displays, leading to potential notification overload. By creating unique notification topics based on display access tokens, we now ensure notifications are delivered only to the intended preparation displays, aligning with upcoming version changes. This improves notification efficiency and clarity.
Original PR description
Reverting:
* https://github.com/odoo/enterprise/commit/4c6c902651ad48b1064f1eb4eb326fa773b6b098
* https://github.com/odoo/enterprise/commit/aa264a24091be85bb9983ef2c2aded1e505828b6
We found a way to be coherent with the behavior of the next versions. In the next version the status screen can be used without being synchronized on orders.
The problem before the first fix was that the notifications were send to all traking displays.
`bus_service.addChannel(pos_tracking_display-${session.preparation_display.access_token});` The bus will listen to all topics broadcasted on the given channel.
`subscribe("NEW_ORDERS")` listens for any "NEW_ORDER" topic across ALL the channels the bus is subscribed to. So if another channel also broadcast "NEW_ORDERS", it will also execute.
We now use the `access_token` to create unique topics. Only notifications explicitly addressed to this unique topics are now handled.
opw-4265987This update ensures that Odoo's Mexican VAT (SAT) reporting functionality accurately reflects the required account code format (XXX.XX.XX) and prefix rules. Previously, several default accounts were incorrectly configured, causing errors when generating the SAT-compliant COA XML file. This fix corrects these account codes, resolving potential issues with uploading to the SAT and ensuring accurate reporting.
Original PR description
Original task: 4288080 Related PR: 187476 # Background In Mexico, all accounts need to follow a pattern XXX.XX.XX or XXX.XX.XXX where additionally the first five digits must belong to a list of…
Original task: 4288080 Related PR: 187476 # Background In Mexico, all accounts need to follow a pattern XXX.XX.XX or XXX.XX.XXX where additionally the first five digits must belong to a list of prefixes published by the SAT. At the moment, several accounts created by default don't match the CoA pattern: - 999000001 Cash Difference Gain - 999000002 Cash Difference Loss. - 999300000 Cash Discount Loss - 999400000 Cash Discount Gain - 999999 Undistributed Profits/Losses This issue is related to the Trial Balance Report (download COA SAT) for Mexican localization when some accounts are not correctly configured. For users that request the COA SAT XML file for the first time no warning/error is thrown but the client will face some errors when uploading the file to the SAT because the accounts are not configured properly; When the COA SAT XML file has already been downloaded then a warning error blocks the action. # Fix Given correct codes to the existing accounts and modifying data for some records: --- | Account | New code | New name | New Account type | |-------------------------------------|-----------|------------------------------------------------------------------------------|------------------| | 999000001 Cash Difference Gain | 403.01.01 | Other Income | ~ | | 999000002 Cash Difference Loss | 601.84.02 | ~ | ~ | | 999300000 Cash Discount Loss | 402.01.01 | Returns, discounts or bonuses over sales and/or services at the general rate | other income | | 999400000 Cash Discount Gain | 503.01.01 | Returns, discounts or bonuses over purchases | ~ | | 999999 Undistributed Profits/Losses | 305.01.01 | Uncut Result | ~ | --- --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update allows accountants to manage products directly through Customer Invoices and Vendor Bills, addressing a previous limitation. The fix adds a necessary access right to the product database, enabling accountants to fully utilize product management features within the accounting module. This improves efficiency and data accuracy for accounting workflows.
Original PR description
**Issue:** Accountants cannot create products through Customer Invoice or Vendor Bill product lines. …
**Issue:** Accountants cannot create products through Customer Invoice or Vendor Bill product lines.  **Expected:** Accountants should be allowed to manage the products database. **Steps to reproduce:** - Activate Accounting app; - Configure a branch to the company; - Create a user with an accounting `Accounting` role and set the branch company as only entry in Allowed Companies and as Default Company;  - Log in as that new user; - Try create a new product through a Customer Invoice or a Vendor Bill. **Cause:** The `Accountants` role itself has no right on products. **Fix:** Add a new access right on `product_template` for group `group_account_manager`.  opw-4293151