Daily updates from Odoo
Wednesday, December 11, 2024
20 changes
1 change
Resolved issues and error corrections
This fix adjusts how online store stock-related product option code is loaded so that the right behavior is applied consistently. It helps prevent custom product variant logic from being skipped due to file loading order, reducing the risk of incorrect storefront behavior.
Original PR description
### Current behavior before PR: While working on this https://github.com/odoo/enterprise/pull/74813/commits/337ea18baebdf4c896bc3e503448207fd9095991 we were overriding a method in VariantMixin but it was shadowed and not executed this was happening because of the order JS is loading the files when importing website_sale. ### Desired behavior after PR is merged: After discussing with XBO, we are removing the import of website_sale from variant_mixin.js and moving the overridden method to website_sale.js to avoid having this problem in the future.
3 changes
Resolved issues and error corrections
The Moroccan reports module now lets users manually edit the Payment Channel value even though it is calculated automatically. This fixes cases where the automatically suggested payment channel needs correction, improving reporting accuracy without workarounds.
Original PR description
Upgrade PR: https://github.com/odoo/upgrade/pull/6842 task-4226448
The appointment website test now creates the data it needs during the test instead of relying on preloaded demo data. This helps keep automated checks stable across environments and reduces the risk of false failures during releases.
Original PR description
With this PR [1](https://github.com/odoo/enterprise/pull/72612), without demo data tour(test_searchbar_within_appointments) was failing, so required data created on the fly. runbot: 109512
This update restores expected behavior in Documents and Marketing Automation after a shared technical change affected kanban views. Users should see more reliable document selection and proper confirmation prompts when deleting parent marketing activities.
Original PR description
The documents and marketing_automation apps previously used some information in the "list" prop that was removed in favor of a optional field "groupByField" for simplification purposes. See changes introduced by https://github.com/odoo/odoo/pull/189109 and https://github.com/odoo/enterprise/pull/74863 Now we only use the "selection" prop of the list for documents and the code to display the confirmation message when deleting parent activities is moved in the HierarchyKanbanRenderer with the help of the deleteRecord function. task-4377706
12 changes
Resolved issues and error corrections
Call participants in Discuss are now sorted using the correct available name information. This prevents ordering issues in the call sidebar, making participant lists more reliable during conversations.
Original PR description
Before this commit, and since [1], the call participants in the side bar were sorted by `nameOrDisplayName` which is not available and should be using `name`. [1]: https://github.com/odoo/odoo/pull/174965
This fixes a visual issue in the Discuss sidebar where the last public channel icon could appear cropped. The icon sizing was adjusted so channels display cleanly, improving the user experience without changing functionality.
Original PR description
**Current behavior before PR:** In the discuss sidebar, the last public channel icon appears cropped due to insufficient width and height. **Desired behavior after PR is merged:** The issue is resolved by little adjusted height and width of the icons, this ensures the last public channel icon displays correctly without cropping. Before / after   task-4354447 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Badges now avoid showing an unintended grey background by default, making labels look cleaner and more consistent. An unsupported styling class was also replaced with a supported one to keep the interface aligned with the current design framework.
Original PR description
Before this commit: - Previously, the badge displayed a default background color of grey. After this commit: - The badge should not display a default background color. - The `text-bg-muted` class, which is not supported in Bootstrap 5, has been replaced with `text-bg-secondary`. task-4247109 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Sales users without Settings or administrator rights can now open quotation templates that include quote builder headers or footers. This prevents access errors and lets sales teams use configured quote layouts without needing elevated permissions.
Original PR description
Problem: When users with no Settings/Admin rights attempt to access the header/footers of the quote builder, an access error is thrown because they have no access to the private attachments. Purpose: Users with access to Sales should have access to the headers/footers to use the quote builder. To resolve the bug, the header/footer attachments needs to have both res_model and res_id of the quotation documents. Steps to Reproduce on Runbot: 1. Install Sales 2. Log in as admin and create a quotation template with a header attached in the quote builder 3. Log in as a demo user with no setting rights but is a sales admin 4. Navigate to a quotation template with headers attached --> access error opw-4318572 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix makes sales order lines use their own warehouse when deciding whether items should be supplied on demand. It prevents incorrect procurement or delivery planning when a line uses a different warehouse than the overall sales order.
Original PR description
…on sale.order.line Description of the issue/feature this PR addresses: Since v18.0, the warehouse_id field on sale.order.line is now computed. Before v18.0, the field was related to the warehouse of the order (order_id.warehouse_id). Current behavior before PR: The method _compute_is_mto() is still referencing the warehouse of the order instead of the warehouse of the line. As a result, in cases where the warehouse of the line differs from that of the order, the is_mto value may be incorrect. Desired behavior after PR is merged: The is_mto value should be computed based on the warehouse of the line, not the order. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue in the HTML editor where selecting a single empty table cell with the mouse did not show the editing toolbar. Users can now access formatting options consistently when working with table cells, reducing friction during content editing.
Original PR description
**Before this PR:** When trying to select single empty cell using mouse, toolbar is not getting opened. The reason is that `updateToolbar` gets called from mouseup event in `toolbar_plugin` but it fails to open toolbar because `shouldBeVisible` method returns false if selection is collapsed. **Behaviour after PR:** Now toolbar gets opened when selecting single empty cell. task-4316754 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Products linked to purchase order lines can no longer be deleted while still in use. This prevents errors when users open the forecast report for purchase orders that reference those products.
Original PR description
This error occurs when a product is used in a purchase order, but the product is subsequently removed or deleted from the product list, and then an attempt is made to access it in the forecast report. Steps to reproduce: --- - Install ``purchase_stock`` module - Create a new purchase order and create a new product in the purchase order line(eg: Test) - Now go to products and delete the product(eg: Test) - Now in the purchase order line click on the ``Forecast Report`` button Traceback: --- ``ValueError: Expected singleton: product.product()`` This commit resolves the error by adding the ``ondelete`` constraint to the ``product_id`` field. This ensures that a product in use cannot be deleted. sentry-6121903860 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update fixes several business-impacting issues across accounting, CRM lead assignment, tax reporting, and the web interface. It helps prevent incorrect tax report entries, removes blockers in accounting cut-off workflows, ensures older CRM leads can still be manually assigned, and makes PDF and error handling behavior clearer for users.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The stop-timer timesheet dialog now displays the trash button at the same height as the other action buttons. This provides a cleaner, more consistent experience when users stop a running task timer.
Original PR description
Before this commit, the trash button displayed in the wizard used when the user clicks on stop button in a task (when a timer is running on that task for that current user) has not the same height than the other buttons displayed in that wizard. This commit makes sure the button has the same height than the other buttons. task-4382070
Fixed an issue where the Documents Email Links page showed a blank page when creating or opening an email link. Users can now manage document-related email links without being blocked by an empty screen.
Original PR description
Steps to reproduce: 1. Go to Configuration > Email Links 2. click on New -> Blank page 3. click on a record -> Blank page Technical Reason: passed an empty form view and the id got overwritten because of the same name. After this commit: - form view will be open - 'documents.document' related aliases here Task-4265660
Employee departures by mutual agreement now use the departure date entered in the wizard to start the notice period, instead of automatically moving it to the next Monday. This helps Belgian payroll users calculate departure-related dates more accurately and consistently with the agreed leaving date.
Original PR description
- make the start_notice_period take the wizard departure_date instead of next monday in case of having `mutual agreement` the departure reason Task: 4373961
Several spreadsheet formulas in the accounting dashboards were corrected so they point to the right data and use the proper calculation signs. This helps ensure dashboard figures are consistent and accurate for financial reporting and analysis.
4 changes
Resolved issues and error corrections
This update fixes an issue where the initial balance in reports was incorrectly using outdated exchange rates. The change ensures all financial calculations, including the initial balance, now utilize the most current exchange rate available, leading to more accurate reporting. This improves the reliability of financial data.
Original PR description
### Steps to reproduce the issue: 1. Create two Companies, one in EUR, the other in USD 2. In EUR Company, create two Invoices with the following settings: - Total price of 1000 - Invoice date: today…
### Steps to reproduce the issue:
1. Create two Companies, one in EUR, the other in USD
2. In EUR Company, create two Invoices with the following settings:
- Total price of 1000
- Invoice date: today and one month ago
- You must be able to isolate them using Partner Ledger filters (not date)
3. In USD Company, add EUR Rates as follows:
- Today: 1USD = 1EUR
- One month ago: 1USD = 0.9EUR
4. In USD Company, open General Ledger and isolate the Invoices
5. First, set the timeframe from beginning last month to end of this month
6. The Invoice of last month is using the current rate, with an amount of 1000$
7. Second, set the timeframe to the current month only
8. The Initial Balance is using the previous rate, with an amount of 1111.11$
### Explanation:
The initial balance is the balance of the company before the start of the currently reviewed timeframe. To calculate it, we must update the options to target the time before the current timeframe. Since we retrieve the rate used for this calculation using the updated options, we use the last rate before the current timeframe instead of the rate used in the current timeframe.
### Fix reasoning:
Since every amount must be calculated using the current rate, we will retrieve it using the main options and not the updated ones.
opw-4299153This fix resolves an issue where order tracking notifications were being sent to all displays, leading to potential notification overload. By creating unique notification topics based on display access tokens, we now ensure notifications are delivered only to the intended preparation displays, aligning with upcoming version changes. This improves notification efficiency and clarity.
Original PR description
Reverting:
* https://github.com/odoo/enterprise/commit/4c6c902651ad48b1064f1eb4eb326fa773b6b098
* https://github.com/odoo/enterprise/commit/aa264a24091be85bb9983ef2c2aded1e505828b6
We found a way to be coherent with the behavior of the next versions. In the next version the status screen can be used without being synchronized on orders.
The problem before the first fix was that the notifications were send to all traking displays.
`bus_service.addChannel(pos_tracking_display-${session.preparation_display.access_token});` The bus will listen to all topics broadcasted on the given channel.
`subscribe("NEW_ORDERS")` listens for any "NEW_ORDER" topic across ALL the channels the bus is subscribed to. So if another channel also broadcast "NEW_ORDERS", it will also execute.
We now use the `access_token` to create unique topics. Only notifications explicitly addressed to this unique topics are now handled.
opw-4265987This update ensures that Odoo's Mexican VAT (SAT) reporting functionality accurately reflects the required account code format (XXX.XX.XX) and prefix rules. Previously, several default accounts were incorrectly configured, causing errors when generating the SAT-compliant COA XML file. This fix corrects these account codes, resolving potential issues with uploading to the SAT and ensuring accurate reporting.
Original PR description
Original task: 4288080 Related PR: 187476 # Background In Mexico, all accounts need to follow a pattern XXX.XX.XX or XXX.XX.XXX where additionally the first five digits must belong to a list of…
Original task: 4288080 Related PR: 187476 # Background In Mexico, all accounts need to follow a pattern XXX.XX.XX or XXX.XX.XXX where additionally the first five digits must belong to a list of prefixes published by the SAT. At the moment, several accounts created by default don't match the CoA pattern: - 999000001 Cash Difference Gain - 999000002 Cash Difference Loss. - 999300000 Cash Discount Loss - 999400000 Cash Discount Gain - 999999 Undistributed Profits/Losses This issue is related to the Trial Balance Report (download COA SAT) for Mexican localization when some accounts are not correctly configured. For users that request the COA SAT XML file for the first time no warning/error is thrown but the client will face some errors when uploading the file to the SAT because the accounts are not configured properly; When the COA SAT XML file has already been downloaded then a warning error blocks the action. # Fix Given correct codes to the existing accounts and modifying data for some records: --- | Account | New code | New name | New Account type | |-------------------------------------|-----------|------------------------------------------------------------------------------|------------------| | 999000001 Cash Difference Gain | 403.01.01 | Other Income | ~ | | 999000002 Cash Difference Loss | 601.84.02 | ~ | ~ | | 999300000 Cash Discount Loss | 402.01.01 | Returns, discounts or bonuses over sales and/or services at the general rate | other income | | 999400000 Cash Discount Gain | 503.01.01 | Returns, discounts or bonuses over purchases | ~ | | 999999 Undistributed Profits/Losses | 305.01.01 | Uncut Result | ~ | --- --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update allows accountants to manage products directly through Customer Invoices and Vendor Bills, addressing a previous limitation. The fix adds a necessary access right to the product database, enabling accountants to fully utilize product management features within the accounting module. This improves efficiency and data accuracy for accounting workflows.
Original PR description
**Issue:** Accountants cannot create products through Customer Invoice or Vendor Bill product lines. …
**Issue:** Accountants cannot create products through Customer Invoice or Vendor Bill product lines.  **Expected:** Accountants should be allowed to manage the products database. **Steps to reproduce:** - Activate Accounting app; - Configure a branch to the company; - Create a user with an accounting `Accounting` role and set the branch company as only entry in Allowed Companies and as Default Company;  - Log in as that new user; - Try create a new product through a Customer Invoice or a Vendor Bill. **Cause:** The `Accountants` role itself has no right on products. **Fix:** Add a new access right on `product_template` for group `group_account_manager`.  opw-4293151