Wednesday, December 18, 2024
19 changes
2 changes
Resolved issues and error corrections
A minor issue in Documents Spreadsheet tests was corrected so negative filter offsets are handled as a complete value instead of being checked character by character. This prevents unnecessary console warnings and helps keep testing output clean and reliable.
Original PR description
In unit tests, when global filter offsets are added with negative values, we have a warning in the console saying that the symbol '-' cannot be parsed. The reason behind the warning is that the input element triggers an onChange event whenever a new character is added. The commit fixes this issue by setting the option `instantly` to true to only trigger the onChange with the whole new value. task-4397783
A broken internal test for subscriptions was removed because it referred to functionality that no longer exists. This prevents unnecessary test failures and helps keep future updates more reliable without changing customer-facing behavior.
Original PR description
File was added unimported in #72347, and tries to test things related to a model `sale.order.alert` removed in #70180 (merged two weeks earlier).
12 changes
Resolved issues and error corrections
The mail sub-channel search panel now stays within the visible browser area more reliably. This prevents automated checks from failing in newer Chrome versions or watch mode, improving confidence in mail interface stability without changing user workflows.
Original PR description
Before this PR, the `test_04_sub_channel_panel_search` test was always failing when chrome version is greater than 123 or in watch mode. This occurs because the sub channel search panel is overflowing, falsing the assertion related to the thread being scrolled to the bottom. The search panel popover is restricted to `Min(100vh, 500px)` which does not take into account the space between the top of the window and the popover. This PR fixes the issue by reducing the vh allowed for the popover in order to keep it visible as much as possible.
5 changes
Resolved issues and error corrections
A previous error occurred when creating planning slots due to missing calendar information for resources. This update corrects the code to handle cases where a resource doesn't have a working calendar, preventing a traceback and ensuring planning slots can be created successfully. This improves the reliability of the planning module.
Original PR description
Currently a traceback is occurring when there is no working time (calendar_id) in resource, while creating a planning slot. To reproduce this issue: 1) Install planning 2) Open any planning slot in…
This update makes an automated test for collaborative editing more reliable by waiting until the text selection is fully updated before checking it. It helps prevent false test failures, improving confidence in future releases without changing the user experience.
Original PR description
The test introduced in [1] is failing undeterministically. Since the selection update somtimes takes more time than what is expected, we change it waituntil the selection is correct. 109367 [1]: https://github.com/odoo/odoo/pull/179742
This update fixes an accounting test so it works even when only the Accounting app is installed. It reduces false test failures caused by assumptions about optional payment methods from other apps, helping keep releases more reliable.
Original PR description
Don't rely on other modules adding payment methods without an account, it should run with `account` only installed. runbot-106384
Printing receipts from Point of Sale no longer produces an unwanted blank page. This saves paper and reduces confusion for cashiers and customers when issuing receipts.
Original PR description
An extra blank page was being printed when printing the receipt from the POS.
Adding
```
.pos-receipt {
contain: paint;
background-color: transparent;
}
```
to the receipt_screen.scss file fixes the issue.
opw-4292890The emoji button in the Mail text field now appears in the correct place instead of being pushed too far into the form. This prevents overlap with other interface elements and makes emoji use more consistent for users.
Original PR description
The emoji button in the text field was misaligned. Appearing too far in the form view. This led to the emoji being overlapped by other components. The fix consists in : - Added a 'position-absolute' to the button for correct alignement - Updated the parent container to 'position:relative' in the css for correct positioning. This fix addresses a user interface bug and ensures consistent emoji positioning/display. opw-4332574 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix makes Argentine withholding calculations more reliable when registering payments, especially when several payment records are processed together. It also ensures that “today” follows the user’s local date, helping avoid date-related errors in payment workflows.
Original PR description
A few things were wrong: * a compute function needs to take into account multiple records. It can happen even on wizards i.e. in tests because fields are flushed together * `fields.Date.from_string` is deprecated and useless * "Today" needs to take into account the locale of the user runbot-98546
This fixes a redundant validation step when opening the payment registration flow. The same check still happens later as part of preparing the payment wizard, reducing unnecessary failures while preserving existing safeguards.
Original PR description
Remove the check done in `action_force_register_payment` because it will be done anyway when computing the default values for opening the wizard. runbot-105675
Email marketing editors will no longer offer the option to add videos, which are not supported in mass mailing emails. This prevents users from creating campaign content that may not display or work correctly for recipients.
Original PR description
**Problem**: Videos are not supported in email marketing, yet the powerbox allows users to add videos. **Solution**: Disable the option to add videos when editing email templates in mass_mailing. **Steps to reproduce**: 1. Create a new email template. 2. Open the powerbox. 3. Observe that the option to add videos is available. opw-4395333 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The online shop now shows only the tags linked to the selected product variant instead of mixing in tags from other variants. This helps customers see accurate product information and avoids confusion when comparing or choosing variants.
Original PR description
Steps to reproduce: ------------------ - Set a product tags for a specific variant - Go to the shop - All the tags of all product variant are displayed Issue: ----- While displaying the tags the tags does not take into account the current product. This results in the display of all the tags of all variant instead of the tags of the specific one. Fix: ---- task-4357477 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update corrects an accounting test so it behaves properly when only the Community Edition is installed. It helps keep automated checks reliable and avoids false failures that could slow down future accounting fixes.
Original PR description
* If only using Odoo CE, this test will fail because action_force_register_payment will raise usererror like 'you can only ...' which will not match the expected out come Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes a display issue where the email template editor's fullscreen mode could appear hidden behind a pop-up window. Users editing email automation templates can now use fullscreen editing without the workspace being obscured.
Original PR description
Issue: ====== When we toggle the full screen mode it's displayed under the modal. Steps to reproduce the issue: ============================= - Install email automation - Create a new one (commercial prospection) - Click on offer free catalog to open the modal - Click on the internal link on the right of mail template - Toggle full screen mode of the snippets editor - The editing area is under the modal Origin of the issue: ==================== When we toggle the full screen mode we add the class `o_form_fullscreen_ancestor` which will add `z-index:zindex-modal-backdrop + 1` which is bascially putting the iframe under the modal. Solution: ========= Update the `z-index` to put the iframe and the snippets on top of the modal opw-4318011
German DATEV exports now remove line breaks from accounting entry descriptions by replacing them with spaces. This prevents invalid export files when descriptions contain multi-line text, helping businesses share accounting data more reliably.
Original PR description
In the datev export, we cannot use any linebreak. But in the aml name you could have some, to fix this we just replace any linebreak by a simple space task: 4358246
Currently a traceback is occurring when there is no working time (calendar_id) in resource, while creating a planning slot. To reproduce this issue: 1) Install planning 2) Open any planning slot in Gantt view and redirect to resource from the slot 3) Remove the Working Time of that resource 4) Now try to create a new planning slot for that resource from Gantt view Error:- ``` ValueError: Expected singleton: resource.calendar() ``` Here, `calendar_id` is not required in the resource. So, when the user removes the calendar_id from the resource and tries to create a new planning slot, it leads to the above traceback. In the below line, we try to get calendar_d from the resource if it is available. https://github.com/odoo/enterprise/blob/7847510dc6ad8dec73f01470714aacb0c3510769/planning/models/planning.py#L611-L612 We can resolve this issue by taking calendar_id from the company as it is required. If it fails to get the value from the resource. sentry-6150920391
A bug was preventing users from accessing documents after archiving the default 'Projects' workspace. This update prevents archiving of the projects workspace, resolving the error and ensuring proper document access. This change improves the stability and usability of the documents application.
Original PR description
Steps to reproduce ================== - Archive default "Projects" workspace - Create a new Project - Create a task and attach a file - Click on the smart button to view the document - Go back to the home menu and open the documents app => `Cannot read properties of undefined (reading 'id')` Solution ======== Prevent the archiving of the projects workspace opw-4308132
This update resolves a compatibility problem in the Account Accountant module. It addresses an error that occurs when the Account module isn't updated alongside the Account Accountant module. The fix adds a temporary field to ensure proper functionality until the Account module is updated.
Original PR description
Scenario: - install account without commit (eg. before 3 december 2024): odoo/odoo@d413a9895742594d064084cd6dafbf1f2ec97221 - install account_accountant with commit (eg. after 3 december 2024):…
Scenario:
- install account without commit (eg. before 3 december 2024): odoo/odoo@d413a9895742594d064084cd6dafbf1f2ec97221
- install account_accountant with commit (eg. after 3 december 2024): e4111ac8f817f97b3d6128453659a1014b6db00f
=> Traceback with odoo.tools.convert.ParseError: while parsing
account_accountant/views/product_views.xml:3
Field 'is_coa_installed' used in attrs
({'invisible': [('is_coa_installed', '=', False)]}) must be present
in view but is missing.
Cause:
The change in account_accountant
(e4111ac8f817f97b3d6128453659a1014b6db00f) relies on the change in account (odoo/odoo@d413a9895742594d064084cd6dafbf1f2ec97221) but account_accountant can be installed/updated without updating account.
Fix:
Add a duplicate is_coa_installed field in account_accountant useful if account module is not up to date.
opw-4323694
note: only useful up to saas-17.2, in saas-17.4 the field is automatically added if it's necessary for an attribute.
pr note: issue found when working on an unrelated ticket
Forward-Port-Of: odoo/enterprise#75490This update addresses a technical issue preventing the correct generation of TNT manifest PDFs when using Starshipit in Australia. While the core problem isn't fully resolved, the fix allows stock picking to be marked as 'Done' with tracking number and link visibility for users. The manifest PDF itself remains unavailable.
Original PR description
If Starshipit is configured with TNT service (Australia), the API does not return a pdf field for `orders/manifest` endpoint. This causes the transfer validation process to fail in Odoo. This fix does not resolve the core problem, but it will allow the stock picking to be marked as "Done", with tracking number and link available to the user. The downside is that the manifest PDF will not be available Task: 4195503
This update ensures Odoo correctly identifies the company's currency when synchronizing bank accounts. This is crucial for accurate testing and integration with financial institutions, resolving a previous issue that could lead to incorrect account data. It primarily impacts the account synchronization process.
Original PR description
This commit updates the process to pass the company's currency code to the `_get_accounts` route. By doing so, the server can accurately identify the company's currency. This change is particularly important for supporting testing banks. task-4293992 Forward-Port-Of: odoo/enterprise#75372