Wednesday, December 18, 2024
33 changes
1 change
Resolved issues and error corrections
Product searches in sales orders now work by product name as well as internal reference. This makes it easier for users to find the right products quickly and reduces search-related friction during order entry.
Original PR description
Version: saas-17.2 Before this fix, the `_name_search` method only supported searching by `default_code`. Issue: It seems to be an issue with product-wise searches in sales orders. Fix: Added `|` operator to the search domain for `name` in `_name_search`. This improves the product search functionality and ensures better user experience when searching for products. opw-4211232
3 changes
Resolved issues and error corrections
A minor issue in Documents Spreadsheet tests was corrected so negative filter offsets are handled as a complete value instead of being checked character by character. This prevents unnecessary console warnings and helps keep testing output clean and reliable.
Original PR description
In unit tests, when global filter offsets are added with negative values, we have a warning in the console saying that the symbol '-' cannot be parsed. The reason behind the warning is that the input element triggers an onChange event whenever a new character is added. The commit fixes this issue by setting the option `instantly` to true to only trigger the onChange with the whole new value. task-4397783
20 changes
Resolved issues and error corrections
This fixes issues in Point of Sale where scale readings on the customer-facing display could fail, show outdated net weight, or remain visible after a weighing was cancelled. It helps restaurant and retail staff avoid confusing customers and prevents errors when switching views without an active order.
Original PR description
Since #176062, the customer display is able to mirror the scale measurements. This commit fixes some bugs with this feature: - A traceback when no order is selected (this can happen when returning to the plan view in a restaurant) - The net weight not updating correctly on the customer display - The scale values remaining on the customer display indefinitely if weighing is cancelled opw-4343571, opw-4343559 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
1 change
Resolved issues and error corrections
This update resolves a bug where deferred tax dates weren't correctly synchronized between invoice and tax lines. The fix ensures that tax line dates are accurately updated when invoice deferred dates are removed, preventing data inconsistencies. This improves the reliability of tax calculations and reporting.
Original PR description
Product lists and searches have been adjusted so large product catalogs load much faster. This improves day-to-day responsiveness for businesses managing very high volumes of products, without changing the core product workflow.
Original PR description
For performance reasons: - the is_favorite field is moved from the model's _order to the related tree & kanban views - on product.product it is now a stored related to product.template From nim-odoo survey on a database containing more than 1 million products - stored related field & index: improvement in all cases (2500ms => 500 ms) - limit order & adapt views: name search will be fast (~2 ms)
A broken internal test for subscriptions was removed because it referred to functionality that no longer exists. This prevents unnecessary test failures and helps keep future updates more reliable without changing customer-facing behavior.
Original PR description
File was added unimported in #72347, and tries to test things related to a model `sale.order.alert` removed in #70180 (merged two weeks earlier).
The mail sub-channel search panel now stays within the visible browser area more reliably. This prevents automated checks from failing in newer Chrome versions or watch mode, improving confidence in mail interface stability without changing user workflows.
Original PR description
Before this PR, the `test_04_sub_channel_panel_search` test was always failing when chrome version is greater than 123 or in watch mode. This occurs because the sub channel search panel is overflowing, falsing the assertion related to the thread being scrolled to the bottom. The search panel popover is restricted to `Min(100vh, 500px)` which does not take into account the space between the top of the window and the popover. This PR fixes the issue by reducing the vh allowed for the popover in order to keep it visible as much as possible.
Orders placed at a self-order kiosk and paid at the counter are now sent to the preparation display as soon as they are created. This helps staff see and prepare kiosk orders promptly, reducing missed orders or delays.
Original PR description
*: pos_online_payment_self_order When creating an order from the kiosk and pay it at the counter, it should be sent to PDIS when creating it. opw-4364309
This update makes an automated test for collaborative editing more reliable by waiting until the text selection is fully updated before checking it. It helps prevent false test failures, improving confidence in future releases without changing the user experience.
Original PR description
The test introduced in [1] is failing undeterministically. Since the selection update somtimes takes more time than what is expected, we change it waituntil the selection is correct. 109367 [1]: https://github.com/odoo/odoo/pull/179742
This update fixes an accounting test so it works even when only the Accounting app is installed. It reduces false test failures caused by assumptions about optional payment methods from other apps, helping keep releases more reliable.
Original PR description
Don't rely on other modules adding payment methods without an account, it should run with `account` only installed. runbot-106384
Printing receipts from Point of Sale no longer produces an unwanted blank page. This saves paper and reduces confusion for cashiers and customers when issuing receipts.
Original PR description
An extra blank page was being printed when printing the receipt from the POS.
Adding
```
.pos-receipt {
contain: paint;
background-color: transparent;
}
```
to the receipt_screen.scss file fixes the issue.
opw-4292890The emoji button in the Mail text field now appears in the correct place instead of being pushed too far into the form. This prevents overlap with other interface elements and makes emoji use more consistent for users.
Original PR description
The emoji button in the text field was misaligned. Appearing too far in the form view. This led to the emoji being overlapped by other components. The fix consists in : - Added a 'position-absolute' to the button for correct alignement - Updated the parent container to 'position:relative' in the css for correct positioning. This fix addresses a user interface bug and ensures consistent emoji positioning/display. opw-4332574 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Partner records now use country-specific labels when warning about duplicate tax IDs or company registry numbers, making messages easier to understand. Morocco also gets stricter ICE number validation and duplicate warnings, while Australia and New Zealand receive clearer company registry labels.
Original PR description
* Add custom tax ID and company registry labels for warning messages to partners with the same tax ID/company registry. * Add custom company registry label for AU and NZ * Make sure the ICE number has 15 digits otherwise show an error message. * Move ICE to be below the Tax ID field. task-4226448 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix makes Argentine withholding calculations more reliable when registering payments, especially when several payment records are processed together. It also ensures that “today” follows the user’s local date, helping avoid date-related errors in payment workflows.
Original PR description
A few things were wrong: * a compute function needs to take into account multiple records. It can happen even on wizards i.e. in tests because fields are flushed together * `fields.Date.from_string` is deprecated and useless * "Today" needs to take into account the locale of the user runbot-98546
This fixes a redundant validation step when opening the payment registration flow. The same check still happens later as part of preparing the payment wizard, reducing unnecessary failures while preserving existing safeguards.
Original PR description
Remove the check done in `action_force_register_payment` because it will be done anyway when computing the default values for opening the wizard. runbot-105675
Customers using a website tied to a company branch could hit an access error when adding branch-specific products to their cart. The fix ensures tax filtering can correctly handle company branch relationships, preventing failed cart actions for public or restricted users.
Original PR description
Scenario: - create a company branch, with a website and a product for that branch - add that product to a cart from that website branch with a user that only has that branch in its allowed companies…
Scenario: - create a company branch, with a website and a product for that branch - add that product to a cart from that website branch with a user that only has that branch in its allowed companies (eg. public user) => an AccessError is raised because we can't read "parent_id" of parent company when passing in method account.tax()._filter_taxes_by_company Note: The error doesn't happen if the product is not in the company, because then we will check access rules which will set the parent res.company record in the cache, so no access error happen. Fix: Add sudo in account.tax()._filter_taxes_by_company method. The sudo could be put on company_id argument by the calling method (eg. 4 calls in website_sale) but it's hard to know that sudo is necessary since it works in a lot of case by chance because the res.company records are already in cache. Note: added test fails with odoo.exceptions.AccessError because we try to read "parent_id" of the branch company. opw-4282334
Email marketing editors will no longer offer the option to add videos, which are not supported in mass mailing emails. This prevents users from creating campaign content that may not display or work correctly for recipients.
Original PR description
**Problem**: Videos are not supported in email marketing, yet the powerbox allows users to add videos. **Solution**: Disable the option to add videos when editing email templates in mass_mailing. **Steps to reproduce**: 1. Create a new email template. 2. Open the powerbox. 3. Observe that the option to add videos is available. opw-4395333 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes two issues in the HTML editor: Ctrl-clicking a link now opens it in a new tab, and internal Odoo links now show the correct preview instead of a warning. This makes editing linked content smoother and reduces confusing error messages for users.
Original PR description
**Problem**: 1. `Ctrl+click` on a link in the editor does not open the link in a new tab. 2. Internal links with the format `odoo/<model>/<record_id>` do not display a proper preview. Instead, a…
**Problem**: 1. `Ctrl+click` on a link in the editor does not open the link in a new tab. 2. Internal links with the format `odoo/<model>/<record_id>` do not display a proper preview. Instead, a warning toaster appears: _"Action `<model>` not found, link preview is not available. Please check your URL is correct."_ **Solution**: 1. Implement the same code as version 17.0 to handle `ctrl+click` for opening links in a new tab: https://github.com/odoo/odoo/commit/981290ee9c88ea00440268d2a7b829d3a601a2d2 2. For internal links (`odoo/<model>/<record_id>`), validate the `action_name` as a model name. If valid, treat `action_name` as the model name for the link preview. **Steps to reproduce**: 1. Open the editor. 2. Add a link with the path `odoo/project.task/59`. 3. Try `Ctrl+click`: - **Issue**: The link does not open in a new tab. 4. Observe the warning toaster: _"Action project.task not found, link preview is not available. Please check your URL is correct."_ opw-4353235 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The online shop now shows only the tags linked to the selected product variant instead of mixing in tags from other variants. This helps customers see accurate product information and avoids confusion when comparing or choosing variants.
Original PR description
Steps to reproduce: ------------------ - Set a product tags for a specific variant - Go to the shop - All the tags of all product variant are displayed Issue: ----- While displaying the tags the tags does not take into account the current product. This results in the display of all the tags of all variant instead of the tags of the specific one. Fix: ---- task-4357477 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update corrects an accounting test so it behaves properly when only the Community Edition is installed. It helps keep automated checks reliable and avoids false failures that could slow down future accounting fixes.
Original PR description
* If only using Odoo CE, this test will fail because action_force_register_payment will raise usererror like 'you can only ...' which will not match the expected out come Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes a display issue where the email template editor's fullscreen mode could appear hidden behind a pop-up window. Users editing email automation templates can now use fullscreen editing without the workspace being obscured.
Original PR description
Issue: ====== When we toggle the full screen mode it's displayed under the modal. Steps to reproduce the issue: ============================= - Install email automation - Create a new one (commercial prospection) - Click on offer free catalog to open the modal - Click on the internal link on the right of mail template - Toggle full screen mode of the snippets editor - The editing area is under the modal Origin of the issue: ==================== When we toggle the full screen mode we add the class `o_form_fullscreen_ancestor` which will add `z-index:zindex-modal-backdrop + 1` which is bascially putting the iframe under the modal. Solution: ========= Update the `z-index` to put the iframe and the snippets on top of the modal opw-4318011
German DATEV exports now remove line breaks from accounting entry descriptions by replacing them with spaces. This prevents invalid export files when descriptions contain multi-line text, helping businesses share accounting data more reliably.
Original PR description
In the datev export, we cannot use any linebreak. But in the aml name you could have some, to fix this we just replace any linebreak by a simple space task: 4358246
Orders created at a self-order kiosk and paid at the counter are now sent to the preparation display as soon as they are created. This helps kitchen or preparation staff see these orders promptly and reduces the risk of missed or delayed preparation.
Original PR description
When creating an order from the kiosk and pay it at the counter, it should be sent to PDIS when creating it. opw-4364309
The Moroccan reporting export now makes it possible to identify partners that are missing required ICE or Tax ID details when preparing XML reports. This helps users correct partner records more easily and reduces export issues caused by incomplete tax information.
Original PR description
* From OXP feedback, there was no way to view partners with missing ICE/Tax ID when exporting reports as XML. * Fix ICE numbers in tests. task-4226448
Fixes an error that could stop Australian ABA batch payments from being validated. The payment process now uses the correct payment description field, allowing vendor batch payments to proceed normally.
Original PR description
**Steps to reproduce:** - Install l10n_au_aba - Switch to an Australian company (e.g. AU Company) - Configure batch payments according to fiscal localization docs in Odoo (https://www.odoo.com/documentation/18.0/applications/finance/fiscal_localizations/australia.html#aba-files-for-batch-payments) - Configure a bank account for a vendor - Create a bill for that vendor - Confirm the bill - Register a payment with "ABA Credit Transfer" as payment method - Go to the payments list - Select the created payment and create a batch payment - Validate the batch payment **Issue:** A traceback is raised while trying to access "ref" field of "account.payment" model. **Cause:** "ref" field has been replaced by "memo" field in "account.payment" model. opw-4346794 opw-4355394
Steps to reproduce: 1) Via Studio, modify the 'Journal Items' tab to add 'Start date' and 'End date' to the list view 2) Create a purchase tax 3) Create a bill with the tax created in the previous…
Steps to reproduce: 1) Via Studio, modify the 'Journal Items' tab to add 'Start date' and 'End date' to the list view 2) Create a purchase tax 3) Create a bill with the tax created in the previous step 4) Select deferred dates in the future 5) Check the journal items (two lines with deferred dates) 6) Go back to the 'Invoice lines' tab, delete the deferred dates and check the journal items again => one line still present the deferred dates!! Reason: When removing the `deferred_start_date` and the `deferred_end_date` from the invoice line, the newly computed `tax_key` for the tax line(s) will not have the `deferred_start_date` and the `deferred_end_date` fields, by [_get_deferred_tax_key](https://github.com/odoo-dev/enterprise/blob/c2c3a8591b3a5dfa402acb981564e46e0ff4ced9/account_accountant/models/account_move.py#L582). However, since when updating the tax line(s), we merge the old values with the new values (obtained in part from the before mentioned updated key), by this code in [_sync_dynamic_line](https://github.com/odoo/odoo/blob/f3d3e0c612392f1a35b9c131d29b4f3bd70a9d36/addons/account/models/account_move.py#L2599-L2602), and since the new key values of the tax line(s) does not have the `deferred_start_date` and the `deferred_end_date` explicitly set to `False`, and since the old key values have those fields set, merging new values with the old values will keep the old `deferred_start_date` and the `deferred_end_date`, resulting in a mismatch between the deferred dates on the invoice line and the tax lines. Fix: Now, `_get_deferred_tax_key` explicitly set `deferred_start_date` and the `deferred_end_date` to `False` when `tax_repartition_line_id ` is defined, to make sure they override any old `deferred_start_date` and the `deferred_end_date` existing in the old keys. opw-4328465