Odoo Changelog — 2024-12-24

Tuesday, December 24, 2024

2 changes · 17.0

Bug Fixes(2)

Resolved issues and error corrections

[FIX] website_helpdesk: properly allow to create helpdesk menus

Enterprise17.0website_helpdeskMEDIUM

This update corrects a broken process where website menus linked to helpdesk teams were incorrectly visible to public users. The fix resolves multiple coding errors that caused unintended behavior and potential visibility issues. The team is now preventing users from adding helpdesk URLs to website menus, streamlining the process.

Original PR description

Since [1], this flow is broken:

1. Install website_helpdesk => You have a "Help" menu with an helpdesk team as url (/helpdesk/customer-care-1) which is created

2. Check: if you publish or unpublish your team, that menu is visible or invisible as a public user.

3. Create a new menu for your website, with that same URL (/helpdesk/customer-care-1)

4. Check: that menu is always invisible as a public user. Even if you remove the first menu.

Multiple mistakes were made with [1]:

- The website menu visibility override code was added twice in two different files.

- The override advertises that this is for "always showing the helpdesk team menus even if they are unpublished" but it is actually meant to be the exact opposite of that.

- The implementation is based on the menu that are linked to the helpdesk teams, not on their URL **.

- The implementation actually bypass the normal visibility computation for all menu URL that start with "/helpdesk", meaning a custom page "/helpdesk-hello" from the user is just broken, so as existing controllers not linked to an helpdesk team (such as /helpdesk/rating).

**: actually this could mean that this feature is just not meant to be given the current state of the codebase: creating a menu with a team URL should just make it so it is forcefully linked to that team or should be prevented if it cannot (?).

[1]: https://github.com/odoo/enterprise/commit/a888fb57ebd2458bc8479e187088cb2e96b811fa

opw-3931376

#helpdesk#website#menus

[FW][FIX] industry_fsm_stock: removed check availability on service products

PR #75757

Enterprise17.0industry_fsm_stock

This update removes a confusing display option for service products within the product catalog. Previously, users could see 'View Availability,' which wasn't relevant for service products. This change simplifies the user experience and ensures users only see options that apply to their needs.

Original PR description

Steps to reproduce:
-------------

- Install Sales, Field Service, and Stock,
- Go into Field service and open any task that has products.
- Through stat button on the top access the product catalog.
- Click on burger menu on any service type product.

Issue:

- View Availability option should not be shown for service type products

Cause:

- No condition to make it invisible.

Solution:

- Added a condition when product type is service to the option invisible.

task-3801551

Forward-Port-Of: odoo/enterprise#58817

#field service#service products#availability

Since [1], this flow is broken: 1. Install website_helpdesk => You have a "Help" menu with an helpdesk team as url (/helpdesk/customer-care-1) which is created 2. Check: if you publish or unpublish your team, that menu is visible or invisible as a public user. 3. Create a new menu for your website, with that same URL (/helpdesk/customer-care-1) 4. Check: that menu is always invisible as a public user. Even if you remove the first menu. Multiple mistakes were made with [1]: - The website menu visibility override code was added twice in two different files. - The override advertises that this is for "always showing the helpdesk team menus even if they are unpublished" but it is actually meant to be the exact opposite of that. - The implementation is based on the menu that are linked to the helpdesk teams, not on their URL **. - The implementation actually bypass the normal visibility computation for all menu URL that start with "/helpdesk", meaning a custom page "/helpdesk-hello" from the user is just broken, so as existing controllers not linked to an helpdesk team (such as /helpdesk/rating). **: actually this could mean that this feature is just not meant to be given the current state of the codebase: creating a menu with a team URL should just make it so it is forcefully linked to that team or should be prevented if it cannot (?). [1]: https://github.com/odoo/enterprise/commit/a888fb57ebd2458bc8479e187088cb2e96b811fa opw-3931376

Steps to reproduce: ------------- - Install Sales, Field Service, and Stock, - Go into Field service and open any task that has products. - Through stat button on the top access the product catalog. - Click on burger menu on any service type product. Issue: - View Availability option should not be shown for service type products Cause: - No condition to make it invisible. Solution: - Added a condition when product type is service to the option invisible. task-3801551 Forward-Port-Of: odoo/enterprise#58817