Wednesday, December 25, 2024
8 changes
3 changes
Miscellaneous changes
Issue introduced at https://github.com/odoo/odoo/commit/ce92dedea0fd3cdc73da6366c20b8052bb04f7e9 , While doing the fix for ewaybill, now it's causing issue for `E-Invoice`, because the partner buyer details were changed from Purchase Document to Move type being a Outbound In this fix we only change Buyer-Seller Details only if it's for e-waybill Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I conf
Original PR description
Issue introduced at https://github.com/odoo/odoo/commit/ce92dedea0fd3cdc73da6366c20b8052bb04f7e9 , While doing the fix for ewaybill, now it's causing issue for `E-Invoice`, because the partner buyer details were changed from Purchase Document to Move type being a Outbound In this fix we only change Buyer-Seller Details only if it's for e-waybill Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#191578
Since [1], a fix was introduced to display the actual value of a relational field instead of its ID. However, another issue occurs when a form is inside a tab (Tabs snippet) and a new tab is added. During this process, the currently active tab is cloned, including its field IDs. Although a method exists to update the IDs after cloning, the form rendering is triggered beforehand. This causes the labels property of input elements—which is expected to return a NodeList of associated <label> elem
Original PR description
Since [1], a fix was introduced to display the actual value of a relational field instead of its ID. However, another issue occurs when a form is inside a tab (Tabs snippet) and a new tab is added.…
Since [1], a fix was introduced to display the actual value of a relational field instead of its ID. However, another issue occurs when a form is inside a tab (Tabs snippet) and a new tab is added. During this process, the currently active tab is cloned, including its field IDs. Although a method exists to update the IDs after cloning, the form rendering is triggered beforehand. This causes the labels property of input elements—which is expected to return a NodeList of associated <label> elements—to fail because the cloned input IDs are not unique. This commit resolves the issue by using querySelector to target the associated label elements directly. Steps to reproduce: - Open the Website editor. - Drag & Drop a Tabs snippet. - In the first tab, drag & Drop a Form snippet. - Set the first field as a radio buttons. - Make the second field's visibility depend on the first field. - Add a new tab by clicking the "+" icon in the right panel. - Observe that a traceback occurs. A second issue related to [1] has been resolved for cases where there is only a single checkbox. In this scenario, the value displayed in the visibility condition dropdown menu should be "Yes". opw-4345340 [1]: https://github.com/odoo/odoo/commit/4b37f22cece5424d6992c6bafe619c9a457d184b Forward-Port-Of: odoo/odoo#190460
Israel is raising VAT rate from 17% to 18% on 1/1/2025. Changes: Added new taxes (17% -> 18%) Archived 17% taxes Added tax group (VAT 18%) Modified fiscal position to match those taxes Modified VAT report to include VAT Inputs 18% Updated default tax ids for IL res.company Backward-Port-Of: https://github.com/odoo/odoo/pull/191209 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#191749
Original PR description
Israel is raising VAT rate from 17% to 18% on 1/1/2025. Changes: Added new taxes (17% -> 18%) Archived 17% taxes Added tax group (VAT 18%) Modified fiscal position to match those taxes Modified VAT report to include VAT Inputs 18% Updated default tax ids for IL res.company Backward-Port-Of: https://github.com/odoo/odoo/pull/191209 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#191749
2 changes
Miscellaneous changes
**Problem:** l10n_co_dian_certification_process (Activate the certification process) can still be checked if l10n_co_dian_test_environment (Test environment) is left unchecked. There are two ways to cause this: 1. | | l10n_co_dian_test_environment | l10n_co_dian_certification_process | |--------|--------|--------| | Start | False | False | | End | False | True | Here, the write call will trigger l10n_co_dian_certification_process is set from False to True without triggering the “
Original PR description
**Problem:** l10n_co_dian_certification_process (Activate the certification process) can still be checked if l10n_co_dian_test_environment (Test environment) is left unchecked. There are two ways to…
3 changes
Miscellaneous changes
Since [1], a fix was introduced to display the actual value of a relational field instead of its ID. However, another issue occurs when a form is inside a tab (Tabs snippet) and a new tab is added. During this process, the currently active tab is cloned, including its field IDs. Although a method exists to update the IDs after cloning, the form rendering is triggered beforehand. This causes the labels property of input elements—which is expected to return a NodeList of associated <label> elem
Original PR description
Since [1], a fix was introduced to display the actual value of a relational field instead of its ID. However, another issue occurs when a form is inside a tab (Tabs snippet) and a new tab is added.…
**Problem:** l10n_co_dian_certification_process (Activate the certification process) can still be checked if l10n_co_dian_test_environment (Test environment) is left unchecked. There are two ways to cause this: 1. | | l10n_co_dian_test_environment | l10n_co_dian_certification_process | |--------|--------|--------| | Start | False | False | | End | False | True | Here, the write call will trigger l10n_co_dian_certification_process is set from False to True without triggering the “if” condition since l10n_co_dian_test_environment is not set. 2. | | l10n_co_dian_test_environment | l10n_co_dian_certification_process | |--------|--------|--------| | Start | True | False | | End | False | True | Here, l10n_co_dian_test_environment is set from True to False from the first write call, which will trigger the “if” condition, causing it to also set l10n_co_dian_certification_process to False. However, then the l10n_co_dian_certification_process is set from False to True by the second original write call. **Purpose:** Make the l10n_co_dian_certification_process field a computed field such that l10n_co_dian_certification_process cannot be set to True if l10n_co_dian_test_environment is False. **Steps to Reproduce on Runbot:** 1. Install l10n_co_dian Case 1: 2. Start at the state, where both l10n_co_dian_test_environment and l10n_co_dian_certification_process are False 3. Check the box for l10n_co_dian_test_environment so that the box for l10n_co_dian_certification_process will also show up. Then check the box for l10n_co_dian_certification_process and uncheck the box for l10n_co_dian_test_environment. Finally save the new configuration. Case 2: 2. Start at the state, where l10n_co_dian_test_environment is True and l10n_co_dian_certification_process is False 3. Check the box for l10n_co_dian_certification_process then uncheck the box for l10n_co_dian_test_environment. Finally save the new configuration. opw-4225471 Forward-Port-Of: odoo/enterprise#76098 Forward-Port-Of: odoo/enterprise#73532
Purpose of this commit: Remove files that depends on legacy 'bus/../test/helpers'. Part of:3818666 Forward-Port-Of: odoo/enterprise#75949
Original PR description
Purpose of this commit: Remove files that depends on legacy 'bus/../test/helpers'. Part of:3818666 Forward-Port-Of: odoo/enterprise#75949
Since [1], a fix was introduced to display the actual value of a relational field instead of its ID. However, another issue occurs when a form is inside a tab (Tabs snippet) and a new tab is added. During this process, the currently active tab is cloned, including its field IDs. Although a method exists to update the IDs after cloning, the form rendering is triggered beforehand. This causes the labels property of input elements—which is expected to return a NodeList of associated <label> elements—to fail because the cloned input IDs are not unique. This commit resolves the issue by using querySelector to target the associated label elements directly. Steps to reproduce: - Open the Website editor. - Drag & Drop a Tabs snippet. - In the first tab, drag & Drop a Form snippet. - Set the first field as a radio buttons. - Make the second field's visibility depend on the first field. - Add a new tab by clicking the "+" icon in the right panel. - Observe that a traceback occurs. A second issue related to [1] has been resolved for cases where there is only a single checkbox. In this scenario, the value displayed in the visibility condition dropdown menu should be "Yes". opw-4345340 [1]: https://github.com/odoo/odoo/commit/4b37f22cece5424d6992c6bafe619c9a457d184b Forward-Port-Of: odoo/odoo#191709 Forward-Port-Of: odoo/odoo#190460
Issue introduced at https://github.com/odoo/odoo/commit/ce92dedea0fd3cdc73da6366c20b8052bb04f7e9 , While doing the fix for ewaybill, now it's causing issue for `E-Invoice`, because the partner buyer details were changed from Purchase Document to Move type being a Outbound In this fix we only change Buyer-Seller Details only if it's for e-waybill Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I conf
Original PR description
Issue introduced at https://github.com/odoo/odoo/commit/ce92dedea0fd3cdc73da6366c20b8052bb04f7e9 , While doing the fix for ewaybill, now it's causing issue for `E-Invoice`, because the partner buyer details were changed from Purchase Document to Move type being a Outbound In this fix we only change Buyer-Seller Details only if it's for e-waybill Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#191578
Current behavior before PR: When a user mentioned a channel or another user in a message, the web notification displayed the mention URL on the recipient’s side, causing a UI issue. Before / After <div style="display: flex;"> <img src="https://github.com/user-attachments/assets/3e8d381a-5d08-4f43-89f4-382d7b9bcca1" width="48%" style="margin-right: 4%;" /> <img src="https://github.com/user-attachments/assets/9abb168c-fe7d-4828-b55f-140219deb003" width="48%" /> </div> Desired beha
Original PR description
Current behavior before PR: When a user mentioned a channel or another user in a message, the web notification displayed the mention URL on the recipient’s side, causing a UI issue. Before / After <div style="display: flex;"> <img src="https://github.com/user-attachments/assets/3e8d381a-5d08-4f43-89f4-382d7b9bcca1" width="48%" style="margin-right: 4%;" /> <img src="https://github.com/user-attachments/assets/9abb168c-fe7d-4828-b55f-140219deb003" width="48%" /> </div> Desired behavior after PR is merged: This commit resolves the issue by hiding the mention URL in web notification when a user mentions a channel or another user in a message. Task-4295310 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#186744