Daily updates from Odoo
Monday, December 30, 2024
13 changes · 18.0
Resolved issues and error corrections
This fix ensures copied databases using Indian localization settings are neutralized so they do not contact live government or production services. It helps support teams investigate issues safely without risking real-world effects on customers or production records.
Original PR description
Since [1], the filed `l10n_in_edi_production_env` has been moved from module `l10n_in_edi` to `l10n_in`. `l10n_in_gstin_status` needs to be neutralized to not hit the production servers, but it does…
Since [1], the filed `l10n_in_edi_production_env` has been moved from module `l10n_in_edi` to `l10n_in`. `l10n_in_gstin_status` needs to be neutralized to not hit the production servers, but it does not depend on the `l1on_in_edi` module which holds the neutralization script. Even if the `l10n_in_gstin_status` does not end up performing operation that require a strict neutralization, future modules that also depend solely on `l10n_in` might not be so lucky, rendering this change absolutely necessary. The purpose of the standard neutralization framework is to allow us to create database copies that will not interact with external systems in ways that could impact the production database (or if it is not possible to prevent the interactions, make sure that they are benign or won't result in actual changes), or impact the customers of the operator of the production database. This is mainly useful to allow safe support investigation on database duplicates. [1] https://github.com/odoo/odoo/pull/175290
The HTML editor color picker now correctly shows which text or background color is already applied when users open it. This makes formatting clearer and avoids duplicate or missing custom color entries, reducing confusion while editing content.
Original PR description
**Current behavior before PR:** When there is a text having a text-color or background color, opening color selector doesn't highlight the button matching with that selected color in solid color tab. **Desired behavior before PR is merged:** Opening color selector highlights the button matching with that selected color in solid color tab. task-4341528 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix updates an automated test for the self-ordering point-of-sale feature so it selects the intended product directly. This makes test results more reliable and avoids failures caused by products appearing in a different order.
Original PR description
**Problem**: The product created during the tour test was not explicitly selected. It was selected implicitly because it appeared first in the product list. **Solution**: Explicitly select the product created during the test in the tour to ensure proper functionality and remove dependency on list order. runbot-110904 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Reloading the Colombian DIAN configuration no longer crashes when a required certificate is missing. Instead, users receive a clear validation message so they can add or restore the certificate and continue configuration.
Original PR description
Currently, An error occurs when reloading the DIAN configuration in an account journal to obtain the security token of a certificate, if no certificate is available. Step to produce: - Install the `l10n_co_dian` module. - Navigate to Settings and click on Certificates under the Certificates and Keys section. - And delete a 'Demo DIAN Certificate'. - Open any Journals and click on a 'Reload DIAN configuration'. `IndexError: tuple index out of range` The error occurs because the system attempts to access the certificate's token from a company at [1], but it is not available. Link [1]: https://github.com/odoo/enterprise/blob/a354a19060338084df35a14ed7f21defc3c05c11/l10n_co_dian/xml_utils.py#L123 To resolve this issue, Raise a validation error if a certificate is not found when the system attempts to retrieve its security token. Sentry-6165073693
Miscellaneous changes
Previously, the "Images Subtitles" template in the Megamenu had an issue where the images were stretching vertically to fill the container's height. Adding an additional class to the container fixes the styling and maintains the images' correct aspect ratio. task-4203427  Forward-Port-Of: odoo/odoo#191932 Forward-Port-Of: odoo/odoo#182903
Original PR description
Previously, the "Images Subtitles" template in the Megamenu had an issue where the images were stretching vertically to fill the container's height. Adding an additional class to the container fixes the styling and maintains the images' correct aspect ratio. task-4203427  Forward-Port-Of: odoo/odoo#191932 Forward-Port-Of: odoo/odoo#182903
Tax included in price were not taken into account when using a loyalty program applying on the cheapest product. Steps to reproduce: ------------------- * Create a loyalty program that apply 10% reward on cheapest product * Create a product A that has 10% tax included in price * Open PoS and add this product to the order (make sure this is the cheapest in the order) > Observation: The discount is not taking the tax into account opw-4243827 Forward-Port-Of: odoo/odoo#191678 Forward
Original PR description
Tax included in price were not taken into account when using a loyalty program applying on the cheapest product. Steps to reproduce: ------------------- * Create a loyalty program that apply 10% reward on cheapest product * Create a product A that has 10% tax included in price * Open PoS and add this product to the order (make sure this is the cheapest in the order) > Observation: The discount is not taking the tax into account opw-4243827 Forward-Port-Of: odoo/odoo#191678 Forward-Port-Of: odoo/odoo#189612
Before this fix it was not possible to reconcile the stock valuation lines created from PoS as one of them was missing the partner_id Steps to reproduce: ------------------- * Activate automatic stock valuation for the `All` category * Sell a product and ship it later * Close the session and go to the accounting entries > Observation: 2 of them are not reconciled, when clicking on reconcile it was not finding the good one to reconcile with opw-4395468 Forward-Port-Of: odoo/odoo#190
Original PR description
Before this fix it was not possible to reconcile the stock valuation lines created from PoS as one of them was missing the partner_id Steps to reproduce: ------------------- * Activate automatic stock valuation for the `All` category * Sell a product and ship it later * Close the session and go to the accounting entries > Observation: 2 of them are not reconciled, when clicking on reconcile it was not finding the good one to reconcile with opw-4395468 Forward-Port-Of: odoo/odoo#190519
When using MultiRecordSelector with domain, the domain will not automatically apply to SelectCreateDialog. See odoo/enterprise#68484 closes odoo/odoo#176850 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#191322 Forward-Port-Of: odoo/odoo#191125
Original PR description
When using MultiRecordSelector with domain, the domain will not automatically apply to SelectCreateDialog. See odoo/enterprise#68484 closes odoo/odoo#176850 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#191322 Forward-Port-Of: odoo/odoo#191125
Before this commit, even if no foldable link items were present in the navbar of a website header, the function to check if items needed to be hidden was still executed. After this commit, if no foldable items are present in the navbar, the function is not executed. Running the function when no items are present can, in rare cases, cause errors (e.g., starting from version 17.0, if the "sales 1" header template contains no links and the page is zoomed). This is why we addressed this issue
Original PR description
Before this commit, even if no foldable link items were present in the navbar of a website header, the function to check if items needed to be hidden was still executed. After this commit, if no foldable items are present in the navbar, the function is not executed. Running the function when no items are present can, in rare cases, cause errors (e.g., starting from version 17.0, if the "sales 1" header template contains no links and the page is zoomed). This is why we addressed this issue in this commit. opw-4390661 Forward-Port-Of: odoo/odoo#191793 Forward-Port-Of: odoo/odoo#191233
### Issue: - In 16.0 only, When sending a POS receipt by email, the receipt displays correctly in the preview within the POS app. However, the attached receipt in the email appears cropped, and the company logo is not centered. ### Steps to reproduce: 1. On runbot, go to the POS app. 2. Start a session. add a product, a customer and pay. 3. Click on send by email arrow button. 4. check receipt on mailhog. ### Solution: - I've wrapped the receipt content with a #receipt-wrapper div, a
Original PR description
### Issue: - In 16.0 only, When sending a POS receipt by email, the receipt displays correctly in the preview within the POS app. However, the attached receipt in the email appears cropped, and the company logo is not centered. ### Steps to reproduce: 1. On runbot, go to the POS app. 2. Start a session. add a product, a customer and pay. 3. Click on send by email arrow button. 4. check receipt on mailhog. ### Solution: - I've wrapped the receipt content with a #receipt-wrapper div, allowing you to add a padding (margin). opw-[4140950](https://www.odoo.com/web#id=4140950&view_type=form&model=project.task)  --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#191288 Forward-Port-Of: odoo/odoo#186852
**Problem**: After this commit: https://github.com/odoo/odoo/commit/cf8f0ff7ba4bb33425003399bc4e5b33d3d5629a the toolbar is hidden when it overflows (`this.toolbar.classList.toggle('d-none', distToScrollContainer < OFFSET / 2);`). This behavior is not suitable for selections containing elements with a height that exceeds the viewport, as the toolbar becomes inaccessible. **Solution**: Ensure the toolbar is always visible, even when overflowing. In such cases, reposition the toolbar to alig
Original PR description
**Problem**: After this commit: https://github.com/odoo/odoo/commit/cf8f0ff7ba4bb33425003399bc4e5b33d3d5629a the toolbar is hidden when it overflows (`this.toolbar.classList.toggle('d-none',…
**Problem**:
After this commit:
https://github.com/odoo/odoo/commit/cf8f0ff7ba4bb33425003399bc4e5b33d3d5629a the toolbar is hidden when it overflows (`this.toolbar.classList.toggle('d-none', distToScrollContainer < OFFSET / 2);`). This behavior is not suitable for selections containing elements with a height that exceeds the viewport, as the toolbar becomes inaccessible.
**Solution**:
Ensure the toolbar is always visible, even when overflowing. In such cases, reposition the toolbar to align with the top of the selection, providing consistent accessibility.
**Picture before fix**
***top***
***bottom***
**Picture after fix**
***top***
***bottom***
**Steps to reproduce**:
1. Add an image to the editor that overflows the viewport.
2. Select the image.
3. Observe that the toolbar does not appear.
opw-4398551
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#190465pos*: pos_restaurant, pos_preparation_display Before this commit: ============== - Splitting an order caused the loss of ordered and unordered quantity information for the order lines. After this commit: ============== - Ordered and unordered quantity information is preserved for all order lines. - Preparation display quantities remain unaffected. Task - 4114041 Forward-Port-Of: odoo/odoo#179481
Original PR description
pos*: pos_restaurant, pos_preparation_display Before this commit: ============== - Splitting an order caused the loss of ordered and unordered quantity information for the order lines. After this commit: ============== - Ordered and unordered quantity information is preserved for all order lines. - Preparation display quantities remain unaffected. Task - 4114041 Forward-Port-Of: odoo/odoo#179481
## Issue: - Uploading a Mexican XML file with an 8% tax results in the addition of an extra 8% tax. ## Steps to reproduce: - Create a new invoice and add a line with an 8% tax. - Validate the invoice and export it as XML. - Upload the XML file as a vendor bill. - The vendor bill incorrectly shows two "8% taxes" instead of one. ## Solution: - The issue stems from a forward-port error from `saas-16.4` https://github.com/odoo/enterprise/commit/5681a8d5abee3a8787f3ee8612a8c3b18ed63ee6 to
Original PR description
## Issue: - Uploading a Mexican XML file with an 8% tax results in the addition of an extra 8% tax. ## Steps to reproduce: - Create a new invoice and add a line with an 8% tax. - Validate the invoice…
## Issue: - Uploading a Mexican XML file with an 8% tax results in the addition of an extra 8% tax. ## Steps to reproduce: - Create a new invoice and add a line with an 8% tax. - Validate the invoice and export it as XML. - Upload the XML file as a vendor bill. - The vendor bill incorrectly shows two "8% taxes" instead of one. ## Solution: - The issue stems from a forward-port error from `saas-16.4` https://github.com/odoo/enterprise/commit/5681a8d5abee3a8787f3ee8612a8c3b18ed63ee6 to `17.0` https://github.com/odoo/enterprise/commit/56a2b66d84d8398ea870d559cd55cfeae44019d8 - In `17.0` we introduced this Extract method `_l10n_mx_edi_import_cfdi_get_tax_from_node` to refactor the `_l10n_mx_edi_import_cfdi_fill_invoice_line`. - We should have add the Exento checks in the new method however we mistakenly pushed code from `saas-16.4` to `17.0` without adapting it. - I removed the extra code introduced during the forward-porting. - Refactored the related code to ensure compatibility with the new changes in `17.0`. OPW-4198016 Forward-Port-Of: odoo/enterprise#76078 Forward-Port-Of: odoo/enterprise#74602