Daily updates from Odoo
Thursday, January 2, 2025
17 changes
3 changes
Resolved issues and error corrections
When a quotation or sales order is deleted, its custom spreadsheet is now removed as well. This prevents order-specific spreadsheets from being reused accidentally in quotation templates, keeping sales documents cleaner and more accurate.
Original PR description
Currently, when deleting a quotation/SO with a custom `sale.order.spreadsheet`, the latter will see its field `order_id` empty and will become available to be linked to a quotation template. Since it's a custom spreadsheet for that specific SO, it makes no sense to keep it. opw-4385254
IoT Boxes now receive both device-specific and generic handler files when updating. This prevents missing components that could stop connected hardware integrations from working correctly.
Original PR description
In this [PR](https://github.com/odoo/enterprise/pull/75443), we added conditions not to download already up to date handlers. We introduced a condition to only download Windows handlers on Windows and Linux ones on Linux: as some are not plateform-specific, we were not sending them to the IoT Box. The condition is now adapted to download both plateform-specific and generic handlers to IoT Boxes.
This fix prevents an error when staff click the customer button after settling a customer's due account in Point of Sale. It improves checkout reliability and avoids interruptions during customer account payment workflows.
Original PR description
Steps to reproduce : ==== - Open POS - Select customer and pay through the customer account payment option. - Again go to customer and select customer. - Settle the due amount & complete payment. - Click on the customer button. - Traceback appears. Fix : ==== - Fixed improper value parsing to ensure correct behavior. task - 4376767
10 changes
Resolved issues and error corrections
The tax form for Argentine withholding now shows the Minimum Threshold field for applicable perception taxes. This helps users correctly view and manage threshold settings without hidden information on the tax form.
Original PR description
It is needed to make not invisible "Minimum Treshold" on applied perceptions AR taxes. Task Adhoc side: 43625 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The TDS Entry button is now shown for payments that have already been marked as paid, not only those still in process. This helps users complete or review withholding tax entries without needing the payment to remain in an intermediate state.
Original PR description
Before This Commit: - The TDS Entry button is visible only in `In Process` state. After This Commit: - The TDS Entry button is visible in both `In Process` and `Paid` state. Task: 4432364
This change prevents a sales-related automated test from failing when the broader sales management app is not installed. It improves reliability for Odoo.sh projects that use Sales features through custom modules without enabling the full Sales Management menu.
Original PR description
### Description of the issue this PR addresses: Test TestSaleComboConfigurator.test_sale_combo_configurator (introduced with #186645) depends on the Sale menu being shown, but it isn't if the sale_management module is not installed. This change skips this test in this case. ### Current behavior before PR: The test fails on odoo.sh with custom modules that only depend on sale and not sale_management. ### Desired behavior after PR is merged: The test succeeds in the condition mentionned above. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents production spreadsheets from blocking copies of older versions when referenced fields or data sources have since changed or been removed. Development and testing environments still keep the validation checks so dashboard issues can be caught before release.
Original PR description
Following #184846, the data validation is no longer necessary in a production context. Moreover, it currently limits some capacities for the user to user the history of the spreadsheets. Eg: - Create…
Following #184846, the data validation is no longer necessary in a production context. Moreover, it currently limits some capacities for the user to user the history of the spreadsheets. Eg: - Create a new field with studio - Add a datasouce in a spreadsheet which relies on that field - make a bunch of revision - Delete the field you created - Go back to the spreadsheet - Open the version history and try to "make a copy" of some recent revision => it will throw as you try to create a spreadsheet with invalid fields However, the data validation still make sense to alert developpers to adapts dashboards when they change the schema of some tables. This revision deactivates the data validation on production which ensures that the last point is still respected while developping (will be detected by runbot tests). Task: 4363803 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The sales product catalog now keeps the discounted pricelist price visible after a product is added to an order. This prevents customers or sales teams from seeing the price jump from the discounted amount back to the original price when using pricelists and discounts.
Original PR description
Steps: - install sale and activate pricelists - activate discounts from setting - create a product with price 100 - create a pricelist with of 2% discount on the product - create a sale order with the new pricelist - open the new product in catalog and add 1 quantity Issue: - the price for the product changes from 98 to 100 after adding quantity Cause: - the display price in catalog comes from either SOL price unit or computed from SO pricelist_id. When discounts setting is active the SOL price_unit is pricelist price without discount else with discount. Hence when first time the catalog is loaded it is computed from SO's pricelist and after adding a quantity it takes pricelist price without discount from SOL Fix: - Updated `_update_order_line_info` so it will always take the pricelist computed price and not SOL unit_price opw - 4345503 opw - 4406373 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change removes an unnecessary hidden field from the French localization company form. It prevents a test failure on Odoo SH and helps keep the module compliant with Odoo view validation rules.
Original PR description
Description of the issue/feature this PR addresses: The field **is_france_country** was added to the **l10n_fr.res_company_form_l10n_fr** view with the invisible attribute set to 1. This caused an error on Odoo SH due to commit #162009. Since fields used in Python expressions are automatically added to the view, we do not need to keep it. Current behavior before PR: When you enable tests for the module l10n_fr, you have the following error : Please indicate why the always invisible fields are present in the view, or remove the field tag. Addons: 'l10n_fr' Views: ['res_company_form_l10n_fr'] Desired behavior after PR is merged: Pass the test test_uncommented_invisible_field --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update fixes an issue in Firefox where users could not open the editing popover for button-styled links in the HTML editor. Users can now click and edit these links normally, improving reliability when preparing website or email content.
Original PR description
**Current behavior before PR:** - In Firefox, the user-select: none style disabled text selection and prevented the cursor from being placed inside a button. This caused the button click to fail in opening the link popover. **Desired behavior after PR is merged:** - The user-select property for the btn class is changed from none to auto. This allows users to place the cursor inside the button-styled link, enabling editing and ensuring the link popover can be opened as expected. task:4358091 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Partner Ledger no longer crashes when partner names start with special characters such as '~' and report grouping is enabled. This ensures accounting users can open and review ledgers normally even when customer or vendor names contain unusual characters.
Original PR description
Steps --------- 1. Debug mode 2. Go to Accounting 3. Configuration > Management > Accounting Reports 4. Open "Partner Ledger" 5. In the Options tab, set the "Prefix Groups Threshold to 3" 6. Create 3…
Steps
---------
1. Debug mode
2. Go to Accounting
3. Configuration > Management > Accounting Reports
4. Open "Partner Ledger"
5. In the Options tab, set the "Prefix Groups Threshold to 3"
6. Create 3 different partners, each having their name starting with a '\~'
7. Create an invoice for each of the partners created in previous steps
8. Open the partner ledger -> Traceback
Problem
---------
When there are more lines in the report than the prefix group value, the partners are grouped by names: P -> PA -> PAR, etc.
However, some partners could have a '\~' in their names making the groupby line_id \~account.report\~14|{"groupby_prefix_group": "\~"}\~\~. The line ID being split using the | and \~ characters, it causes some issues.
Solution
---------
Since the line ID format is fixed: markup\~model\~id|markup\~model\~id|... We can split from the back and hard limit the split to 2 to make sure we always have (markup, model and ID) no matter the content of the markup.
task-4420258When a quotation or sales order is deleted, its custom spreadsheet is now removed as well. This prevents order-specific spreadsheets from being reused accidentally in quotation templates, keeping sales data cleaner and more consistent.
Original PR description
Currently, when deleting a quotation/SO with a custom `sale.order.spreadsheet`, the latter will see its field `order_id` empty and will become available to be linked to a quotation template. Since it's a custom spreadsheet for that specific SO, it makes no sense to keep it. opw-4385254
The chat window header buttons are now slightly larger, making them easier to click on desktop. This reduces small interaction frustrations for users who frequently use chat quick actions.
Original PR description
Click on quick ation button in Chat window header was a bit tedious in desktop. This happens because the clickable area is 24px x 24px. This commit makes it easier by increasing to 28px x 28px, thanks to explicit `p-1` on buttons. This ain't much but this gives less frustration to use chat window quick actions. <img width="601" alt="Screenshot 2025-01-02 at 18 23 47" src="https://github.com/user-attachments/assets/b0c09d0c-906b-43b9-b8f7-6fb954c34998" />
4 changes
Resolved issues and error corrections
This update addresses a technical issue in the l10n_mx_edi module that caused reports to break when views were inherited. By adding names to specific view elements, the change ensures these views remain stable even with small updates, preventing disruptions to report generation. This improves the reliability of the Mexican EDI functionality.
Original PR description
There are currently some elements in views that are not reachable on a deterministic way when those views are inherited. That means, to reach them, positional selectors need to be used (e.g. `last()`). That causes inherited views to get broken when there are small changes in element position.
A good example of this is [1]:
<div class="digital-stamp">
<span>Extra Info</span>
</div>
Which can't be filtered by:
- Class, because there are several `<div>` elements with the same class
- Text content, because when content is translated, selector will fail
To solve the above, this change provides names for several elements, to make possible/easier to reach them on a safely manner.
[1] https://github.com/odoo/enterprise/blob/d6346ef8/l10n_mx_edi/views/l10n_mx_edi_report_invoice.xml#L123
Forward-Port-Of: odoo/enterprise#64604
Forward-Port-Of: odoo/enterprise#63957This update resolves an issue where spreadsheet templates couldn't correctly handle grouped date fields. The fix prevents incorrect assumptions about date granularity during template creation, ensuring accurate spreadsheet generation. This improves the reliability of reports and dashboards.
Original PR description
When creating a spreadsheet.template, we ensure the values of each groupbys are correctly ordered. Tthe current implementation assumes that the groupby will return values present in the tables and not values altered by a groupby with specific granularity (namely date fields) by adding the values to the search domain. Unfortunately, the search does not support dates with a granularity different than `day`. This revision ensures that we do not add such grouped values to the search domain. Task-4438631 Forward-Port-Of: odoo/enterprise#76290
This update corrects a minor typo in the system's notification process for employee contracts. The fix ensures that salary-related messages are correctly sent, preventing potential disruptions to payroll and contract management workflows. This ensures accurate and timely communication regarding contract details.
Original PR description
Forward-Port-Of: odoo/enterprise#75991
This update fixes a bug preventing the helpdesk onboarding tour from progressing when users provided input. The fix removed a hardcoded string check, allowing the tour to correctly advance based on user actions, improving the user experience.
Original PR description
Previously, when a customer was selected or input was entered, the onboarding tour failed to proceed to the next step. With this fix, the tour will correctly advance when the user provides input. Without demo data, the database does not have Deco.so i so I select the partner. When the user does not provide the ticket name 'SAP is bad, paid by Odoo,' the tour will not move to the next step because we had checked a fixed string. Therefore, I have removed it and checked the kanban class instead. task-4372470 Forward-Port-Of: odoo/enterprise#75106