Saturday, January 18, 2025
15 changes
3 changes
Miscellaneous changes
This commit fixes a typo in two mobile form view's tests where "screenLeft" was used instead of "scrollX". Note: this was detected while testing for the new Chrome's headless mode set by default on Chrome 128+. Forward-Port-Of: odoo/odoo#194105
Original PR description
This commit fixes a typo in two mobile form view's tests where "screenLeft" was used instead of "scrollX". Note: this was detected while testing for the new Chrome's headless mode set by default on Chrome 128+. Forward-Port-Of: odoo/odoo#194105
**Issue:** when making a payment using 2 different payment methods (cash and bank), the change gets deducted from the bank payment not the cash payment in the invoice. **Steps To Reproduce:** On POS, for an order totaling $120. - Add a customer and ensure the "Invoice" box is checked. - pay using two payments methods bank 100$ Cash 50$ - the change is $30, everything looks fine on the ticket on the pos. - Notice on the invoice on the db backend the $30 change is inco
Original PR description
**Issue:**
when making a payment using 2 different payment methods (cash and bank), the change gets deducted from the bank payment not the cash payment in the invoice.
**Steps To Reproduce:**
On POS, for an order totaling $120.
- Add a customer and ensure the "Invoice" box is checked.
- pay using two payments methods bank 100$ Cash 50$
- the change is $30, everything looks fine on the ticket on the pos.
- Notice on the invoice on the db backend the $30 change is incorrectly deducted from the bank payment. As a result, the invoice displays: bank : $70 cash: $50
**Soltution:**
- In the `_create_payment_moves` method, ensure that cash payment method creates an `account.move` including the change amount.
opw-4076246
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#194097
Forward-Port-Of: odoo/odoo#187727Since odoo/odoo#191886, "download handlers" is available through "Update" page. As Windows IoT Boxes have no access to this page, the feature was unreachable. This commit fixes this behaviour by allowing access to Update page and disabling Linux specific tools on it. Forward-Port-Of: odoo/odoo#194145
Original PR description
Since odoo/odoo#191886, "download handlers" is available through "Update" page. As Windows IoT Boxes have no access to this page, the feature was unreachable. This commit fixes this behaviour by allowing access to Update page and disabling Linux specific tools on it. Forward-Port-Of: odoo/odoo#194145
8 changes
Miscellaneous changes
[FIX] hr_contract_salary: Custom document field not working Steps: - Create a new file field on employee - Open salary package configurator / personal info - Create a new info with the created field - category: personal documents - display type: document - Open Employee/Abigail - Open its contract - Generate an offer - 17 - Send by email - From the generated template, copy the button link - Open the copied link in another tab - master
Original PR description
[FIX] hr_contract_salary: Custom document field not working
Steps:
- Create a new file field on employee
- Open salary package configurator / personal info
- Create a new info with the created field
- category: personal documents
- display type: document
- Open Employee/Abigail
- Open its contract
- Generate an offer
- 17
- Send by email
- From the generated template, copy the button link
- Open the copied link in another tab
- master
- Just open the Link field
Actual result:
- KeyError for the filename of the new file field
Expected result:
- No error
- Filename field is also used when using a binary field
- File input is well show in the website configurator
opw-4382086
Caused by https://github.com/odoo/enterprise/commit/8e50071471d194bc8b594a79a95fe951cd5055ab & https://github.com/odoo/enterprise/commit/6f40549b98e65f813456442f7df35e9349a7639c
Forward-Port-Of: odoo/enterprise#758684 changes
Resolved issues and error corrections
This fixes an issue in the HTML editor where users editing content inside an embedded frame could not hover or select Powerbox commands after scrolling the menu. The change makes the editing menu respond as expected, reducing friction when choosing formatting or content commands.
Original PR description
Have the edited document in an iframe. Spawn the Powerbox, Scroll the powerbox. Without letting the mouse out of the powerbox, try to hover a command Before this commit, this did not work. It was because of a piece of code that prevents selection of commands during scrolling, probably to avoid re-renders. After this commit, this use case works as expected. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Steps to reproduce: - Create a spreadsheet - click on the the Share button - add a portal user (Joel Willis) to the allowed users - connect as the portal user and open his portal - go to the Documents section and try opening the spreadsheet => You are not allowed to access 'Spreadsheet Contributor' (spreadsheet.contributor) records. Task: 4453298 Forward-Port-Of: odoo/enterprise#77007 Forward-Port-Of: odoo/enterprise#76531
Original PR description
Steps to reproduce: - Create a spreadsheet - click on the the Share button - add a portal user (Joel Willis) to the allowed users - connect as the portal user and open his portal - go to the Documents section and try opening the spreadsheet => You are not allowed to access 'Spreadsheet Contributor' (spreadsheet.contributor) records. Task: 4453298 Forward-Port-Of: odoo/enterprise#77007 Forward-Port-Of: odoo/enterprise#76531
When we click on the waning the action does not show the correct list. - replace the `self.env['fleet.vehicle']` with `self.env['hr.employee']` as `employees_multiple_vehicles` is a list with employee_ids not vehicle_ids Task: 4458500 Forward-Port-Of: odoo/enterprise#77115 Forward-Port-Of: odoo/enterprise#76679
Original PR description
When we click on the waning the action does not show the correct list. - replace the `self.env['fleet.vehicle']` with `self.env['hr.employee']` as `employees_multiple_vehicles` is a list with employee_ids not vehicle_ids Task: 4458500 Forward-Port-Of: odoo/enterprise#77115 Forward-Port-Of: odoo/enterprise#76679
This commit's purpose is to clean up the graph view of the sla report analysis model. Some fields were added on the view by a generic improvement task to handle the widget 'float_time' with grap view. In this case, those fields are a nuisance for readability, so we're getting rid of them. target version 17.0 - master task - 4351830 Forward-Port-Of: odoo/enterprise#76237
Original PR description
This commit's purpose is to clean up the graph view of the sla report analysis model. Some fields were added on the view by a generic improvement task to handle the widget 'float_time' with grap view. In this case, those fields are a nuisance for readability, so we're getting rid of them. target version 17.0 - master task - 4351830 Forward-Port-Of: odoo/enterprise#76237
## Description Following 9a8777b4b96367597418cdc1c1ffc7ea3264113f, the criteria on the `move_type` of the invoices used in `sale.commission.report` was changed from `'out_invoice'` to `'out_invoice' AND 'out_refund'`, but the respective index `account_move_invoice_user_id_date_idx` partial clause hasn't been updated, leading to Postgres not being able to use the index, leading to a performance regression. We're updating both custom indexes partial clause to match the invoice `move_type` conditi
Original PR description
## Description Following 9a8777b4b96367597418cdc1c1ffc7ea3264113f, the criteria on the `move_type` of the invoices used in `sale.commission.report` was changed from `'out_invoice'` to `'out_invoice' AND 'out_refund'`, but the respective index `account_move_invoice_user_id_date_idx` partial clause hasn't been updated, leading to Postgres not being able to use the index, leading to a performance regression. We're updating both custom indexes partial clause to match the invoice `move_type` condition used in the reporting. ## Benchmark On a large database with millions of invoices and customers | Timings (hot) | Before | After | |---------------|--------|-------| | 1 read_group | 40s | 1s | | full load | 225s | 6s | ## Reference task-4448879 Forward-Port-Of: odoo/enterprise#76723
When a user create the first payment initiation with Ponto he need to do the KYC of Ponto. The issue is that today we initiate the payment and then start the process of KYC. Following that the first payment is always in error, because it was initiated before the KYC. In this commit, we create the payments only if the KYC is done. task-4476856 Forward-Port-Of: odoo/enterprise#77052
Original PR description
When a user create the first payment initiation with Ponto he need to do the KYC of Ponto. The issue is that today we initiate the payment and then start the process of KYC. Following that the first payment is always in error, because it was initiated before the KYC. In this commit, we create the payments only if the KYC is done. task-4476856 Forward-Port-Of: odoo/enterprise#77052
This commit fixes various issues with the context menu on the call participant: - Before this commit it wasn't possible to set the volume of a user to 0 due to the use of the `||` operator in the getVolume function. This commit fixes the issue by using the correct `??` operator. - Before this commit the volume slider in dark mode had the same background as the popover menu, making it difficult to see. This commit fixes the issue by making the slider darker than the background. - A volume ic
Original PR description
This commit fixes various issues with the context menu on the call participant: - Before this commit it wasn't possible to set the volume of a user to 0 due to the use of the `||` operator in the getVolume function. This commit fixes the issue by using the correct `??` operator. - Before this commit the volume slider in dark mode had the same background as the popover menu, making it difficult to see. This commit fixes the issue by making the slider darker than the background. - A volume icon was added to better indicate the slider purpose. - A volume percentage tooltip was added for more accurate use. - A chevron button was added to the participant card for better discoverability of the context menu. Forward-Port-Of: odoo/enterprise#77124
Before this commit, when editing a default value for a field, it was always setting th default on the company of the user (as set on the user), not on the current company the user is logged into. This was largely misleading. After this commit, we get and set the default on the current company. Some work need to be done in master to improve those flows. opw-4427384 Forward-Port-Of: odoo/enterprise#77186 Forward-Port-Of: odoo/enterprise#76819
Original PR description
Before this commit, when editing a default value for a field, it was always setting th default on the company of the user (as set on the user), not on the current company the user is logged into. This was largely misleading. After this commit, we get and set the default on the current company. Some work need to be done in master to improve those flows. opw-4427384 Forward-Port-Of: odoo/enterprise#77186 Forward-Port-Of: odoo/enterprise#76819
Miscellaneous changes
This commit fixes a typo in two mobile form view's tests where "screenLeft" was used instead of "scrollX". Note: this was detected while testing for the new Chrome's headless mode set by default on Chrome 128+. Forward-Port-Of: odoo/odoo#194105
Original PR description
This commit fixes a typo in two mobile form view's tests where "screenLeft" was used instead of "scrollX". Note: this was detected while testing for the new Chrome's headless mode set by default on Chrome 128+. Forward-Port-Of: odoo/odoo#194105
Currently, an error occurs when opening a preview of an invoice without an invoice date Step to produce: - Install the `l10n_ec_edi` module (with demo data). - Change a current company to 'EC Company', which has an 'Ecuador' country. - Create a new invoice, add a customer name, payment terms, and invoice line, save the record, - Click on the 'Preview' button (ensure that the invoice has no date). ```TypeError: unsupported operand type(s) for -: 'bool' and 'datetime.date'``` An err
Original PR description
Currently, an error occurs when opening a preview of an invoice without an invoice date Step to produce: - Install the `l10n_ec_edi` module (with demo data). - Change a current company to 'EC Company', which has an 'Ecuador' country. - Create a new invoice, add a customer name, payment terms, and invoice line, save the record, - Click on the 'Preview' button (ensure that the invoice has no date). ```TypeError: unsupported operand type(s) for -: 'bool' and 'datetime.date'``` An error occurs when the system attempts to calculate payment term days at [1], with using an invoice date, but it is not available. Link [1]: https://github.com/odoo/enterprise/blob/26aa95079af2a868c2991c7f19daee5328d5bb01/l10n_ec_edi/models/account_move.py#L440C22-L440C93 To resolve this issue, Provide a default day zero(0) for the payment term, if invoice date is not available. Sentry-6015854429 Forward-Port-Of: odoo/enterprise#76560 Forward-Port-Of: odoo/enterprise#72864
[FIX] hr_contract_salary: Custom document field not working Steps: - Create a new file field on employee - Open salary package configurator / personal info - Create a new info with the created field - category: personal documents - display type: document - Open Employee/Abigail - Open its contract - Generate an offer - 17 - Send by email - From the generated template, copy the button link - Open the copied link in another tab - master
Original PR description
[FIX] hr_contract_salary: Custom document field not working
Steps:
- Create a new file field on employee
- Open salary package configurator / personal info
- Create a new info with the created field
- category: personal documents
- display type: document
- Open Employee/Abigail
- Open its contract
- Generate an offer
- 17
- Send by email
- From the generated template, copy the button link
- Open the copied link in another tab
- master
- Just open the Link field
Actual result:
- KeyError for the filename of the new file field
Expected result:
- No error
- Filename field is also used when using a binary field
- File input is well show in the website configurator
opw-4382086
Caused by https://github.com/odoo/enterprise/commit/8e50071471d194bc8b594a79a95fe951cd5055ab & https://github.com/odoo/enterprise/commit/6f40549b98e65f813456442f7df35e9349a7639c
Forward-Port-Of: odoo/enterprise#75868