Original PR description

Issue:
When using the kiosk in versions 17.0 & 17.2, 2 visual issues arise:
- when trying to identify manually, the "Go back" arrow is cropped out of its' container
- when identified, the user's profile picture is cropped out of the greeting container

Steps to reproduce:
- Install the attendance module
- Go to Kiosk Mode
- Identify Manually

Cause:
For the "Go back arrow", its' position in the container is set to the top left corner (absolute 0;0). The problem is that these coordinates are set for the center of the button and not its' top-left end. For the profile pictures, they are displayed through "t" fields without any specific container. They thus have no styling/margination.

Since the overall style has already been revamped in 17.4, a simple "bandaid" fix should do.

Ticket:
opw-4366047

Original PR description

Update the reference XML ID from `l10n_in_reports_gstr` to `l10n_in_reports`
as `l10n_in_reports_gstr` has been merged into `l10n_in_reports`.

ref: https://github.com/odoo/enterprise/pull/75451/commits/03b2aceef289c14bd5d32355c14045fb72485ea7

Original PR description

In the tree view of the payslip model, we can do mass edit to create a journal entry. Before, we were able to perform this action on a paid payslip which does not make sense. Now we have an error message if we try to do it.

Task: 3874129

Original PR description

Before this commit:
When a user logged in with their notification_type set to inbox, they did not
receive notifications in their Odoo inbox for sign request documents,
even if they received mail notifications.

After this commit:
Users will receive notifications in their Odoo inbox for sign request documents
if their notification_type is set to inbox.

task-3995294

Original PR description

When you reduce the screen width or view the page on devices with
medium/small screens, the control panel button group rearranges itself
in an unsightly way (e.g. excessive button height).

It also looks like the Documents mobile view is too different from
the standard Odoo mobile view.

Medium breakpoint and below:
=======================

All actions of the selected documents are grouped together in a single
dropdown (in the control panel).

Small devices, portrait:
=================

We make the look and feel closer to the standard Odoo list view for
mobile, but we do it also for the kanban view as, in Documents, kanban
cards are selectable:
- The action dropdown for the selected documents takes the place of the
DocumentCogItemMenu.
- The list selection box floats to the top left of the navbar.
- The details panel toggler in the control panel navigation disappears.

task-4471881

Original PR description

Purpose:
--------
Currently, when posting a scheduled message failed due to an error,
the cron interrupts and will attempt to resend the message on each of its
subsequent runs and fail again, preventing any scheduled message to be
posted.

This commit changes the cron behavior to catch any exceptions raised during
message posting, notify the author of the message about the failure, and
delete the failed scheduled message. This prevents infinite retry attempts.

The notification to the author of the scheduled message contains the content
of the scheduled message. The rationale is that the posting might fail
because the user does not have access to the record it will be posted on
anymore, and won't be able to see the scheduled message again.

The scheduled messages will now be unlinked when unlinking the record on
which they are scheduled.

Task-4531402

Original PR description

Description of the issue/feature this PR addresses:

The `reset_applicant` method previously did not reset the `referral_state` to `'progress'`, causing the referral page to incorrectly display the applicant as "not hired" even when their actual state was ongoing.

This commit explicitly sets `referral_state` to `'progress'` to ensure proper state management when an applicant is restored.

opw-4523156

Related commit: f48ae97c2cadcdc085d32be25be365fdbb5605ef

Current behavior before PR:

Refuse an applicant and restore it, go to the referral app, the state will be displayed as not hired instead of ongoing

Desired behavior after PR is merged:

It should display as ongoing


---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Original PR description

Initialize the synchronization class at startup of the PoS before making any request to the server. This will ensure that the synchronization class is ready to handle the requests.

Original PR description

Before this commit, for a portal user, the creation of an API key will always be valid for one day.

This commit adds the option of selecting a period for which the API key will be valid.

The periods proposed take into account of the user's group. Consequently, in the case of a portal user, the administrator must enter a maximum number of days for the portal group
(the `api_key_duration` field in the `res.groups` model).

opw-4414586

Original PR description

Fixing Click All test broken since 662081ca3ad31170961eaf384f8aa2311d39f086

Original PR description

Steps to reproduce:
- Configure a product with a price of 229.
- Assign a tax to the product with the 'Included in Price' option enabled under advanced settings.
- Create a new Discount Program with the program type set to 'Discount Code'.
- Set a discount of  per order, using the same tax as the product.
- Create a sales order with the configured product.
- Apply the coupon code to the order.

Issue:
- The total amount of the sales order does not reduce to 0 as expected.
- The computed coupon discount amount is incorrect.

Cause:
- The case for handling tax-included pricing was not taken into consideration when calculating the discount.

Fix:
- Use the sum of line.price_total when tax-included pricing is applied to accurately compute the price_unit of the reward.

opw-4486030

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Original PR description

In commit[1] we implemented improvement for the images on the product page which makes the single image fill the total width of the column.

While it was fitting most of cases, uploading an image with particular aspect ratio w/ a height significantly longer than the width will render a very long image, extending the page.

This fix constraints the height to a maximum of 75vh, avoiding extra long images.

Note: the fix is done in CSS to be stable friendly, in master the goal will be to implement a dropdown allowing precise aspect ratio for single images. This will require improvement on the way the carousel / grid render it's single image. This will likely be handled in the e-commerce redesign (task-4252024)
[1]: odoo/odoo@da76f10558ea240a5f1b539cd4ce3ed3fc6628ab

opw-4458614
task-4522225

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Original PR description

- Configure an outstanding receipt account (e.g., Bank) for the Bank journal.

- Create an invoice and process the payment.

When attempting to resequence the journal entry corresponding to the `account.payment`, the journal entry is renamed, but the `account.payment` record is not updated accordingly.

https://github.com/odoo/odoo/commit/01b87f1230beac0568f4e3b1b76e547909506892 made the journal entry optional for payments, which broke the resequence.

opw-4437481


---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Original PR description

Before this commit, only pointerup was listened and was on the global document. Now, the event is listened on the ownerDocument of the element.

Like that, if the element is inside an iframe, it will be correctly listened. The "drop" is also added to the listened events, because sign doesn't use the draggable hook of owl, instead it uses the vanilla drag and drop system of javascript.

The dropzone shown during an onboarding tour is also fixed and takes into account the offset of the iframe in the top document.





---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Original PR description

When the Arabic language was selected, the PoS Restaurant module would error due to date formatting using Arabic numerals. This commit forces Latin digits in the date format to prevent the error.

opw-4544010

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Original PR description

The slide course member tour tests use  a channel called `Basics of Gardening - Test`. When the course is completed, clicking on `End course` will redirect the user to the courses home page. Since there is already a course (from demo data) called `Basics of Gardening`, the selector in the tour test actually selects this as the first match not the test course and the tour continues with the wrong course. It doesn't crash because both demo and test courses are public, so
 it's possible for demo and portal users to access them anyway and add/update a
 comment is done on the demo course.
 
 By this commit:
 - Demo data is removed in the tests to ensure that there is no collision between demo data and test data.
 - Since there are no predefined messages in the test data (the tour flow relied on the demo data messages before), the `update` does not happen in the tour without demo data. Some extra steps are also added to check the update message .

Original PR description

Steps:
- create a BOM for product A: component product B, ration 1.0, lead time 1 day
- put 4 as the on-hand qty of product A
- in the MPS, create records for products A & B with manufacture route for product A
- put 6 as the forecasted demand of product A  on the 2nd period or further
(this is so that the indirect demand of B is shown on the previous period)

Issue:
The indirect demand of product B will be 6 instead of 2 (6-4). This is because it uses `date_stop` with the lead time, see https://github.com/odoo/enterprise/pull/70232

Fix:
Subtract the starting qty from the indirect demand qty for the corresponding subproduct.
This is to make sure that the real `subproduct_indirect_demand` is compared to the
'ratioed' `replenish_qty` of the subproduct when selecting the date to use.

task 4381021

Original PR description

After this commit https://github.com/odoo/enterprise/commit/574d608b21199d5590d2335f4360a0a6470d1257, The workflow actions have been removed and replaced
by server actions and this PR is responsible for handling the migration of
workflow actions into server actions.(see https://github.com/odoo/upgrade/pull/6729)

```
AttributeError: 'int' object has no attribute 'create_document_from_attachment'
```
We created server actions sending to `journal_id` as `int` when migrating
dbs to 18.0. While the method originally supported only recordsets,
it's actually convenient to support `int`s here to avoid browse in the action
(more readable and more accessible to end-users).

opw-4453249

Original PR description

Since https://github.com/odoo/enterprise/commit/b198b60d337d2ea6a5d17872fb621322df57a20f get_invoiced should also return the invoice linked with the subscription based on the field account.move.line.subscription_id.

Unfortunatly, if the query based on sale_line_ids found no invoice for a given origin_order_id, the invoice found based on subscription_id were not added.

This can easily happen when the invoice are read by a user (for example odoo bot) that doesn't belong to the company of the invoice.

Solution: Invoice by origin_order_id should come from the result of the query + move_by_origin

Original PR description

If a warehouse has multi-steps deliveries, the actual demand of a product only takes the real outgoing move into account: the move that goes directly to the customer location.

Since moves are not created in advance anymore, we need to take the earlier moves in the chain into account instead while making sure that we only use a single move at a time.

The move used will be the last created in the chain, the one without `move_dest_ids`.

task 4510137

Original PR description

Issue:  Mobility budget is shown in every contract if it is installed on the db

- make the budegt only visible for BE

Task: 4529227

Original PR description

This commit aims to ensure that the expected working hours for flexible resources are not rounded to the hours when displayed on the Gantt progress bar. Previously, the total hours were being rounded to the hours, which could lead to inaccuracies in the representation of the expected working hours on the gantt view. By changing the rounding to the minutes, we ensure that the Gantt progress bar accurately reflects the precise hours worked by flexible resources.

Steps to reproduce:
-------------------
1. Create an employee with flexible hours ex. 42:30h per week (8:30h per day)
2. Create a shift for the same employee on planning.
3. In the gantt view, when setting the date range to a week, the expected working hours of the period is showing 42h instead of 42:30h

task-id: 4506633

Original PR description

Fix the drag_and_drop run of sign_tour to fit in the new tour system.

Original PR description

Before this commit, validating an order resulted in an error because the wrong model "account_move" was used instead of "account.move".

opw-4543705

Original PR description

When you reduce the screen width or view the page on devices with small
screens, the control panel button group rearranges itself in an
unsightly way (e.g. excessive button height).

For mobile devices, we use overflow auto on the action btns
of the panel. Then they keep their aspects and are still accessible to
users.

FW-PORT until 18.1

task-4471881

Original PR description

Steps to reproduce:
CRM > Sales > Teams > Pipeline > Graph View >Insert Into Spreadsheet

=> Boom: Name 'active_id' is not defined.

The action context contains a dynamic value, which needs the *current* to be evaluated.

Task: 4548431
opw-4491590
opw-4500397

Original PR description

In this PR odoo/enterprise/pull/64323, certificates were refactored. However, one method has passed through the net and was left using the old way.

This commit fixes that by removing the call and using the new refactored certificates

opw-4423435

Original PR description

Fix runbot error: 113710