Saturday, March 8, 2025
6 changes · 18.0
Resolved issues and error corrections
Follow-up of https://github.com/odoo/odoo/pull/194499 Forgot to update the POT file, as the string have changed.
Original PR description
Follow-up of https://github.com/odoo/odoo/pull/194499 Forgot to update the POT file, as the string have changed.
Miscellaneous changes
Versions -------- - 17.0+ Steps ----- 1. Log in as admin; 2. have a user with access to Sales: Own Documents but not Invoicing; 3. assign them as a salesperson to a sales order; 4. create a draft invoice for the order; 5. assign admin as salesperson on the invoice; 6. log in as user; 7. create invoice for the sales order. Issue ----- - No existing draft warning is displayed. - Trying to create a draft results in an access error. Cause ----- The wizards starts out as a `ne
Original PR description
Versions -------- - 17.0+ Steps ----- 1. Log in as admin; 2. have a user with access to Sales: Own Documents but not Invoicing; 3. assign them as a salesperson to a sales order; 4. create a draft…
Versions -------- - 17.0+ Steps ----- 1. Log in as admin; 2. have a user with access to Sales: Own Documents but not Invoicing; 3. assign them as a salesperson to a sales order; 4. create a draft invoice for the order; 5. assign admin as salesperson on the invoice; 6. log in as user; 7. create invoice for the sales order. Issue ----- - No existing draft warning is displayed. - Trying to create a draft results in an access error. Cause ----- The wizards starts out as a `newId`. Consequently, its `sale_order_ids` field is also `newId` with the actual order id as its origin. When trying to read the `invoice_ids` of a pseudo-record, it will ignore any records you don't have access to. This is why you don't see an exisiting draft invoice warning. Then when creating the invoice, the check is done again, but no longer as pseudo-records. Now it does get an invoice to check, and throws an error because it's assigned to a different user. Solution -------- Use `_origin.sudo()` to ensure access to the `state` field of the invoices. opw-4554639 Forward-Port-Of: odoo/odoo#200722
Versions -------- - saas-17.4+ Steps ----- Unsure. Issue ----- The ribbon element is technically always visible, even if the product has no ribbon. This can lead to CSS shadow being applied to it, resulting in a white triangle in the top right corner of images:  Cause ----- The `_get_position_class` method returns a position, even for empty recordsets, in which case it will return `o_ribbo
Original PR description
Versions -------- - saas-17.4+ Steps ----- Unsure. Issue ----- The ribbon element is technically always visible, even if the product has no ribbon. This can lead to CSS shadow being applied to it, resulting in a white triangle in the top right corner of images:  Cause ----- The `_get_position_class` method returns a position, even for empty recordsets, in which case it will return `o_ribbon_right`. Solution -------- If there is no record, return the `d-none` class to properly hide the element. opw-4151902 Forward-Port-Of: odoo/odoo#200552
We need to use either location_dest_id or location_final_id in the stock quantity report. Commit e16b3bc adds the logic for this but implements it using a CASE in the JOIN which the planner selects a nested loop based plan to accomplish (quadratic time). Change it here to a boolean expression which can be better optimized by the query planner. Forward-Port-Of: odoo/odoo#200682
Original PR description
We need to use either location_dest_id or location_final_id in the stock quantity report. Commit e16b3bc adds the logic for this but implements it using a CASE in the JOIN which the planner selects a nested loop based plan to accomplish (quadratic time). Change it here to a boolean expression which can be better optimized by the query planner. Forward-Port-Of: odoo/odoo#200682
Before this commit and since https://github.com/odoo/odoo/pull/110188, The people invited to a channel by someone in a call in that channel wouldn't receive a call invitation, as the invitation parameter was omitted during the refactor. This commit fixes this issue. Forward-Port-Of: odoo/odoo#199682 Forward-Port-Of: odoo/odoo#199580
Original PR description
Before this commit and since https://github.com/odoo/odoo/pull/110188, The people invited to a channel by someone in a call in that channel wouldn't receive a call invitation, as the invitation parameter was omitted during the refactor. This commit fixes this issue. Forward-Port-Of: odoo/odoo#199682 Forward-Port-Of: odoo/odoo#199580
Forward-Port-Of: odoo/enterprise#80921
Original PR description
Forward-Port-Of: odoo/enterprise#80921