Saturday, April 5, 2025
4 changes · 18.0
Miscellaneous changes
Reproduce: 1. Make a scored live session survey 2. Add a single choice question with a <0.5 point answer (or < 1 with speed reward) 3. Create a live session 4. Join with one participant 5. Play the survey, have the participant answer correctly (after half the time for speed reward if that case is tested) 6. Proceed to leaderboard and expect a crash. This happens because when `max_score` or `max_score_question` are <= 0.5, divisions by round(<=.5) are divisions by 0. Using 3 digits fo
Original PR description
Reproduce: 1. Make a scored live session survey 2. Add a single choice question with a <0.5 point answer (or < 1 with speed reward) 3. Create a live session 4. Join with one participant 5. Play the survey, have the participant answer correctly (after half the time for speed reward if that case is tested) 6. Proceed to leaderboard and expect a crash. This happens because when `max_score` or `max_score_question` are <= 0.5, divisions by round(<=.5) are divisions by 0. Using 3 digits for rounding has two advantages: * It is very unlikely that an answer will have a value below 0.0006 (not 0 - that case is supported- but rounds to 0). * It makes the template resilient to differences in precisions used for the various numbers (relevant in 17.4 where `answer_score` and `scoring_total` can be different by <0.01). Task-4655784 Forward-Port-Of: odoo/odoo#204832 Forward-Port-Of: odoo/odoo#203988
Description of the issue/feature this PR addresses: This PR is to avoid making unnecessary format validations on manual documents, as well as to improve the error message shown when the validation is done and the user had entered an invalid document number. A use case for these changes is when the user wants to register an invoice from a foreign supplier that does not have the Uruguayan format, and at the moment of filling the “Document Number” field, an error message appears saying that it do
Original PR description
Description of the issue/feature this PR addresses: This PR is to avoid making unnecessary format validations on manual documents, as well as to improve the error message shown when the validation is…
Description of the issue/feature this PR addresses: This PR is to avoid making unnecessary format validations on manual documents, as well as to improve the error message shown when the validation is done and the user had entered an invalid document number. A use case for these changes is when the user wants to register an invoice from a foreign supplier that does not have the Uruguayan format, and at the moment of filling the “Document Number” field, an error message appears saying that it does not comply with the Uruguayan number validations. Current behavior before PR: Either electronic or manual document numbers format were validated against the electronic documents format. Desired behavior after PR is merged: Only electronic document numbers are validated to check if they have the proper format. Steps to reproduce the error: 1) Install l10n_uy 2) Create an invoice using a manual journal. 3) Set a random document number (for example '1234') 4) Check that a pop up is raised, saying that the format is invalid. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#198216
**Problem**: Commit [f523cb8](https://github.com/odoo/odoo/commit/f523cb85174687856d2c93fbc3c2f52a307f6761) did not properly handle background images, leading to issues when retrieving the correct attachment source. **Solution**: Use `el.dataset.bgSrc` to get the correct attachment source for background images. **Steps to reproduce**: 1. Add a "Banner" block. 2. Update the image. 3. Save. - **Issue**: image lost. **opw-4686236** --- I confirm I have signed the CLA and read
Original PR description
**Problem**: Commit [f523cb8](https://github.com/odoo/odoo/commit/f523cb85174687856d2c93fbc3c2f52a307f6761) did not properly handle background images, leading to issues when retrieving the correct attachment source. **Solution**: Use `el.dataset.bgSrc` to get the correct attachment source for background images. **Steps to reproduce**: 1. Add a "Banner" block. 2. Update the image. 3. Save. - **Issue**: image lost. **opw-4686236** --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#204812 Forward-Port-Of: odoo/odoo#204662
We need to inform if the INV will be paid in foreign currency when the INV is issued in foreign currency. For this, we cameup with a proposal to cover all possible scenarios: * Global setting for all YES (payments in foreign currency) * Global setting for all NO (payments in local currency) * Depending on the AR account (depending on the configured AR account, the payment will be in foreign or local currency, and this AR account can be configured per partner if desired) This gives the
Original PR description
We need to inform if the INV will be paid in foreign currency when the INV is issued in foreign currency. For this, we cameup with a proposal to cover all possible scenarios:
* Global setting for all YES (payments in foreign currency)
* Global setting for all NO (payments in local currency)
* Depending on the AR account (depending on the configured AR account, the payment will be in foreign or local currency, and this AR account can be configured per partner if desired) This gives the user the flexibility to choose and take into account the different possible scenarios we discussed with AdHoc (AR Partner).
Latam Task 1300 / Adhoc task 47476
Forward-Port-Of: odoo/enterprise#82924
Forward-Port-Of: odoo/enterprise#79297