Thursday, August 29, 2024
7 changes
2 changes
Resolved issues and error corrections
Users can now mark or unmark products as favorites directly from the product page. This restores expected behavior and makes it easier to manage commonly used products without extra navigation.
Original PR description
Problem: The `is_favorite` field was set to read-only on the product page, preventing users from toggling the favorite status. Steps to reproduce: - Open any product page. - Try to toggle the favorite status. opw-4139344 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fleet vehicle records now only accept numbers in the Model Year field. This prevents users from entering values like ranges or text that could cause an error when saving a vehicle.
Original PR description
Currently an error occurs when a user adds a character in the `Model Year` of fleet vehicles. Stack Trace: ``` ValueError: invalid literal for int() with base 10: '2016/2017' File "odoo/http.py",…
Currently an error occurs when a user adds a character in the `Model Year` of fleet vehicles.
Stack Trace:
```
ValueError: invalid literal for int() with base 10: '2016/2017'
File "odoo/http.py", line 2373, in __call__
response = request._serve_db()
File "odoo/http.py", line 1903, in _serve_db
return self._transactioning(
File "odoo/http.py", line 1966, in _transactioning
return service_model.retrying(func, env=self.env)
File "odoo/service/model.py", line 134, in retrying
result = func()
File "odoo/http.py", line 1933, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "odoo/http.py", line 2177, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "odoo/addons/base/models/ir_http.py", line 223, in _dispatch
result = endpoint(**request.params)
File "odoo/http.py", line 754, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "addons/web/controllers/dataset.py", line 35, in call_kw
return call_kw(request.env[model], method, args, kwargs)
File "odoo/api.py", line 459, in call_kw
result = getattr(recs, name)(*args, **kwargs)
File "addons/web/models/models.py", line 73, in web_save
self = self.create(vals)
File "<decorator-gen-41>", line 2, in create
File "odoo/api.py", line 421, in _model_create_multi
return create(self, [arg])
File "addons/mail/models/mail_thread.py", line 268, in create
threads = super(MailThread, self).create(vals_list)
File "<decorator-gen-0>", line 2, in create
File "odoo/api.py", line 422, in _model_create_multi
return create(self, arg)
File "odoo/models.py", line 4768, in create
records = self._create(data_list)
File "odoo/models.py", line 4935, in _create
colval = field.convert_to_column(stored[fname], self, stored)
File "odoo/fields.py", line 1491, in convert_to_column
return int(value or 0)
```
With the recently code change with https://github.com/odoo/odoo/commit/d69cb61b6c69a4110bc1af30323d5c8b8398129b, a 'char' widget was added in the field 'model_year' so it allows entering a character instead of an of an integer.
This commit removes the 'char' widget from the mode l'model_year' so the user will allow entering only numbers.
sentry-56670643534 changes
Resolved issues and error corrections
Demo bank records for Indian payroll now use correctly formatted bank identifier values. This helps ensure sample payroll data follows expected banking standards and avoids confusion during demos or testing.
Original PR description
In this commit, add formatted values for demo bank data. format: 11 characters - alphabetic code for the first four characters. - fifth character should always be zero and reserved for future use. - last 6 characters are usually numeric but can also be alphabetic. Related Task - 3794859
1 change
Resolved issues and error corrections
This update fixes a test reliability issue in the manufacturing subcontracting accounting module. The change ensures test data is processed in a consistent order every time, preventing intermittent test failures that could occur when data was retrieved in different sequences.
Original PR description
This commit make sure the values are get in the same order every time to avoid falsy error runbot 76085 Forward-Port-Of: odoo/enterprise#68963
This fix updates how VoIP call data is refreshed so it stays reliable after underlying system changes. It also makes related automated tests faster, helping future VoIP updates be validated more efficiently.
Original PR description
The voip model was overriding `static insert` method as if this works on a single record. For some time, this method works on multiple records, and its implementation detail has changed so assuming it does `get() ?? new()` is no longer guaranteed. The intent of override was to enrich data after them being assigned. This has been converted to an override of `update()`, which guarantees it being called whenever fields are updated on record, without making too much assumption in implementation details of records. This commit also speeds up tests of VOIP, which were awaiting input that contains a value. This is not observed by mutation observer, so these tests took 3 seconds to execute. This PR puts the value in `data-value`, so that this is a mutation that can be observed by contains, thus reducting time of such test to mere dozens of ms. https://github.com/odoo/odoo/pull/177059
Clicking a journal item in Accounting no longer opens an unwanted form view. When an attachment is available, users are taken to the expected preview instead, keeping the review flow focused and avoiding confusion.
Original PR description
The bug consisted of the form view to be opened when we clicked on an aml (journal item). The expected behaviour is to preview its attachment if there is one. But we never want to show that form view The cause is a commit from RD-JS https://github.com/odoo/odoo/pull/176707/files That changed the logic of opening the form view if there is no actions. task-4132306
Commission report filters have been adjusted so users only see options they are allowed to use. This prevents confusing access-right errors and keeps reporting tools aligned with each user's permissions.
Original PR description
Before this commit, some filters raised access right errors, filter that should be used have received access right and others were hidden.